New issue
Advanced search Search tips

Issue 798965 link

Starred by 1 user
Status: Verified
Owner:
wuyingbing@chromium.org
Closed: Sep 5
Cc:
shuchen@chromium.org
xiulingw@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Dragging floating keyboard not works with suggestion line displayed

Project Member Reported by zhan...@chromium.org, Jan 4 2018 
Chrome OS Version: Version 65.0.3299.0 dev 32-bit
Chrome OS Platform: 101276.0.0 Official build dev-channel kevin
Google_kevin.8785.220.0


Steps To Reproduce:
1.Switch to  Floating keyboard 
2.Pressing left-top corner of the keyboard , dragging it


Actual:
Not always works , sometimes can drag it to anywhere, sometimes have no response

Comment 1 by zhan...@chromium.org, Jan 5 2018 

When suggest word displayed, pressing top-left corner will cover the first
highlight suggestion word, so can not drag it , 
when have no suggest word displayed , can drag keyboard to anywhere;

Comment 2 by zhan...@chromium.org, Jan 5 2018

Summary: Dragging floating keyboard not works with suggestion line displayed (was: Dragging floating keyboard function not works well )
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9dc7440c3316198db04175cf37cc29db8950cf4

commit a9dc7440c3316198db04175cf37cc29db8950cf4
Author: Yingbing Wu <wuyingbing@chromium.org>
Date: Tue Jan 09 08:24:01 2018

Polishs the dragging logic. Only allow to start dragging inside draggable area.

Moves keyboard on mouse drag event or touch movement.

Disables dragging when event is outside the dragging area.

Bug:  chromium:795648 , chromium:798965 
Change-Id: I88cf365481dbb93622ad0dcdbce1e747543f86bc
Reviewed-on: https://chromium-review.googlesource.com/845548
Commit-Queue: Yingbing Wu <wuyingbing@chromium.org>
Reviewed-by: Blake O'Hare <blakeo@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Shu Chen <shuchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527936}
[modify] https://crrev.com/a9dc7440c3316198db04175cf37cc29db8950cf4/ui/keyboard/container_behavior.h
[modify] https://crrev.com/a9dc7440c3316198db04175cf37cc29db8950cf4/ui/keyboard/container_floating_behavior.cc
[modify] https://crrev.com/a9dc7440c3316198db04175cf37cc29db8950cf4/ui/keyboard/container_floating_behavior.h
[modify] https://crrev.com/a9dc7440c3316198db04175cf37cc29db8950cf4/ui/keyboard/container_full_width_behavior.cc
[modify] https://crrev.com/a9dc7440c3316198db04175cf37cc29db8950cf4/ui/keyboard/container_full_width_behavior.h
[modify] https://crrev.com/a9dc7440c3316198db04175cf37cc29db8950cf4/ui/keyboard/keyboard_controller.cc
[modify] https://crrev.com/a9dc7440c3316198db04175cf37cc29db8950cf4/ui/keyboard/keyboard_controller.h
[modify] https://crrev.com/a9dc7440c3316198db04175cf37cc29db8950cf4/ui/keyboard/keyboard_event_filter.cc
[modify] https://crrev.com/a9dc7440c3316198db04175cf37cc29db8950cf4/ui/keyboard/keyboard_event_filter.h

Comment 4 by wuyingbing@chromium.org, Sep 5

Status: Fixed (was: Assigned)

Comment 5 by zhan...@chromium.org, Sep 6

Status: Verified (was: Fixed)
Verified in 70.0.3538.o 11038 canary-channel bob 
Input tools version:
71.0.20180903.211395702
►

Sign in to add a comment