New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 798952 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

20kB regression in resource_sizes (MonochromePublic.apk) at 526930:526930

Project Member Reported by huangs@google.com, Jan 4 2018

Issue description

Caused by “[Ribbon] Hard-code GetJSPropertyName values”

Commit: 16949390781f2e0ef12abcf4a57e8e1e1b1ccc4b

Link to size graph: https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICQ6IGKrgoM
(zoom in by selecting region, then click on region).

Debugging size regressions is documented at: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/apk_size_regressions.md#Debugging-Apk-Size-Increase

Based on the graph: 20kb of native code.

It looks like this increase was probably unexpected or might be avoidable.
Please have a look and either:

Close as “Won't Fix” with a short justification, or
Land a revert / fix-up.

 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=798952

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=12cad8b441212505aa71ec091f8bdc9e50cce8d3f213c1ca5aec30a076ccbf6d


Bot(s) for this bug's original alert(s):

Android Builder

Comment 2 by huangs@google.com, Jan 4 2018

To get details, run:

tools/binary_size/diagnose_bloat.py --cloud 16949390781f2e0ef12abcf4a57e8e1e1b1ccc4b

Output excerpt:

Section Sizes (Total=20.0kb (20480 bytes)):
    .bss: 0 bytes (0 bytes) (not included in totals)
    .data: 0 bytes (0 bytes) (0.0%)
    .data.rel.ro: 1760 bytes (1760 bytes) (8.6%)
    .other: 1249 bytes (1249 bytes) (6.1%)
    .pak.nontranslated: 0 bytes (0 bytes) (0.0%)
    .pak.translations: 0 bytes (0 bytes) (0.0%)
    .rel.dyn: 3.45kb (3528 bytes) (17.2%)
    .rodata: 6.36kb (6512 bytes) (31.8%)
    .text: 7.26kb (7431 bytes) (36.3%)

787 symbols added (+), 450 changed (~), 1 removed (-), 711754 unchanged (not shown)
Of changed symbols, 1232 grew, 6 shrank
Number of unique symbols 536568 -> 537353 (+785)
0 paths added, 0 removed, 422 changed

Showing 1,238 symbols (aliases not grouped for diffs) with total pss: 16951 bytes
Histogram of symbols based on PSS:
    (-256,-128]: 1   (-16,-8]: 1   [1,2): 1      [8,16): 148     [128,256): 1
     (-128,-64]: 1    (-8,-4]: 1   [2,4): 1     [16,32): 635    [512,1024): 1
      (-64,-32]: 1    (-4,-2]: 1   [4,8): 443   [32,64): 1     [1024,2048): 1
.text=7.26kb     .rodata=6.36kb     .data.rel.ro=1760 bytes .data=0 bytes    .bss=0 bytes    .pak.translations=0 bytes    .pak.nontranslated=0 bytes    .other=1249 bytes total=16.6kb
Number of unique paths: 422

Section Legend: t=.text, r=.rodata, R=.data.rel.ro, d=.data, b=.bss, p=.pak.translations, P=.pak.nontranslated, o=.other
Index | Running Total | Section@Address | Δ PSS (Δ size_without_padding) | Path
------------------------------------------------------------
~ 0)       1249 (7.4%)  o@0x0        1249 (4064->5313)  {{no path}}
               ELF file overhead
~ 1)       1785 (10.5%) r@Group      536 (6844->7380)   {{no path}}
               ** merge constants (count=16)
~ 2)       2018 (11.9%) t@Group      233 (0->0)         {{no path}}

...

+ 27)      2378 (14.0%) r@0x2a26d17  26 (0->26)         blink/core/css/properties/CSSUnresolvedProperty.cpp

I  77919 Creating: Resource Sizes Diff

******************************Resource Sizes Diff******************************
MonochromePublic.apk_Breakdown (+20,480 bytes)
        -3 bytes Zip Overhead
   +20,480 bytes Native code size
        +3 bytes Package metadata size
MonochromePublic.apk_Specifics
   +20,480 bytes normalized apk size
   +20,480 bytes main lib size

Comment 3 by huangs@google.com, Jan 4 2018

Owner: rjwright@chromium.org
Status: Assigned (was: Untriaged)
Note that from the histogram, that the size increase is from a large number of small increases. These are [size in bytes): symbol count
[4,8): 443 
[8,16): 148 
[16,32): 635
Ping rjwright - ptal.
Status: WontFix (was: Assigned)
The delta is showing up as 0% of the native code. 

Sign in to add a comment