New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 798946 link

Starred by 0 users
Status: Verified
Owner:
vapier@chromium.org
Closed: Jan 2018
Cc:
briannorris@chromium.org
█ cernekee@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

minifakedns: punt

Project Member Reported by vapier@chromium.org, Jan 4 2018 
minifakedns is a weak DNS implementation.  it replies with an A record for all queries (causing  issue 208317 ), and assumes only one question record was sent.  it also replicates all the input records into the output, but doesn't properly count them.

it looks like the only user of this was PyAuto, but that was all deleted via  issue 224072 .  so lets punt minifakedns rather than try to fix it (or replace with a sane implementation like dnspython).
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/5ad15cefe1957cbf1640b927cbbc5e677d2f1b0d

commit 5ad15cefe1957cbf1640b927cbbc5e677d2f1b0d
Author: Mike Frysinger <vapier@chromium.org>
Date: Thu Jan 04 22:35:20 2018

dns_server: punt

This was only used by PyAuto, but that was deleted long ago.

BUG= chromium:798946 
TEST=precq passes

Change-Id: I8094a223b8027ff30bafdeb98127e6001ba01652
Reviewed-on: https://chromium-review.googlesource.com/848543
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>

[delete] https://crrev.com/da5f2acdb7604d42e33477b5a8174406a7c8469f/client/cros/dns_server.py
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/bd5c2f590b6c408329d36b33617bb41c02763901

commit bd5c2f590b6c408329d36b33617bb41c02763901
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri Jan 05 05:52:08 2018

target-chromium-os-test: drop minifakedns

Nothing uses this anymore, so punt it.

BUG= chromium:798946 
TEST=precq passes

Change-Id: Iba682a2bdb490017e53bd0d2af872c07e1472ea1
Reviewed-on: https://chromium-review.googlesource.com/849138
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>

[modify] https://crrev.com/bd5c2f590b6c408329d36b33617bb41c02763901/virtual/target-chromium-os-test/target-chromium-os-test-1.ebuild
[rename] https://crrev.com/bd5c2f590b6c408329d36b33617bb41c02763901/virtual/target-chromium-os-test/target-chromium-os-test-1-r58.ebuild
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/817e32fb68ccb03d464e66002874d0674d4d7840

commit 817e32fb68ccb03d464e66002874d0674d4d7840
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri Jan 05 17:38:38 2018

minifakedns: punt

Nothing uses this anymore, so punt it.

BUG= chromium:798946 
TEST=precq passes

Change-Id: Id6a0ba825032cc8ea5ae5e87a94b72a6fea03bd4
Reviewed-on: https://chromium-review.googlesource.com/847945
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>

[delete] https://crrev.com/d3dc97848a6a18252962fb59f3ae368d64149a60/chromeos-base/minifakedns/minifakedns-0.0.1-r13.ebuild
[delete] https://crrev.com/d3dc97848a6a18252962fb59f3ae368d64149a60/chromeos-base/minifakedns/minifakedns-9999.ebuild
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 6 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/fdad15db513b6539733b117a4ad0eb44bed32614

commit fdad15db513b6539733b117a4ad0eb44bed32614
Author: Mike Frysinger <vapier@chromium.org>
Date: Sat Jan 06 00:42:45 2018
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/manifest/+/f83203b8ae9f76b842434b3f5fe6aab15edd439e

commit f83203b8ae9f76b842434b3f5fe6aab15edd439e
Author: Mike Frysinger <vapier@chromium.org>
Date: Sat Jan 06 00:42:45 2018

drop minifakedns

BUG= chromium:798946 
TEST=precq passes
CQ-DEPEND=CL:*538421

Change-Id: I546d6abdf59be185dedae96e0fd8c77284876784
Reviewed-on: https://chromium-review.googlesource.com/848544
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>

[modify] https://crrev.com/f83203b8ae9f76b842434b3f5fe6aab15edd439e/full.xml

Comment 6 by vapier@chromium.org, Jan 6 2018

Status: Fixed (was: Started)
RIP

Comment 7 by harpreet@chromium.org, Sep 13

Status: Verified (was: Fixed)
►

Sign in to add a comment