New issue
Advanced search Search tips

Issue 798937 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 545318



Sign in to add a comment

[css-typed-om] CSSStyleValue.parse/parseAll should throw TypeError

Project Member Reported by shend@chromium.org, Jan 4 2018

Issue description

As resolved in https://github.com/w3c/css-houdini-drafts/issues/305, parse/parseAll should just throw TypeError instead of a mix of TypeError and SyntaxError.

There are existing tests for error checking, but they expect SyntaxError so the tests need to be changed.
 
Owner: hs1217....@samsung.com
Status: Started (was: Available)
i will take this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c5288682642b8ce28c30bb539935506e26465ef

commit 6c5288682642b8ce28c30bb539935506e26465ef
Author: Hwanseung Lee <hs1217.lee@samsung.com>
Date: Thu Jan 04 22:44:42 2018

[css-typed-om] CSSStyleValue.parse/parseAll should throw TypeError

present, CSSStyleValue.parse/parseAll thrown type or syntax error.
but CSSStyleValue.parse/parseAll was decided to throw only
type error.

https://github.com/w3c/css-houdini-drafts/issues/305

Bug:  798937 
Change-Id: I00d6855d1b3667441d009d8d3551daed970cab1a
Reviewed-on: https://chromium-review.googlesource.com/849972
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#527126}
[modify] https://crrev.com/6c5288682642b8ce28c30bb539935506e26465ef/third_party/WebKit/LayoutTests/typedcssom/stylevalue-objects/parse-parseAll.html
[modify] https://crrev.com/6c5288682642b8ce28c30bb539935506e26465ef/third_party/WebKit/Source/core/css/cssom/CSSStyleValue.cpp

Status: Fixed (was: Started)

Sign in to add a comment