Issue metadata
Sign in to add a comment
|
Corp OpenVPN UI broken in M65 canary |
||||||||||||||||||||||
Issue descriptionOn bob 65.0.3299.0 / 10276.0.0, I click: system menu -> VPN -> Google OpenVPN. This opens up the newly redesigned dialog. I enter my password + OTP then click Connect. Save Identity is unchecked. The Connect button gets grayed out and the dialog shows "Connecting" at the bottom. In the system menu, the VPN entry does not show "Connecting," and the VPN badge does not appear in the tray. In /var/log/net.log there is no indication of openvpn getting invoked. chrome://device-log suggests a missing passphrase: https://screenshot.googleplex.com/tWb1VR9ptCP I had to hit Cancel to get out of this state. I don't see the same problem when creating an OpenVPN connection by hand. This only seems to affect the one pushed through policy.
,
Jan 4 2018
,
Jan 6 2018
,
Jan 6 2018
Also: when using the old UI (disable-network-settings-config): The first corp VPN connection after a reboot works. Subsequent connections fail with internal error, seems to be missing some credentials: 2018-01-06T14:49:20.858224-08:00 INFO shill[1320]: [INFO:openvpn_management_server.cc(226)] >INFO:OpenVPN Management Interface Version 1 -- type 'help' for more info 2018-01-06T14:49:20.858280-08:00 INFO shill[1320]: [INFO:openvpn_management_server.cc(405)] Client waiting for hold release. 2018-01-06T14:49:20.858306-08:00 INFO shill[1320]: [INFO:openvpn_management_server.cc(154)] Releasing hold. 2018-01-06T14:49:20.858502-08:00 INFO shill[1320]: [INFO:openvpn_management_server.cc(417)] SUCCESS: real-time state notification set to ON 2018-01-06T14:49:20.858806-08:00 INFO shill[1320]: [INFO:openvpn_management_server.cc(417)] SUCCESS: hold release succeeded 2018-01-06T14:49:20.911379-08:00 INFO shill[1320]: [INFO:wifi.cc(323)] Scan on mlan0 from RequestScan 2018-01-06T14:49:20.911735-08:00 INFO shill[1320]: [INFO:openvpn_management_server.cc(236)] Processing need-password message. 2018-01-06T14:49:20.911787-08:00 INFO shill[1320]: [INFO:openvpn_management_server.cc(319)] Perform authentication: Auth 2018-01-06T14:49:20.911825-08:00 ERR shill[1320]: [ERROR:openvpn_management_server.cc(323)] Not implemented reached in void shill::OpenVPNManagementServer::PerformAuthentication(const std::string &): Missing credentials: no-password I re-entered my password + OTP into the form. I'm not checking the box to save credentials. Unsure whether it's a shill or Chrome regression. This is on 65.0.3313.0 / 10284.0.0 (Official Build) canary-channel bob
,
Jan 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08fab4c10338d62b9074a3c3737cd5b327d05da9 commit 08fab4c10338d62b9074a3c3737cd5b327d05da9 Author: Steven Bennetts <stevenjb@chromium.org> Date: Sat Jan 20 00:05:07 2018 ONC: Fix networkingPrivate PushPeerInfo type This was only recently noticed when Shill started setting the property. Bug: 798924 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I031e0faf80fda62c006968009ab746d8c105e2de Reviewed-on: https://chromium-review.googlesource.com/876881 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#530676} [modify] https://crrev.com/08fab4c10338d62b9074a3c3737cd5b327d05da9/extensions/common/api/networking_private.idl [modify] https://crrev.com/08fab4c10338d62b9074a3c3737cd5b327d05da9/third_party/closure_compiler/externs/networking_private.js
,
Jan 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b08867e4e0e133862c0a16b08b2b7990ac45a59e commit b08867e4e0e133862c0a16b08b2b7990ac45a59e Author: Steven Bennetts <stevenjb@chromium.org> Date: Mon Jan 22 21:47:19 2018 VPN: Do not share configured VPNs VPN configurations were never shared in the non Settings based UI. We should preserve that behavior in the new UI. (The current behavior is completely wrong and always shares VPN configurations even when they require certificates). Bug: 798924 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4470a77b8f4f36e0f46aba5505eafd96fb0ca799 Reviewed-on: https://chromium-review.googlesource.com/876933 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Kevin Cernekee <cernekee@chromium.org> Reviewed-by: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#531008} [modify] https://crrev.com/b08867e4e0e133862c0a16b08b2b7990ac45a59e/chrome/test/data/webui/cr_components/network_config_test.js [modify] https://crrev.com/b08867e4e0e133862c0a16b08b2b7990ac45a59e/ui/webui/resources/cr_components/chromeos/network/network_config.js
,
Jan 22 2018
,
Jan 23 2018
The CL for comment #5 is the primary cause but we need to merge both changes so that we can verify the probem on a corp device. They are both minor but critical changes.
,
Jan 23 2018
,
Jan 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d4bc3386e870b26fe289e6aa30fbca28325a52c commit 0d4bc3386e870b26fe289e6aa30fbca28325a52c Author: Steven Bennetts <stevenjb@chromium.org> Date: Tue Jan 23 22:58:04 2018 ONC: Fix networkingPrivate PushPeerInfo type This was only recently noticed when Shill started setting the property. TBR=stevenjb@chromium.org (cherry picked from commit 08fab4c10338d62b9074a3c3737cd5b327d05da9) Bug: 798924 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I031e0faf80fda62c006968009ab746d8c105e2de Reviewed-on: https://chromium-review.googlesource.com/876881 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Toni Barzic <tbarzic@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#530676} Reviewed-on: https://chromium-review.googlesource.com/882385 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#44} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/0d4bc3386e870b26fe289e6aa30fbca28325a52c/extensions/common/api/networking_private.idl [modify] https://crrev.com/0d4bc3386e870b26fe289e6aa30fbca28325a52c/third_party/closure_compiler/externs/networking_private.js
,
Jan 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f3e1141f3e72b70d287a1c7443d3c4b8725cc6ff commit f3e1141f3e72b70d287a1c7443d3c4b8725cc6ff Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Jan 24 00:33:27 2018 VPN: Do not share configured VPNs VPN configurations were never shared in the non Settings based UI. We should preserve that behavior in the new UI. (The current behavior is completely wrong and always shares VPN configurations even when they require certificates). TBR=stevenjb@chromium.org (cherry picked from commit b08867e4e0e133862c0a16b08b2b7990ac45a59e) Bug: 798924 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4470a77b8f4f36e0f46aba5505eafd96fb0ca799 Reviewed-on: https://chromium-review.googlesource.com/876933 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Kevin Cernekee <cernekee@chromium.org> Reviewed-by: Toni Barzic <tbarzic@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#531008} Reviewed-on: https://chromium-review.googlesource.com/882551 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#52} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/f3e1141f3e72b70d287a1c7443d3c4b8725cc6ff/chrome/test/data/webui/cr_components/network_config_test.js [modify] https://crrev.com/f3e1141f3e72b70d287a1c7443d3c4b8725cc6ff/ui/webui/resources/cr_components/chromeos/network/network_config.js |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by cernekee@chromium.org
, Jan 4 2018