New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 798914 link

Starred by 1 user
Status: Fixed
Owner:
drinkcat@chromium.org
Closed: Jun 2018
Cc:
█ vpalatin@chromium.org
█ rspangler@chromium.org
coconutruben@chromium.org
adurbin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

ec: Enable CONFIG_LTO on selected boards (e.g. chell)

Project Member Reported by drinkcat@chromium.org, Jan 4 2018 
On boards that are running short of flash space, we should enable CONFIG_LTO.

For example, on chell, savings are significant:
build/chell/RO/ec.RO.flat shrank by 4096 bytes: (106200 to 102104)
build/chell/RW/ec.RW.flat shrank by 4264 bytes: (105988 to 101724)

Of course, for each board where we decide to enable this feature, we should run at least some basic sanity checks on real hardware.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/3fecdbdcf902770036b14b93ca19a5af181c9582

commit 3fecdbdcf902770036b14b93ca19a5af181c9582
Author: Nicolas Boichat <drinkcat@chromium.org>
Date: Fri Jan 05 05:52:05 2018

chell: Enable CONFIG_LTO

Saves about 4K of flash space. Note that LTO has been enabled
on glados for a long time, so hopefully this is safe.

build/chell/RO/ec.RO.flat shrank by 4096 bytes: (106200 to 102104)
build/chell/RW/ec.RW.flat shrank by 4264 bytes: (105988 to 101724)

BRANCH=none
BUG= chromium:798914 
TEST=Flash both chell and chell_pd, system boots to OS, keyboard
     works, charging works.

Change-Id: Id97f2e73959ced16d6579f6c05f3ce4cd21f4062
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/848594
Reviewed-by: Randall Spangler <rspangler@chromium.org>

[modify] https://crrev.com/3fecdbdcf902770036b14b93ca19a5af181c9582/board/chell/board.h

Comment 2 by drinkcat@chromium.org, Jun 1 2018

Status: Fixed (was: Available)
Well, at least it was enabled for chell.

Comment 3 by drinkcat@chromium.org, Jun 1 2018

Owner: drinkcat@chromium.org
►

Sign in to add a comment