New issue
Advanced search Search tips

Issue 798902 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[Remoting Host] SignalingAddress should handle new JID format

Project Member Reported by yuweih@chromium.org, Jan 4 2018

Issue description

For the new LCS JID format, we add a "chromoting_lcs_" prefix to the resource string to identify the connection type as LCS.

Currently we are able to migrate to the new JID format by only changing the client and the server, but we should still fix the logic in SignalingAddress so that it doesn't confuse other people and is future-proof.

See the code here:
https://cs.chromium.org/chromium/src/remoting/signaling/signaling_address.cc?l=56&rcl=7773f9885e09f23775399089e73467803c960451
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a83632457ce535445b2089deafb4f959934fb9ee

commit a83632457ce535445b2089deafb4f959934fb9ee
Author: Yuwei Huang <yuweih@chromium.org>
Date: Thu Feb 01 20:01:54 2018

[Remoting Host] Make SignalingAddress accept new LCS JID format

We have added the `chromoting_lcs_` prefix to resource of an LCS JID. The
current code in SignalingAddress doesn't recognize the new format and
will believe the the new format is of XMPP connection.

This currently doesn't cause any issue after we change the format on
server and client because:
* For reply scenario, the connection type will be determined from the
  `from-channel` field instead of the JID format.
* For outgoing messages, the IQ message format is basically the same for
  LCS and XMPP connections, so IT2ME still magically works even though
  SignalingAddress believes the connection type is XMPP.

This CL cleans up the type inferring logic in SignalingAddress so that
future developers will not misuse it.

Bug:  798902 
Change-Id: I66d5d1af4c7510d2dd2775769689288a9f2333e9
Reviewed-on: https://chromium-review.googlesource.com/889984
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533788}
[modify] https://crrev.com/a83632457ce535445b2089deafb4f959934fb9ee/remoting/signaling/signaling_address.cc
[modify] https://crrev.com/a83632457ce535445b2089deafb4f959934fb9ee/remoting/signaling/signaling_address_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment