Issue 798898 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	wylieb@chromium.org
Closed:	Jan 2018
Cc:	█ robert...@chromium.org chanli@chromium.org lijeffrey@chromium.org liaoyuke@chromium.org st...@chromium.org
Components:	Tools>Test>FindIt>Flakiness
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug

[Findit] Flake Analyzer - Silent error when valid build can't be found

Project Member Reported by wylieb@chromium.org, Jan 4 2018

Issue description

When a valid build isn't found, recursive flake pipeline returns without continuing. An error is set on the analysis, but a pipeline isn't aborted. Actually raise an abort so it shows that the pipeline is aborted.

Project Member

Comment 1 by bugdroid1@chromium.org, Jan 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/cc864c9ec439625f1a9bbbbd4ee21b6429b2544d

commit cc864c9ec439625f1a9bbbbd4ee21b6429b2544d
Author: Brandon Wylie <wylieb@chromium.org>
Date: Thu Jan 04 21:23:13 2018

[Findit] Flake Analyzer - Abort pipeline when a build can't be found

Bug:798898
Change-Id: Ibb028944ef49e0f41d253577c392e1aed085bf35
Reviewed-on: https://chromium-review.googlesource.com/849639
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/cc864c9ec439625f1a9bbbbd4ee21b6429b2544d/appengine/findit/waterfall/build_util.py
[modify] https://crrev.com/cc864c9ec439625f1a9bbbbd4ee21b6429b2544d/appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py
[modify] https://crrev.com/cc864c9ec439625f1a9bbbbd4ee21b6429b2544d/appengine/findit/waterfall/flake/recursive_flake_pipeline.py

Comment 2 by wylieb@chromium.org, Jan 10 2018

Status: Fixed (was: Available)

►

Issue 798898 link

Issue metadata

[Findit] Flake Analyzer - Silent error when valid build can't be found

Issue description

Comment 1 by bugdroid1@chromium.org, Jan 4 2018

Comment 1 Deleted

Comment 2 by wylieb@chromium.org, Jan 10 2018

Comment 2 Deleted

Sign in to add a comment