New issue
Advanced search Search tips

Issue 798893 link

Starred by 1 user
Status: Fixed
Owner:
huayinz@chromium.org
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 687010



Sign in to add a comment

[TabModal] Improve accessibility for tab modal javascript dialogs

Project Member Reported by huayinz@chromium.org, Jan 3 2018 
In accessibility mode, there is no announcement when a tab modal dialog is on show, and the next focus goes to the omnibox. We would want to announce the title of the dialog as the Android dialog, and make the next focus to the dialog view.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d7e365c4a0baa17af1a9ce9587a3eb48e790a85

commit 6d7e365c4a0baa17af1a9ce9587a3eb48e790a85
Author: Becky Zhou <huayinz@chromium.org>
Date: Wed Mar 07 23:29:59 2018

[TabModal] Improve accessibility and keyboard for javascript dialog

+ Fix keyboard not showing when interacting between url bar and prompt
javascript dialog
+ Fix keyboard not being hidden when entering tab switcher
+ Add accessibility description when opening tab modal dialogs

Bug:  798893 , 812443
Change-Id: I162b4dface23c5af142ffc2054aaf489dcc53647
Reviewed-on: https://chromium-review.googlesource.com/897989
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541640}
[modify] https://crrev.com/6d7e365c4a0baa17af1a9ce9587a3eb48e790a85/chrome/android/java/src/org/chromium/chrome/browser/modaldialog/ModalDialogView.java
[modify] https://crrev.com/6d7e365c4a0baa17af1a9ce9587a3eb48e790a85/chrome/android/java/src/org/chromium/chrome/browser/modaldialog/TabModalPresenter.java
[modify] https://crrev.com/6d7e365c4a0baa17af1a9ce9587a3eb48e790a85/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
[modify] https://crrev.com/6d7e365c4a0baa17af1a9ce9587a3eb48e790a85/ui/android/java/src/org/chromium/ui/UiUtils.java

Comment 2 by huayinz@chromium.org, Mar 16 2018

Status: (was: Assigned)

Comment 3 by huayinz@chromium.org, Mar 16 2018

Status: Fixed
►

Sign in to add a comment