[TabModal] Support cancel all dialogs of a certain type and temporarily hide dialogs |
||
Issue descriptionRight now, ModalDialogManager#cancelAllDialogs cancels all the dialogs in the queue, but show and dismissal of app modal dialogs are not supposed to associate with tabs. Ideally, we would want to support cancelling all the dialogs of a certain type. Also, we would want to support temporarily hide the tab modal dialogs and reshow them again if the same tab is selected again in tab switcher. (discussed here: https://bugs.chromium.org/p/chromium/issues/detail?id=687010#c8)
,
Jan 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d2fba820352d2533584c3bc3b4720283280034e commit 0d2fba820352d2533584c3bc3b4720283280034e Author: Becky Zhou <huayinz@chromium.org> Date: Tue Jan 23 01:29:12 2018 [TabModal] Support cancel dialog of certain type and temporarily hide dialogs Bug: 798891 Change-Id: Ie45698ee94468d23b42b00143d66af128de74afa Reviewed-on: https://chromium-review.googlesource.com/874290 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#531112} [modify] https://crrev.com/0d2fba820352d2533584c3bc3b4720283280034e/chrome/android/java/src/org/chromium/chrome/browser/modaldialog/ModalDialogManager.java [modify] https://crrev.com/0d2fba820352d2533584c3bc3b4720283280034e/chrome/android/java/src/org/chromium/chrome/browser/modaldialog/TabModalLifetimeHandler.java [modify] https://crrev.com/0d2fba820352d2533584c3bc3b4720283280034e/chrome/android/javatests/src/org/chromium/chrome/browser/modaldialog/ModalDialogManagerTest.java
,
Jan 30 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by huayinz@chromium.org
, Jan 3 2018