New issue
Advanced search Search tips

Issue 798878 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Swarmbucket returns 500 for non-existent builders

Project Member Reported by iannucci@chromium.org, Jan 3 2018

Issue description

It should probably return 404 instead. This is for the get_task_def API.
 

Comment 1 by no...@chromium.org, Jan 3 2018

Owner: no...@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/82b1a9a33f305eece6c628527779ef1e87620083

commit 82b1a9a33f305eece6c628527779ef1e87620083
Author: Nodir Turakulov <nodir@google.com>
Date: Sat Jan 06 01:15:11 2018

[buildbucket] get_task_def: handle BuilderNotFound

Respond with HTTP 404 on BuilderNotFound exception

R=iannucci@chromium.org

Bug:  798878 
Change-Id: I0fd70c8c465774636723f08cf4f588df96110ef8
Reviewed-on: https://chromium-review.googlesource.com/849496
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/82b1a9a33f305eece6c628527779ef1e87620083/appengine/cr-buildbucket/swarming/test/swarmbucket_api_test.py
[modify] https://crrev.com/82b1a9a33f305eece6c628527779ef1e87620083/appengine/cr-buildbucket/swarming/swarmbucket_api.py

Sign in to add a comment