New issue
Advanced search Search tips

Issue 798873 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Increase the timeout for mandatory PAC scripts?

Project Member Reported by eroman@chromium.org, Jan 3 2018

Issue description

https://chromium-review.googlesource.com/c/chromium/src/+/849116 lowers the timeout for all PAC scripts from 5 minutes to 30 seconds.

It may be reasonable for *mandatory* PAC scripts (this is a configuration mode that extensions can set) to have a higher timeout. Since if fetching the mandatory PAC script fails, the browser cannot initiate any useful networking requests anyway.

On the other hand, 30 seconds is already a high timeout.

In cases where it is stalled thanks to a captive portal, it is more user friendly to fail the request and show an error page after 30 seconds, than to keep spinning for 5 minutes or 10 minutes.
 
Cc: mmenke@chromium.org
@mmenke: WDYT? Having thought about this some more, I am of the opinion we shouldn't special case the mandatory PAC script case, and propose closing this as WontFix. But following-up from the code review where I said I would file a bug!
I'm fine with WontFixing it, just thought I'd offer the suggestion.  Even with a mandatory PAC, 30 seconds is an awfully long time.  If we have no valid mandatory PAC, will we refetch the PAC on every request, if we aren't fetching it already?
Status: WontFix (was: Untriaged)
No, it is not re-fetched on every request.

A failed PAC script will be re-fetched after 8 seconds.

If this also fails, it then does a refetch at 32 seconds, 2 minutes, and then every 4 hours. These latter polls are only done in response to user activity, whereas the 8 second one is done automatically on a timer. [1]

[1] https://cs.chromium.org/chromium/src/net/proxy/proxy_service.cc?q=proxy_service.cc&sq=package:chromium&dr&l=86
So if we fail to fetch a mandatory PAC file 3 times in a row, Chrome is basically dead for 4 hours (Unless restarted)?
Yep.
Issue 799146

Sign in to add a comment