New issue
Advanced search Search tips

Issue 798866 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----

Blocking:
issue angleproject:2264



Sign in to add a comment

angle_perftests failing on chromium.perf/Win 7 Nvidia GPU Perf

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jan 3 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of simonhatch@chromium.org

angle_perftests failing on chromium.perf/Win 7 Nvidia GPU Perf

Builders failed on: 
- Win 7 Nvidia GPU Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Win%207%20Nvidia%20GPU%20Perf


 
Cc: chrome-gpu-perf-owners@chromium.org jmad...@chromium.org
+owners

From logs:

1 test crashed:
    DrawCallPerfBenchmark.Run/vulkan (../../third_party/angle/src/tests/perf_tests/DrawCallPerf.cpp:98)

Blocking: angleproject:2264
Owner: jmad...@chromium.org
Status: Assigned (was: Available)
Thanks for the report. Almost certainly because of https://chromium-review.googlesource.com/c/angle/angle/+/780849. Looking.
Status: Started (was: Assigned)
Fix in CQ: https://chromium-review.googlesource.com/c/angle/angle/+/848539
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/47c8ea3fb265682b6dd040bf04488747f0292da1

commit 47c8ea3fb265682b6dd040bf04488747f0292da1
Author: Jamie Madill <jmadill@chromium.org>
Date: Thu Jan 04 00:27:55 2018

Vulkan: Fix looped clears.

These were broken by command re-ordering. The first problem was that
the Framebuffer RenderNode was not correctly being flagged as dirty.
This is fixed by keeping a serial instead of a bool to track the
RenderNode's cleanliness. The second issue was that an image layout
transition was being set with incorrect bits. Fix this by using the
correct access mask.

This fixes angle_perftests's Vulkan render test.

Bug:  angleproject:2264 
Bug:  chromium:798866 
Change-Id: I268b0f7aeb2c5e22892f6ef59dec62391b30bfb4
Reviewed-on: https://chromium-review.googlesource.com/848539
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/47c8ea3fb265682b6dd040bf04488747f0292da1/src/libANGLE/renderer/vulkan/FramebufferVk.h
[modify] https://crrev.com/47c8ea3fb265682b6dd040bf04488747f0292da1/src/libANGLE/renderer/vulkan/FramebufferVk.cpp

Status: Fixed (was: Started)
Tests seem to be running again. Thanks for the report.

Sign in to add a comment