New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 798861 link

Starred by 1 user
Status: Fixed
Owner:
█ imch...@chromium.org
Last visit > 30 days ago
Closed: Aug 3
Cc:
mfo...@chromium.org
taku...@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[DIAL] Add metrics to track why fetching app info fail on devices

Project Member Reported by zhaobin@chromium.org, Jan 3 2018 
To resolve code review comments in:

https://chromium-review.googlesource.com/c/chromium/src/+/754294/14/chrome/browser/media/router/discovery/dial/dial_app_discovery_service.cc

Mark mentioned "We may want to add some UMA histograms in a followup change tracking parsing errors and HTTP response codes.  However, it might be hard to distinguish the following cases from metrics alone:

Regression in DIAL app info
Weird devices that use DIAL (light bulbs) that we don't care about
Legitimate receivers with broken DIAL implementations

Let's discuss offline before adding any metrics."

Comment 1 by johnpallett@chromium.org, Jan 18 2018

Status: Available (was: Untriaged)

Comment 2 by benhenry@chromium.org, Aug 1

Status: Assigned (was: Available)

Comment 3 by mfo...@chromium.org, Aug 2

Owner: imch...@chromium.org

Comment 4 by imch...@chromium.org, Aug 2

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89e955a5b9e691a5031b351ef151816878eca737

commit 89e955a5b9e691a5031b351ef151816878eca737
Author: Derek Cheng <imcheng@chromium.org>
Date: Fri Aug 03 17:02:01 2018

[DIAL MRP] Add a few key metrics.

MediaRouter.Dial.CreateRoute - records result of a CreateRoute call.
MediaRouter.Dial.TerminateRoute - similarly for a TerminateRoute call.
MediaRouter.Dial.ParseMessage - records result of parsing a message
coming from the Cast SDK.
MediaRouter.Dial.FetchAppInfo - records reuslt of a app info request.
Note we already have metrics for device description.

Bug:  808720 , 798861 
Change-Id: Ic48eba338298e7086fcab290f24ab490e5944ab3
Reviewed-on: https://chromium-review.googlesource.com/1153648
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580575}
[modify] https://crrev.com/89e955a5b9e691a5031b351ef151816878eca737/chrome/browser/media/router/BUILD.gn
[modify] https://crrev.com/89e955a5b9e691a5031b351ef151816878eca737/chrome/browser/media/router/discovery/dial/dial_app_discovery_service.cc
[modify] https://crrev.com/89e955a5b9e691a5031b351ef151816878eca737/chrome/browser/media/router/discovery/dial/dial_app_discovery_service.h
[modify] https://crrev.com/89e955a5b9e691a5031b351ef151816878eca737/chrome/browser/media/router/media_router_metrics.cc
[modify] https://crrev.com/89e955a5b9e691a5031b351ef151816878eca737/chrome/browser/media/router/media_router_metrics.h
[modify] https://crrev.com/89e955a5b9e691a5031b351ef151816878eca737/chrome/browser/media/router/providers/dial/dial_media_route_provider.cc
[add] https://crrev.com/89e955a5b9e691a5031b351ef151816878eca737/chrome/browser/media/router/providers/dial/dial_media_route_provider_metrics.cc
[add] https://crrev.com/89e955a5b9e691a5031b351ef151816878eca737/chrome/browser/media/router/providers/dial/dial_media_route_provider_metrics.h
[modify] https://crrev.com/89e955a5b9e691a5031b351ef151816878eca737/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/89e955a5b9e691a5031b351ef151816878eca737/tools/metrics/histograms/histograms.xml

Comment 6 by imch...@chromium.org, Aug 3

Status: Fixed (was: Started)
►

Sign in to add a comment