Fuchsia: switch to package-based deployments |
||||||||||
Issue descriptionThis is an uber-bug for tracking the various subtasks for construction, deployment, and execution of Chrome as a Fuchsia package. See https://fuchsia.googlesource.com/pm/ for more information on Fuchsia packages.
,
Jan 5 2018
,
Jan 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/660ff99a094be171290b0f1fe4a6a3e450ca55ef commit 660ff99a094be171290b0f1fe4a6a3e450ca55ef Author: Kevin Marshall <kmarshall@chromium.org> Date: Wed Jan 10 01:59:59 2018 Roll Fuchsia SDK to 6b4cb32d100d2ecfaaa9642adfb0de451c5b9a69. - Fixes argv[0] to report package-relative path for "main" binary. - Fixes 'threads' utility not to hang if threads exit mid-dump. - Adds tracing command & service to the SDK, for easier debugging. - Fixes SSH to return valid exit codes from remote commands. - Fixes "run" to correctly route program output via stdout/stderr. - Fixes NET-354 (SSH leaving processes hanging after client disconnects.) Bug: 707030, 799268 , 793412 , 798851 , 778467 Change-Id: Ie3ab3fed54df1884089b57e1638883684de6836f Reviewed-on: https://chromium-review.googlesource.com/857809 Commit-Queue: Wez <wez@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#528206} [modify] https://crrev.com/660ff99a094be171290b0f1fe4a6a3e450ca55ef/DEPS
,
Feb 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f8f9b9dffcb935f4352e4c7fbd68c1ff055edc2 commit 4f8f9b9dffcb935f4352e4c7fbd68c1ff055edc2 Author: Kevin Marshall <kmarshall@chromium.org> Date: Tue Feb 06 02:20:49 2018 Fuchsia: adds non-test executable support for V2 runner scripts. Also redirects program stderr to the stdout stream. Bug: 798851 Change-Id: I317ef1ab53d6b11b4611f36e4445859bea43a4fa Reviewed-on: https://chromium-review.googlesource.com/903259 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#534590} [add] https://crrev.com/4f8f9b9dffcb935f4352e4c7fbd68c1ff055edc2/build/fuchsia/runner_v2/exe_runner.py [modify] https://crrev.com/4f8f9b9dffcb935f4352e4c7fbd68c1ff055edc2/build/fuchsia/runner_v2/run_package.py [modify] https://crrev.com/4f8f9b9dffcb935f4352e4c7fbd68c1ff055edc2/build/fuchsia/runner_v2/symbolizer.py
,
Feb 27 2018
,
Feb 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f0d5ec0ae298a782a347807ba8bde3f93c25aee commit 0f0d5ec0ae298a782a347807ba8bde3f93c25aee Author: Kevin Marshall <kmarshall@chromium.org> Date: Wed Feb 28 02:54:02 2018 Fuchsia: install binaries and dependencies using package/blob system. This solution deploys and runs applications using Fuchsia's package infrastructure. Files are copied into the blobstore as hashed blobs and executed from a signed and packaged manifest file. Also: * Disable Fuchsia layout tests. The Fuchsia deployment script for layout tests needs to be tweaked before it can run with packages. * Add an extra verbose '-vv' switch to cut down on 'scp -v' chatter. * Add a getter to Target to check if the target was freshly booted. Bug: 798851 ,778467 Change-Id: Idf061a3b78844bf63b6c8e0c1a01e99db62f3e20 Reviewed-on: https://chromium-review.googlesource.com/935741 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#539677} [modify] https://crrev.com/0f0d5ec0ae298a782a347807ba8bde3f93c25aee/build/fuchsia/runner_v2/common_args.py [modify] https://crrev.com/0f0d5ec0ae298a782a347807ba8bde3f93c25aee/build/fuchsia/runner_v2/device_target.py [modify] https://crrev.com/0f0d5ec0ae298a782a347807ba8bde3f93c25aee/build/fuchsia/runner_v2/qemu_target.py [modify] https://crrev.com/0f0d5ec0ae298a782a347807ba8bde3f93c25aee/build/fuchsia/runner_v2/remote_cmd.py [modify] https://crrev.com/0f0d5ec0ae298a782a347807ba8bde3f93c25aee/build/fuchsia/runner_v2/run_package.py [modify] https://crrev.com/0f0d5ec0ae298a782a347807ba8bde3f93c25aee/build/fuchsia/runner_v2/target.py [modify] https://crrev.com/0f0d5ec0ae298a782a347807ba8bde3f93c25aee/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/0f0d5ec0ae298a782a347807ba8bde3f93c25aee/testing/buildbot/test_suite_exceptions.pyl [modify] https://crrev.com/0f0d5ec0ae298a782a347807ba8bde3f93c25aee/testing/buildbot/waterfalls.pyl
,
Mar 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d9ede2439cd71245b7c0952d3e45acb69acda746 commit d9ede2439cd71245b7c0952d3e45acb69acda746 Author: Sergey Ulanov <sergeyu@chromium.org> Date: Fri Mar 09 01:10:23 2018 Fuchsia: Fix bugs in incremental packaged deployment 1. Target.IsNewInstance() was returning to true when host name is specified explicitly. This is incorrect because the host is expected to be provisioned and it may be reused for multiple test runs. 2. Updated deployment code to read /blob instead of /blobstore to get list of existing blobs. Bug: 798851 Change-Id: I62b04a352a364250e2aa2d44319494481be011c6 Reviewed-on: https://chromium-review.googlesource.com/956349 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#541975} [modify] https://crrev.com/d9ede2439cd71245b7c0952d3e45acb69acda746/build/fuchsia/runner_v2/device_target.py [modify] https://crrev.com/d9ede2439cd71245b7c0952d3e45acb69acda746/build/fuchsia/runner_v2/run_package.py
,
Mar 15 2018
,
Mar 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/081d9e05f5a0d5bd5156b408862952225bc663b4 commit 081d9e05f5a0d5bd5156b408862952225bc663b4 Author: Kevin Marshall <kmarshall@chromium.org> Date: Mon Mar 19 19:44:49 2018 Fuchsia: Produce signed metadata+blob packages at build time. * Remove FAR to package conversion logic. * Migrate to "pm install" for installing packages on the deployment target. * Plumb the unadorned application name through the various scripting layers, so that it can be run like "run foo_unittests". * Roll SDK to 6e46feb3b26db267c65ea0923426a16f4da835bb. Bug: 707030, 798851 Change-Id: I4c8cc439a8be7a8d158df87200d0db6d67e6c9df Reviewed-on: https://chromium-review.googlesource.com/963763 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#544130} [modify] https://crrev.com/081d9e05f5a0d5bd5156b408862952225bc663b4/build/config/fuchsia/build_manifest.py [modify] https://crrev.com/081d9e05f5a0d5bd5156b408862952225bc663b4/build/config/fuchsia/package.gni [modify] https://crrev.com/081d9e05f5a0d5bd5156b408862952225bc663b4/build/config/fuchsia/rules.gni [modify] https://crrev.com/081d9e05f5a0d5bd5156b408862952225bc663b4/build/fuchsia/runner_common.py [modify] https://crrev.com/081d9e05f5a0d5bd5156b408862952225bc663b4/build/fuchsia/runner_v2/common_args.py [modify] https://crrev.com/081d9e05f5a0d5bd5156b408862952225bc663b4/build/fuchsia/runner_v2/create_runner_script.py [modify] https://crrev.com/081d9e05f5a0d5bd5156b408862952225bc663b4/build/fuchsia/runner_v2/exe_runner.py [modify] https://crrev.com/081d9e05f5a0d5bd5156b408862952225bc663b4/build/fuchsia/runner_v2/qemu_target.py [modify] https://crrev.com/081d9e05f5a0d5bd5156b408862952225bc663b4/build/fuchsia/runner_v2/run_package.py [modify] https://crrev.com/081d9e05f5a0d5bd5156b408862952225bc663b4/build/fuchsia/runner_v2/test_runner.py [modify] https://crrev.com/081d9e05f5a0d5bd5156b408862952225bc663b4/build/fuchsia/update_sdk.py
,
Mar 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4c33049f096cd283f32be9a58b9a9e768227c26 commit b4c33049f096cd283f32be9a58b9a9e768227c26 Author: Kevin Marshall <kmarshall@chromium.org> Date: Tue Mar 20 01:18:34 2018 Fuchsia: enable packaged runs on more test suites. Enable packaged runs for: * base_unittests * crypto_unittests * ipc_tests * media_unittests * mojo_unittests Bug: 798851 Change-Id: Iab5a5decc6a85b00c89b975735ea961bdb94a6fe Reviewed-on: https://chromium-review.googlesource.com/969300 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#544248} [modify] https://crrev.com/b4c33049f096cd283f32be9a58b9a9e768227c26/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/b4c33049f096cd283f32be9a58b9a9e768227c26/testing/buildbot/test_suite_exceptions.pyl
,
Mar 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c3c830f69a3cdf7a548aeb0db7840b771d46865 commit 4c3c830f69a3cdf7a548aeb0db7840b771d46865 Author: Kevin Marshall <kmarshall@chromium.org> Date: Tue Mar 20 16:58:54 2018 Revert "Fuchsia: enable packaged runs on more test suites." This reverts commit b4c33049f096cd283f32be9a58b9a9e768227c26. Reason for revert: Fix for Fuchsia disk image sizes not landed yet. Original change's description: > Fuchsia: enable packaged runs on more test suites. > > Enable packaged runs for: > * base_unittests > * crypto_unittests > * ipc_tests > * media_unittests > * mojo_unittests > > Bug: 798851 > Change-Id: Iab5a5decc6a85b00c89b975735ea961bdb94a6fe > Reviewed-on: https://chromium-review.googlesource.com/969300 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#544248} TBR=dpranke@chromium.org,kmarshall@chromium.org,sergeyu@chromium.org Change-Id: I96091ad66025c337a90a1692ebebedb3e56ce103 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 798851 Reviewed-on: https://chromium-review.googlesource.com/971241 Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#544410} [modify] https://crrev.com/4c3c830f69a3cdf7a548aeb0db7840b771d46865/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/4c3c830f69a3cdf7a548aeb0db7840b771d46865/testing/buildbot/test_suite_exceptions.pyl
,
Mar 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c3816582f5879f8cac7e825d95abc1fbf491d88b commit c3816582f5879f8cac7e825d95abc1fbf491d88b Author: Kevin Marshall <kmarshall@chromium.org> Date: Wed Mar 21 20:56:31 2018 Reland "Fuchsia: enable packaged runs on more test suites." This is a reland of b4c33049f096cd283f32be9a58b9a9e768227c26 Original change's description: > Fuchsia: enable packaged runs on more test suites. > > Enable packaged runs for: > * base_unittests > * crypto_unittests > * ipc_tests > * media_unittests > * mojo_unittests > > Bug: 798851 > Change-Id: Iab5a5decc6a85b00c89b975735ea961bdb94a6fe > Reviewed-on: https://chromium-review.googlesource.com/969300 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#544248} TBR=dpranke@chromium.org Bug: 798851 Change-Id: Ic703fdb1c77e6aae3020d8ac8f74cbbea8703cf6 Reviewed-on: https://chromium-review.googlesource.com/972322 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#544835} [modify] https://crrev.com/c3816582f5879f8cac7e825d95abc1fbf491d88b/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/c3816582f5879f8cac7e825d95abc1fbf491d88b/testing/buildbot/test_suite_exceptions.pyl
,
Mar 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/abedd9cd0c0a17f82f3477d0d4025dfec9cc700e commit abedd9cd0c0a17f82f3477d0d4025dfec9cc700e Author: Kevin Marshall <kmarshall@chromium.org> Date: Thu Mar 22 22:53:01 2018 Fuchsia: fix ui_base_unittests for package runs. Adds a platform-specific logic to look for UI resources in the package root instead of constructing a path relative to the executable. (Executables are promoted to a special bin/ directory on Fuchsia.) Fix the symbolizer by reverting a regression in 081d9e05 that removed the manifest path from the runner script plumbing. Add ui_base_unittests to chromium.fyi Fuchsia. Bug: 798851 Change-Id: I1c2e2aec9c9ab5f3944836ba0f7949d9e950ded3 Reviewed-on: https://chromium-review.googlesource.com/969755 Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#545277} [modify] https://crrev.com/abedd9cd0c0a17f82f3477d0d4025dfec9cc700e/build/config/fuchsia/rules.gni [modify] https://crrev.com/abedd9cd0c0a17f82f3477d0d4025dfec9cc700e/build/fuchsia/runner_v2/common_args.py [modify] https://crrev.com/abedd9cd0c0a17f82f3477d0d4025dfec9cc700e/build/fuchsia/runner_v2/exe_runner.py [modify] https://crrev.com/abedd9cd0c0a17f82f3477d0d4025dfec9cc700e/build/fuchsia/runner_v2/run_package.py [modify] https://crrev.com/abedd9cd0c0a17f82f3477d0d4025dfec9cc700e/build/fuchsia/runner_v2/test_runner.py [modify] https://crrev.com/abedd9cd0c0a17f82f3477d0d4025dfec9cc700e/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/abedd9cd0c0a17f82f3477d0d4025dfec9cc700e/testing/buildbot/test_suite_exceptions.pyl [modify] https://crrev.com/abedd9cd0c0a17f82f3477d0d4025dfec9cc700e/tools/fuchsia/local-sdk.py [modify] https://crrev.com/abedd9cd0c0a17f82f3477d0d4025dfec9cc700e/ui/base/test/run_all_unittests.cc
,
Mar 26 2018
,
Mar 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a82986a1b3d82174e8e12e8150a4e1e292bd709 commit 2a82986a1b3d82174e8e12e8150a4e1e292bd709 Author: Kevin Marshall <kmarshall@chromium.org> Date: Tue Mar 27 22:24:55 2018 Fuchsia: use DIR_ASSETS when generating executable paths of svcs. Add additional logging to launch_fuchsia.cc to help call attention to bad computed executable paths in the future. Add service_manager_unittests to Fuchsia FYI. Bug: 798851 Change-Id: I0b6ef3c12097ed562973f81e34d5cc7089dd4bde Reviewed-on: https://chromium-review.googlesource.com/973919 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#546291} [modify] https://crrev.com/2a82986a1b3d82174e8e12e8150a4e1e292bd709/base/process/launch_fuchsia.cc [modify] https://crrev.com/2a82986a1b3d82174e8e12e8150a4e1e292bd709/services/catalog/entry.cc [modify] https://crrev.com/2a82986a1b3d82174e8e12e8150a4e1e292bd709/services/service_manager/tests/service_manager/service_manager_unittest.cc [modify] https://crrev.com/2a82986a1b3d82174e8e12e8150a4e1e292bd709/services/service_manager/tests/util.cc [modify] https://crrev.com/2a82986a1b3d82174e8e12e8150a4e1e292bd709/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/2a82986a1b3d82174e8e12e8150a4e1e292bd709/testing/buildbot/test_suite_exceptions.pyl
,
Apr 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a112566cae8f0bbf4fc96d78d0b3d96c1a0dc5a commit 2a112566cae8f0bbf4fc96d78d0b3d96c1a0dc5a Author: Kevin Marshall <kmarshall@chromium.org> Date: Mon Apr 02 23:50:31 2018 Fuchsia: extend the size of the blobstore FVM at build time. This CL grows Fuchsia blobstore by a specified amount, large enough to accommodate packaged executables installed at machine (QEMU) runtime. Roll SDK from 32a56ad5 to de50ae25 for "fvm extend" and the inclusion of fvm.blk. Bug: 798851 , 707030 Change-Id: I5a6b6be21cc443e6ad46271918a2f40e191a26f6 Reviewed-on: https://chromium-review.googlesource.com/987012 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#547568} [modify] https://crrev.com/2a112566cae8f0bbf4fc96d78d0b3d96c1a0dc5a/build/config/fuchsia/BUILD.gn [add] https://crrev.com/2a112566cae8f0bbf4fc96d78d0b3d96c1a0dc5a/build/config/fuchsia/extend_fvm.py [modify] https://crrev.com/2a112566cae8f0bbf4fc96d78d0b3d96c1a0dc5a/build/config/fuchsia/rules.gni [modify] https://crrev.com/2a112566cae8f0bbf4fc96d78d0b3d96c1a0dc5a/build/fuchsia/runner_v2/qemu_target.py [modify] https://crrev.com/2a112566cae8f0bbf4fc96d78d0b3d96c1a0dc5a/build/fuchsia/sdk.sha1
,
Apr 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/195beedfda5d3271d053eddfeea929e399229a03 commit 195beedfda5d3271d053eddfeea929e399229a03 Author: Wez <wez@chromium.org> Date: Tue Apr 03 03:47:05 2018 Revert "Fuchsia: extend the size of the blobstore FVM at build time." This reverts commit 2a112566cae8f0bbf4fc96d78d0b3d96c1a0dc5a. Reason for revert: Unfortunately the SDK this CL rolled us to is subtley but badly broken. The CL fell narrowly short of Breaking All The Things, because some of the Things just don't touch the broken bits. :( Original change's description: > Fuchsia: extend the size of the blobstore FVM at build time. > > This CL grows Fuchsia blobstore by a specified amount, large enough to > accommodate packaged executables installed at machine (QEMU) runtime. > > Roll SDK from 32a56ad5 to de50ae25 for "fvm extend" and the inclusion > of fvm.blk. > > Bug: 798851 , 707030 > Change-Id: I5a6b6be21cc443e6ad46271918a2f40e191a26f6 > Reviewed-on: https://chromium-review.googlesource.com/987012 > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#547568} TBR=wez@chromium.org,kmarshall@chromium.org Bug: 828232 , 828229 , 798851 , 707030 Change-Id: I3ac0d1586c1a70700fbbd88d9f5762728bedc868 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/991672 Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#547618} [modify] https://crrev.com/195beedfda5d3271d053eddfeea929e399229a03/build/config/fuchsia/BUILD.gn [delete] https://crrev.com/eb800e136bad107db6edd0976283d13e68377fdc/build/config/fuchsia/extend_fvm.py [modify] https://crrev.com/195beedfda5d3271d053eddfeea929e399229a03/build/config/fuchsia/rules.gni [modify] https://crrev.com/195beedfda5d3271d053eddfeea929e399229a03/build/fuchsia/runner_v2/qemu_target.py [modify] https://crrev.com/195beedfda5d3271d053eddfeea929e399229a03/build/fuchsia/sdk.sha1
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/febd80e463c099d074133e649d972bc5d49bc54d commit febd80e463c099d074133e649d972bc5d49bc54d Author: Kevin Marshall <kmarshall@chromium.org> Date: Wed Apr 04 20:49:21 2018 Reland "Fuchsia: extend the size of the blobstore FVM at build time." This is a reland of 2a112566cae8f0bbf4fc96d78d0b3d96c1a0dc5a , using a newer SDK build which addresses the symbol visibility issues that were causing the "new" operator to break. TBR=wez@chromium.org Original change's description: > Fuchsia: extend the size of the blobstore FVM at build time. > > This CL grows Fuchsia blobstore by a specified amount, large enough to > accommodate packaged executables installed at machine (QEMU) runtime. > > Roll SDK from 32a56ad5 to de50ae25 for "fvm extend" and the inclusion > of fvm.blk. > > Bug: 798851 , 707030 > Change-Id: I5a6b6be21cc443e6ad46271918a2f40e191a26f6 > Reviewed-on: https://chromium-review.googlesource.com/987012 > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#547568} Bug: 798851 , 707030 Change-Id: I62de331c46b38ed7adb460bf9f5e8335e3f54a02 Reviewed-on: https://chromium-review.googlesource.com/996273 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#548187} [modify] https://crrev.com/febd80e463c099d074133e649d972bc5d49bc54d/build/config/fuchsia/BUILD.gn [add] https://crrev.com/febd80e463c099d074133e649d972bc5d49bc54d/build/config/fuchsia/extend_fvm.py [modify] https://crrev.com/febd80e463c099d074133e649d972bc5d49bc54d/build/config/fuchsia/rules.gni [modify] https://crrev.com/febd80e463c099d074133e649d972bc5d49bc54d/build/fuchsia/runner_v2/qemu_target.py [modify] https://crrev.com/febd80e463c099d074133e649d972bc5d49bc54d/build/fuchsia/sdk.sha1
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/765c66b1691b1f853659b76847fdd1a3906fb783 commit 765c66b1691b1f853659b76847fdd1a3906fb783 Author: Wez <wez@chromium.org> Date: Thu Apr 19 17:08:11 2018 Use DIR_ASSETS as pak load path in TestContentClient. This helper class was using DIR_MODULE, which was returning an empty path, causing 'content_shell.pak' to be loaded from the current working directory. In some builds (e.g. Fuchsia packaged) this is the wrong location, which is why DIR_ASSETS is provided for this purpose. Related to this, CHECKs are added to the PathService::Get(), and to the DataPack load stages, to verify that tests aren't incidentally passing (this was the case under Fuchsia non-packaged builds). Bug: 798851 Change-Id: Ie307e05d9466f7384a5c9d5dda86cfed399b4d6d Reviewed-on: https://chromium-review.googlesource.com/1018108 Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#552057} [modify] https://crrev.com/765c66b1691b1f853659b76847fdd1a3906fb783/content/test/test_content_client.cc
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d199a9fc4b550cd30046e5736f9cfc18bae1944 commit 5d199a9fc4b550cd30046e5736f9cfc18bae1944 Author: Wez <wez@chromium.org> Date: Thu Apr 19 18:47:45 2018 Create a temporary copy of test database in DOMStorageDatabaseTest. DOMStorageDatabaseTest.TestCanOpenAndReadWebCoreDatabase uses a prepared test database, and verifies that it can be opened and read. The test opens the file directly from DIR_TEST_DATA, and so fails if that is readonly. Create a copy of the test database to open, to allow for this. Bug: 798851 Change-Id: I8d99e927c82024be7b0d98cdb4959a6210fe98a8 Reviewed-on: https://chromium-review.googlesource.com/1018491 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#552100} [modify] https://crrev.com/5d199a9fc4b550cd30046e5736f9cfc18bae1944/content/browser/dom_storage/dom_storage_database.h [modify] https://crrev.com/5d199a9fc4b550cd30046e5736f9cfc18bae1944/content/browser/dom_storage/dom_storage_database_unittest.cc
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55e9532b45401cb1b0ee66783b69bed19e79b3c4 commit 55e9532b45401cb1b0ee66783b69bed19e79b3c4 Author: Kevin Marshall <kmarshall@chromium.org> Date: Thu Apr 19 21:14:08 2018 Fuchsia: Use SSH multiplexing for forwarded test server connections. SSH multiplexing makes SSH-based forwarding much more performant and reliable versus using separately negotiated connection. Connection overhead for runner_v2 SSH operations is also reduced. * Fix deployment path used to push the test server configuration to the target device. * Documentation fixes. Bug: 798851 Change-Id: I4d97204b0e3420e0ae8ce0ca8bcf6ca137dce46f Reviewed-on: https://chromium-review.googlesource.com/1018364 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#552157} [modify] https://crrev.com/55e9532b45401cb1b0ee66783b69bed19e79b3c4/build/config/fuchsia/BUILD.gn [modify] https://crrev.com/55e9532b45401cb1b0ee66783b69bed19e79b3c4/build/fuchsia/runner_v2/boot_data.py [modify] https://crrev.com/55e9532b45401cb1b0ee66783b69bed19e79b3c4/build/fuchsia/runner_v2/net_test_server.py [modify] https://crrev.com/55e9532b45401cb1b0ee66783b69bed19e79b3c4/build/fuchsia/runner_v2/test_runner.py [modify] https://crrev.com/55e9532b45401cb1b0ee66783b69bed19e79b3c4/net/test/spawned_test_server/remote_test_server_config.cc
,
Apr 24 2018
Blocked on the inclusion of some .sos in the SDK (DX-135).
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/43531956535482f54a27900530f0729f195aa98a commit 43531956535482f54a27900530f0729f195aa98a Author: Kevin Marshall <kmarshall@chromium.org> Date: Thu Apr 26 21:48:54 2018 Fuchsia: Increase partition size limits for /data and blobstore. The current partition size limits are too small to accomodate very large packages such as debug builds of "content_unittests" (600MB). This CL adjusts the limits and deployment workflow to better handle large files. * Increase blobstore extend amount from 512MB to 1GB. * Copy target for install packages changed to /data (was /tmp , which is smaller and in-memory). * Increase /data partition size from 10MB to 1GB, large enough to hold packages. * Eagerly delete the /data partition file after qcow2 images are created, to reduce the space footprint on the test host. * Add cleanup step for install packages. * Move qcow2 creation logic to boot_data.py. * Clarified some logging statements. Bug: 798851 Change-Id: Ia98dd5f483ccca8802f68a865d3a85ed061dfbd8 Reviewed-on: https://chromium-review.googlesource.com/1030951 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#554155} [modify] https://crrev.com/43531956535482f54a27900530f0729f195aa98a/build/config/fuchsia/BUILD.gn [modify] https://crrev.com/43531956535482f54a27900530f0729f195aa98a/build/fuchsia/runner_v2/boot_data.py [modify] https://crrev.com/43531956535482f54a27900530f0729f195aa98a/build/fuchsia/runner_v2/device_target.py [modify] https://crrev.com/43531956535482f54a27900530f0729f195aa98a/build/fuchsia/runner_v2/qemu_target.py [modify] https://crrev.com/43531956535482f54a27900530f0729f195aa98a/build/fuchsia/runner_v2/run_package.py
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/42e1d41d34ec3689647e10c4ce6f2d3d10027b61 commit 42e1d41d34ec3689647e10c4ce6f2d3d10027b61 Author: Kevin Marshall <kmarshall@chromium.org> Date: Thu Apr 26 22:19:56 2018 Use new packaged runner for all Fuchsia test runs. Bug: 798851 Change-Id: I42429952cc7f2cc0be001fbe4930a4f6cadf3d13 Reviewed-on: https://chromium-review.googlesource.com/1025049 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#554169} [modify] https://crrev.com/42e1d41d34ec3689647e10c4ce6f2d3d10027b61/build/fuchsia/create_runner_script.py
,
Apr 27 2018
,
Apr 27 2018
,
Apr 27 2018
,
Apr 27 2018
,
May 4 2018
,
May 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75b2f822f6df3b663c1653e2c7eede1e7abb2269 commit 75b2f822f6df3b663c1653e2c7eede1e7abb2269 Author: Wez <wez@chromium.org> Date: Tue May 08 18:27:29 2018 Make a single 'readelf' invocation for each iteration of lib-deps. We gather the library dependencies of the executable, to include them in the manifest, by running 'readelf' on it, then iterating over each library in turn to add its dependencies, and so-on. 'readelf' can accept multiple filenames on the command-line, so rather then invoking it once per-file, run it on a batch of all the not-yet- processed dependencies, at each iteration. Bug: 798851 , 796779 Change-Id: If1ff5be592bfea120b93d16b09eb53c651d6c50f Reviewed-on: https://chromium-review.googlesource.com/1049174 Commit-Queue: Wez <wez@chromium.org> Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#556884} [modify] https://crrev.com/75b2f822f6df3b663c1653e2c7eede1e7abb2269/build/config/fuchsia/build_manifest.py
,
Sep 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c826ea1e53dbdaeb9c9c399c6c123087901b853 commit 4c826ea1e53dbdaeb9c9c399c6c123087901b853 Author: Kevin Marshall <kmarshall@chromium.org> Date: Thu Sep 06 20:44:05 2018 [fuchsia] Use original executable filename instead of /pkg/bin/app. The Fuchsia component manifest now allows us to specify arbitrary binaries in a package as an entry point. Before, the entry point executable had to reside at the special path /pkg/bin/app. Keeping the executable name intact will facilitate stack trace symbolization on multiple packages. Bug: 798851 Change-Id: Ib116602e2e0e430478d24829112df63c27f3d025 Reviewed-on: https://chromium-review.googlesource.com/1208716 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#589283} [modify] https://crrev.com/4c826ea1e53dbdaeb9c9c399c6c123087901b853/build/config/fuchsia/build_manifest.py
,
Sep 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eeeaae5da37b46987963460e4bb58828018efbe2 commit eeeaae5da37b46987963460e4bb58828018efbe2 Author: Kevin Marshall <kmarshall@chromium.org> Date: Fri Sep 14 23:34:19 2018 [fuchsia] Fix data directory path handling. Allows PathService's APP_DATA path to be dynamically overriden, for handling incognito, persistent, and browsertest cases. Remove GetPackageRoot() and replace it with PathService getter calls. Add hooks to allow browser test suites to override how APP_DATA is configured. BUG= 798851 Change-Id: I465d5801f3237d37e84011ae2f83b7efa6258c18 Reviewed-on: https://chromium-review.googlesource.com/1227406 Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#591524} [modify] https://crrev.com/eeeaae5da37b46987963460e4bb58828018efbe2/base/base_paths_fuchsia.cc [modify] https://crrev.com/eeeaae5da37b46987963460e4bb58828018efbe2/base/base_paths_fuchsia.h [modify] https://crrev.com/eeeaae5da37b46987963460e4bb58828018efbe2/base/native_library_fuchsia.cc [modify] https://crrev.com/eeeaae5da37b46987963460e4bb58828018efbe2/content/common/sandbox_policy_fuchsia.cc [modify] https://crrev.com/eeeaae5da37b46987963460e4bb58828018efbe2/webrunner/browser/context_impl_browsertest.cc [modify] https://crrev.com/eeeaae5da37b46987963460e4bb58828018efbe2/webrunner/browser/webrunner_browser_context.cc [modify] https://crrev.com/eeeaae5da37b46987963460e4bb58828018efbe2/webrunner/browser/webrunner_browser_context.h [modify] https://crrev.com/eeeaae5da37b46987963460e4bb58828018efbe2/webrunner/browser/webrunner_browser_main_parts.cc [modify] https://crrev.com/eeeaae5da37b46987963460e4bb58828018efbe2/webrunner/browser/webrunner_browser_test.cc [modify] https://crrev.com/eeeaae5da37b46987963460e4bb58828018efbe2/webrunner/browser/webrunner_browser_test.h [modify] https://crrev.com/eeeaae5da37b46987963460e4bb58828018efbe2/webrunner/service/common.cc [modify] https://crrev.com/eeeaae5da37b46987963460e4bb58828018efbe2/webrunner/service/common.h [modify] https://crrev.com/eeeaae5da37b46987963460e4bb58828018efbe2/webrunner/service/context_provider_impl_unittest.cc [modify] https://crrev.com/eeeaae5da37b46987963460e4bb58828018efbe2/webrunner/service/web_content_service_main.cc
,
Sep 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9933054916bc67841ea2611c0f6441cb6a28507e commit 9933054916bc67841ea2611c0f6441cb6a28507e Author: Kevin Marshall <kmarshall@chromium.org> Date: Sat Sep 15 18:04:53 2018 Revert "[fuchsia] Fix data directory path handling." This reverts commit eeeaae5da37b46987963460e4bb58828018efbe2. Reason for revert: Broke a FYI bot, plus I had a hallway discussion about using /web_context_data. Looks like we should change the Contxt to just use /data instead. Original change's description: > [fuchsia] Fix data directory path handling. > > Allows PathService's APP_DATA path to be dynamically overriden, > for handling incognito, persistent, and browsertest cases. > > Remove GetPackageRoot() and replace it with PathService getter calls. > > Add hooks to allow browser test suites to override how APP_DATA is > configured. > > BUG= 798851 > > Change-Id: I465d5801f3237d37e84011ae2f83b7efa6258c18 > Reviewed-on: https://chromium-review.googlesource.com/1227406 > Reviewed-by: Scott Graham <scottmg@chromium.org> > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#591524} TBR=kmarshall@chromium.org,scottmg@chromium.org Change-Id: Ic4895868d612d9236e5c166b5aabe97af32a31d8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 798851 Reviewed-on: https://chromium-review.googlesource.com/1227674 Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#591588} [modify] https://crrev.com/9933054916bc67841ea2611c0f6441cb6a28507e/base/base_paths_fuchsia.cc [modify] https://crrev.com/9933054916bc67841ea2611c0f6441cb6a28507e/base/base_paths_fuchsia.h [modify] https://crrev.com/9933054916bc67841ea2611c0f6441cb6a28507e/base/native_library_fuchsia.cc [modify] https://crrev.com/9933054916bc67841ea2611c0f6441cb6a28507e/content/common/sandbox_policy_fuchsia.cc [modify] https://crrev.com/9933054916bc67841ea2611c0f6441cb6a28507e/webrunner/browser/context_impl_browsertest.cc [modify] https://crrev.com/9933054916bc67841ea2611c0f6441cb6a28507e/webrunner/browser/webrunner_browser_context.cc [modify] https://crrev.com/9933054916bc67841ea2611c0f6441cb6a28507e/webrunner/browser/webrunner_browser_context.h [modify] https://crrev.com/9933054916bc67841ea2611c0f6441cb6a28507e/webrunner/browser/webrunner_browser_main_parts.cc [modify] https://crrev.com/9933054916bc67841ea2611c0f6441cb6a28507e/webrunner/browser/webrunner_browser_test.cc [modify] https://crrev.com/9933054916bc67841ea2611c0f6441cb6a28507e/webrunner/browser/webrunner_browser_test.h [modify] https://crrev.com/9933054916bc67841ea2611c0f6441cb6a28507e/webrunner/service/common.cc [modify] https://crrev.com/9933054916bc67841ea2611c0f6441cb6a28507e/webrunner/service/common.h [modify] https://crrev.com/9933054916bc67841ea2611c0f6441cb6a28507e/webrunner/service/context_provider_impl_unittest.cc [modify] https://crrev.com/9933054916bc67841ea2611c0f6441cb6a28507e/webrunner/service/web_content_service_main.cc |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by kmarshall@chromium.org
, Jan 3 2018