New issue
Advanced search Search tips

Issue 798847 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Bug



Sign in to add a comment

Enable shared library loading for package builds on Fuchsia.

Project Member Reported by kmarshall@chromium.org, Jan 3 2018

Issue description

NativeLibrary, and code that uses it, is broken until Fuchsia supports executing dynamic libraries within packages. Here is the bug for that effort:

https://fuchsia.atlassian.net/browse/US-390
 
Need shared library impls in the SDK, see Fuchsia bug TO-918
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/858c03f25d74d1416b0df659b424491f1263bca6

commit 858c03f25d74d1416b0df659b424491f1263bca6
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Thu Apr 12 19:24:06 2018

Fuchsia: Add a Fuchsia-specific NativeLibrary impl library.

native_library_fuchsia uses the Fuchsia-specific dlopen_vmo() function
instead of dlopen() as on other POSIX builds.

The library is package-aware, resolving full library paths differently
if the process is running inside a packaged namespace.

Bug:  798847 
Change-Id: I1f4e0769e8b94bff65704df4dcfd73c622df13bc
Reviewed-on: https://chromium-review.googlesource.com/1003060
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550302}
[modify] https://crrev.com/858c03f25d74d1416b0df659b424491f1263bca6/base/BUILD.gn
[add] https://crrev.com/858c03f25d74d1416b0df659b424491f1263bca6/base/native_library_fuchsia.cc
[modify] https://crrev.com/858c03f25d74d1416b0df659b424491f1263bca6/base/native_library_unittest.cc
[modify] https://crrev.com/858c03f25d74d1416b0df659b424491f1263bca6/testing/buildbot/filters/fuchsia.base_unittests.filter

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/858c03f25d74d1416b0df659b424491f1263bca6

commit 858c03f25d74d1416b0df659b424491f1263bca6
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Thu Apr 12 19:24:06 2018

Fuchsia: Add a Fuchsia-specific NativeLibrary impl library.

native_library_fuchsia uses the Fuchsia-specific dlopen_vmo() function
instead of dlopen() as on other POSIX builds.

The library is package-aware, resolving full library paths differently
if the process is running inside a packaged namespace.

Bug:  798847 
Change-Id: I1f4e0769e8b94bff65704df4dcfd73c622df13bc
Reviewed-on: https://chromium-review.googlesource.com/1003060
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550302}
[modify] https://crrev.com/858c03f25d74d1416b0df659b424491f1263bca6/base/BUILD.gn
[add] https://crrev.com/858c03f25d74d1416b0df659b424491f1263bca6/base/native_library_fuchsia.cc
[modify] https://crrev.com/858c03f25d74d1416b0df659b424491f1263bca6/base/native_library_unittest.cc
[modify] https://crrev.com/858c03f25d74d1416b0df659b424491f1263bca6/testing/buildbot/filters/fuchsia.base_unittests.filter

Sign in to add a comment