^^^
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f5e7e14b60b9c7735e0fdc208f5bb99b358619e commit 8f5e7e14b60b9c7735e0fdc208f5bb99b358619e Author: Anthony Vallee-Dubois <anthonyvd@chromium.org> Date: Fri Jan 12 16:14:06 2018 [Web Payments] Embed Payment Handler window in PR dialog Bug: 798846 Change-Id: If0f333f458204b85351ab6c531f296c02f469ad4 Reviewed-on: https://chromium-review.googlesource.com/848649 Reviewed-by: Ganggui Tang <gogerald@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#528958} [modify] https://crrev.com/8f5e7e14b60b9c7735e0fdc208f5bb99b358619e/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/8f5e7e14b60b9c7735e0fdc208f5bb99b358619e/chrome/browser/chrome_content_browser_client.h [modify] https://crrev.com/8f5e7e14b60b9c7735e0fdc208f5bb99b358619e/chrome/browser/payments/chrome_payment_request_delegate.cc [modify] https://crrev.com/8f5e7e14b60b9c7735e0fdc208f5bb99b358619e/chrome/browser/payments/chrome_payment_request_delegate.h [modify] https://crrev.com/8f5e7e14b60b9c7735e0fdc208f5bb99b358619e/chrome/browser/ui/BUILD.gn [add] https://crrev.com/8f5e7e14b60b9c7735e0fdc208f5bb99b358619e/chrome/browser/ui/views/payments/payment_handler_web_flow_view_controller.cc [add] https://crrev.com/8f5e7e14b60b9c7735e0fdc208f5bb99b358619e/chrome/browser/ui/views/payments/payment_handler_web_flow_view_controller.h [modify] https://crrev.com/8f5e7e14b60b9c7735e0fdc208f5bb99b358619e/chrome/browser/ui/views/payments/payment_request_dialog_view.cc [modify] https://crrev.com/8f5e7e14b60b9c7735e0fdc208f5bb99b358619e/chrome/browser/ui/views/payments/payment_request_dialog_view.h [modify] https://crrev.com/8f5e7e14b60b9c7735e0fdc208f5bb99b358619e/components/payments/content/content_payment_request_delegate.h [modify] https://crrev.com/8f5e7e14b60b9c7735e0fdc208f5bb99b358619e/components/payments/content/payment_request.cc [modify] https://crrev.com/8f5e7e14b60b9c7735e0fdc208f5bb99b358619e/components/payments/content/payment_request_dialog.h [modify] https://crrev.com/8f5e7e14b60b9c7735e0fdc208f5bb99b358619e/components/payments/content/payment_request_display_manager.cc [modify] https://crrev.com/8f5e7e14b60b9c7735e0fdc208f5bb99b358619e/components/payments/content/payment_request_display_manager.h [modify] https://crrev.com/8f5e7e14b60b9c7735e0fdc208f5bb99b358619e/components/payments/content/test_content_payment_request_delegate.cc [modify] https://crrev.com/8f5e7e14b60b9c7735e0fdc208f5bb99b358619e/components/payments/content/test_content_payment_request_delegate.h [modify] https://crrev.com/8f5e7e14b60b9c7735e0fdc208f5bb99b358619e/content/browser/service_worker/service_worker_version.cc [modify] https://crrev.com/8f5e7e14b60b9c7735e0fdc208f5bb99b358619e/content/browser/service_worker/service_worker_version.h [modify] https://crrev.com/8f5e7e14b60b9c7735e0fdc208f5bb99b358619e/content/common/service_worker/service_worker_messages.h [modify] https://crrev.com/8f5e7e14b60b9c7735e0fdc208f5bb99b358619e/content/public/browser/content_browser_client.cc [modify] https://crrev.com/8f5e7e14b60b9c7735e0fdc208f5bb99b358619e/content/public/browser/content_browser_client.h [modify] https://crrev.com/8f5e7e14b60b9c7735e0fdc208f5bb99b358619e/content/renderer/service_worker/service_worker_context_client.cc [modify] https://crrev.com/8f5e7e14b60b9c7735e0fdc208f5bb99b358619e/content/renderer/service_worker/service_worker_context_client.h [modify] https://crrev.com/8f5e7e14b60b9c7735e0fdc208f5bb99b358619e/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.cpp [modify] https://crrev.com/8f5e7e14b60b9c7735e0fdc208f5bb99b358619e/third_party/WebKit/Source/modules/serviceworkers/WebEmbeddedWorkerImplTest.cpp [modify] https://crrev.com/8f5e7e14b60b9c7735e0fdc208f5bb99b358619e/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09fa46568fb35c8502204bae244b335c84307613 commit 09fa46568fb35c8502204bae244b335c84307613 Author: Anthony Vallee-Dubois <anthonyvd@chromium.org> Date: Tue Jan 16 18:34:03 2018 [Web Payments] Run Payment Handler openWindow callback after navigation. This fixes Payment Handlers on desktop where the success of the operation was previously dependent on how long it took for the Payment Handler to load. If it took too long, the Service Worker would get the "window opened" signal but fail to see any window to talk to and most often just failed. Bug: 798846 Change-Id: I4e9541891b9297966c6ff8518021186929b0c31a Reviewed-on: https://chromium-review.googlesource.com/867232 Reviewed-by: Mathieu Perreault <mathp@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#529465} [modify] https://crrev.com/09fa46568fb35c8502204bae244b335c84307613/chrome/browser/payments/chrome_payment_request_delegate.cc [modify] https://crrev.com/09fa46568fb35c8502204bae244b335c84307613/chrome/browser/payments/chrome_payment_request_delegate.h [modify] https://crrev.com/09fa46568fb35c8502204bae244b335c84307613/chrome/browser/ui/views/payments/payment_handler_web_flow_view_controller.cc [modify] https://crrev.com/09fa46568fb35c8502204bae244b335c84307613/chrome/browser/ui/views/payments/payment_handler_web_flow_view_controller.h [modify] https://crrev.com/09fa46568fb35c8502204bae244b335c84307613/chrome/browser/ui/views/payments/payment_request_dialog_view.cc [modify] https://crrev.com/09fa46568fb35c8502204bae244b335c84307613/chrome/browser/ui/views/payments/payment_request_dialog_view.h [modify] https://crrev.com/09fa46568fb35c8502204bae244b335c84307613/components/payments/content/content_payment_request_delegate.h [modify] https://crrev.com/09fa46568fb35c8502204bae244b335c84307613/components/payments/content/payment_request_dialog.h [modify] https://crrev.com/09fa46568fb35c8502204bae244b335c84307613/components/payments/content/payment_request_display_manager.cc [modify] https://crrev.com/09fa46568fb35c8502204bae244b335c84307613/components/payments/content/payment_request_display_manager.h [modify] https://crrev.com/09fa46568fb35c8502204bae244b335c84307613/components/payments/content/test_content_payment_request_delegate.cc [modify] https://crrev.com/09fa46568fb35c8502204bae244b335c84307613/components/payments/content/test_content_payment_request_delegate.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dcc1c88738d0becd13926181e8d547c5e890e76f commit dcc1c88738d0becd13926181e8d547c5e890e76f Author: Anthony Vallee-Dubois <anthonyvd@chromium.org> Date: Tue Jan 23 19:34:36 2018 [Web Payments] Desktop Payment Handler layout fixes. This CL removes the footer in the Payment Handler sheet, extends the web contents to the bottom of the dialog, and displays the current origin and page title in the header. Bug: 798846 Change-Id: I4093868bab4c132bfb2c1fe41a3c3592408fd4e5 Reviewed-on: https://chromium-review.googlesource.com/876516 Commit-Queue: anthonyvd <anthonyvd@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#531302} [modify] https://crrev.com/dcc1c88738d0becd13926181e8d547c5e890e76f/chrome/browser/ui/views/payments/payment_handler_web_flow_view_controller.cc [modify] https://crrev.com/dcc1c88738d0becd13926181e8d547c5e890e76f/chrome/browser/ui/views/payments/payment_handler_web_flow_view_controller.h [modify] https://crrev.com/dcc1c88738d0becd13926181e8d547c5e890e76f/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc [modify] https://crrev.com/dcc1c88738d0becd13926181e8d547c5e890e76f/chrome/browser/ui/views/payments/payment_request_sheet_controller.h [modify] https://crrev.com/dcc1c88738d0becd13926181e8d547c5e890e76f/chrome/browser/ui/views/payments/payment_request_views_util.cc [modify] https://crrev.com/dcc1c88738d0becd13926181e8d547c5e890e76f/chrome/browser/ui/views/payments/payment_request_views_util.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/951eb910bf8be64e1bcf1b5777c8fe210f7a9a5d commit 951eb910bf8be64e1bcf1b5777c8fe210f7a9a5d Author: Anthony Vallee-Dubois <anthonyvd@chromium.org> Date: Thu Feb 15 18:08:46 2018 [Web Payments] Implement CCT style header on desktop Payment Handlers This patch sets the Payment Handler sheet's header's background color to the Payment Handler's theme color, similar to the behavior of Chrome Custom Tabs on Clank. It also chooses a foreground color using the same algorithm as CCT's. Bug: 798846 Change-Id: I91d40744e1d8990c270bb0752c9bf141477d88f2 Reviewed-on: https://chromium-review.googlesource.com/921930 Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#537070} [modify] https://crrev.com/951eb910bf8be64e1bcf1b5777c8fe210f7a9a5d/chrome/browser/ui/views/payments/payment_handler_web_flow_view_controller.cc [modify] https://crrev.com/951eb910bf8be64e1bcf1b5777c8fe210f7a9a5d/chrome/browser/ui/views/payments/payment_handler_web_flow_view_controller.h [modify] https://crrev.com/951eb910bf8be64e1bcf1b5777c8fe210f7a9a5d/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc [modify] https://crrev.com/951eb910bf8be64e1bcf1b5777c8fe210f7a9a5d/chrome/browser/ui/views/payments/payment_request_sheet_controller.h [modify] https://crrev.com/951eb910bf8be64e1bcf1b5777c8fe210f7a9a5d/chrome/browser/ui/views/payments/payment_request_views_util.cc [modify] https://crrev.com/951eb910bf8be64e1bcf1b5777c8fe210f7a9a5d/chrome/browser/ui/views/payments/payment_request_views_util.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b52b415dadf5f689085eac64a155d155c744d82d commit b52b415dadf5f689085eac64a155d155c744d82d Author: Anthony Vallee-Dubois <anthonyvd@chromium.org> Date: Mon Feb 26 16:35:36 2018 [Web Payments] Add button to open Payment Handler's site settings Bug: 798846 Change-Id: Iccf6c1a213898c24aed35d941512036782e61f0b Reviewed-on: https://chromium-review.googlesource.com/937393 Commit-Queue: anthonyvd <anthonyvd@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#539154} [modify] https://crrev.com/b52b415dadf5f689085eac64a155d155c744d82d/chrome/browser/ui/views/payments/payment_handler_web_flow_view_controller.cc [modify] https://crrev.com/b52b415dadf5f689085eac64a155d155c744d82d/chrome/browser/ui/views/payments/payment_handler_web_flow_view_controller.h
Comment 1 by bugdroid1@chromium.org
, Jan 12 2018