New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 798841 link

Starred by 14 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Unable to play ARC games with touch.

Project Member Reported by abod...@chromium.org, Jan 3 2018

Issue description

Google Chrome	64.0.3282.65 (Official Build) beta (64-bit)
Platform	10176.34.0 (Official Build) beta-channel reef-unibuild (reef pyro snappy sand electro basking alan bigdaddy)

Please specify Cr-* of the system to which this bug/feature applies (add
the label below).

Steps To Reproduce:
(1)Try to play angry birds, clash of clans and subway surf game with touch 


Expected Result:

Actual Result:

Unable to play any game with touch. Focus moved to another window.
Reprod on cyan, reef and Caroline devices.

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)
Always

What is the impact to the user, and is there a workaround? If so, what is
it?

Please provide any additional information below. Attach a screen shot or
log if possible.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.


 
debug-logs_20180103-134904
1.8 MB View Download
Can we identify where this bug originated?  Regression from where?
Per #1, we're already in Beta so if this is already out there this would be a stable blocker.
Ivan is going to check with Ansar re: the potential regression / impact.  May be a genuine beta blocker if on multiple games / devices and new to this beta candidate.
Re c#1: This is a regression from previous M64 beta 10176.22.0, 64.0.3282.41.

Issue reproduced on multiple games/ devices
I am able to fling angry birds with 10176.22.0 (current beta) on a Kevin. 
Cc: fouchal@google.com
Can we bisect to see which version broke touch input?
Labels: -Pri-2 Pri-1
Cc: dchan@chromium.org

Comment 9 by dchan@chromium.org, Jan 3 2018

Cc: kbleicher@chromium.org
+kevin, any idea who should own this bug ?
Per Bernie fouchal@ will likely establish triage / ownership
attached video file.
20180103_133903.mp4
9.4 MB View Download
Reproducible all the time on eve, very bad bug. Looking into it.
short update:
- 10176.34.0 from goldeneye has this bug.
- today {chrome, cros, arc++} ToT does not have this bug.
- 12 december {chrome, cros, arc++} ToT does not have this bug.

very few commits have been pushed during this period on ARC++ N so this is quite strange.
misspoken, today ToT is has the same bug.
This bug is not present in 10176.23.0 but is present on 10176.30.0, this give us a 5 days window. That also means that the changes causing this issue have been cherry-picked into M64.

The only large changes that happened during this period are: b/67384524, ndk translation dogfooding, oshima caption.

regression from b/67384524 is the most likely candidate.

Will look further tomorrow.
Logcat output each time clash of clan/angry bird applications are move to the back:

/system/bin/surfaceflinger:D:wayland-service: OnConfigure 0x0000019a -- origin offset (0, 0)
/system/bin/surfaceflinger:D:wayland-service: OnConfigure 0x0000019b -- origin offset (0, 0)
/system/bin/surfaceflinger:D:wayland-service: Wayland Remote Shell Workspace id=0 pos=0,0 size=2400x1600 insets=0,0,0,96 transform=WL_OUTPUT_TRANSFORM_NORMAL scale=2.000000 is_internal=1
/system/bin/surfaceflinger:D:wayland-service: Wayland Remote Shell Configure primary_id=0 size=2400x1600 mm=254x169 layout=ZCR_REMOTE_SHELL_V1_LAYOUT_MODE_WINDOWED metrics_changed=1
/system/bin/surfaceflinger:E:wayland-service: Sending display metrics
com.android.vending:D:ViewRootImpl[MainActivity]: Window focused:IntentSender{3444369: android.os.BinderProxy@cd0e1ee}
system_server:W:WindowPositioner: WindowPositioner.applyPendingWorkspaceConfig WorkspaceConfig{0:Workspace{Rect(0, 0 - 2400, 1600), insets=Insets{left=0, top=0, right=0, bottom=96}}, primaryDisplayId=0, layoutMode=windowed}
system_server:I:TaskWindowPlacerArc: onWorkspaceChanged. displayId: 0
system_server:I:TaskWindowPlacerArc: onWorkspaceInsetsChanged. displayId: 0 insets: Insets{left=0, top=0, right=0, bottom=96}
system_server:V:WindowPositioner: getFinalOrientationForWindowedMode: take workspace orientation=SCREEN_ORIENTATION_LANDSCAPE
system_server:V:WindowPositioner: getFinalOrientationForWindowedMode: take workspace orientation=SCREEN_ORIENTATION_LANDSCAPE
system_server:V:TaskWindowPlacerArc: applyWorkspaceConfig - done resizing & moving windows
org.chromium.arc.applauncher:D:ArcAppTaskTracker: Calculating task stack diff.
org.chromium.arc.applauncher:D:ArcAppTaskTracker: Active task: 4.
system_server:E:TaskPersister: File error accessing recents directory (directory doesn't exist?).

nothing clear but zcr_remote_shell_v1 wayland protocol have been modified in b/67384524
Cc: domlasko...@chromium.org
b/67384524 was also merged into M62 per #18 but as a workaround rather than the work of the bug itself.  +domlaskowski for additional eyes (since blocking).
Owner: domlasko...@chromium.org
Status: Assigned (was: Untriaged)
Yeah, b/67384524 (but not the M62/M63 workaround) made non-trivial changes to input dispatch. HWC now sets per-surface input regions (clipped to surface bounds in Exo) rather than a single cumulative input region for the root surface. Exo picks the target surface for input events based on the surface hierarchy and input regions, rather than always dispatching to the root surface. For mouse events, Exo sends positions in surface-local coordinates rather than display coordinates, and HWC converts them before forwarding to InputFlinger. There's a special case [1] for touch events, which might explain this regression if mouse input is not affected.

I won't be able to do on-device debugging until Monday. Hugo, could you please post the input regions reported by "dumpsys Wayland"?

[1] https://chromium.googlesource.com/chromium/src/+/3e2f94794c509dd78ed30c8582d575c9c97d69a5

Comment 19 Deleted

dominik see the log below:

Thanks for your help.
I will continue on my side to investigate this issue today to see if others changes could be responsible of this regression.

=======================================================================
Wayland service state dump on 10176.26.0 (which contains this bug)


WaylandLayerManager

  Layers
    Layer 0x78d3add58200 Z:   21005 visible: 1 hidden: 0 alpha: 1.0 gralloc buffer: 0x78d3addcf400 color buffer: 0x0 transform: 0 display frame scale: 1.00 display frame offset: 0 0 display:     0     0  2400  1600 crop:  0.00  0.00  2400.00  1600.00 input: 1 resizable outset: 0 root: 1 shadow: 0 window id: 0x07d6ac14 window type: 0x00000100 task_id: 4 window frame:     0     0  2400  1600 window frame scale: 1.00 window frame offset: 0 0 scaled window frame:     0     0  2400  1600 stylus tool: 0 
    Layer 0x78d3add58480 Z:  311000 visible: 1 hidden: 0 alpha: 1.0 gralloc buffer: 0x78d3add5bf00 color buffer: 0x0 transform: 0 display frame scale: 0.50 display frame offset: 0 0 display:  1085   967  1135  1017 crop:  0.00  0.00  50.00  50.00 input: 1 resizable outset: 0 root: 0 shadow: 0 window id: 0x00000000 window type: 0x00000000 window frame:     0     0    -1    -1 window frame scale: 1.00 window frame offset: 0 0 scaled window frame:     0     0    -1    -1 stylus tool: 0 
    Layer 0x78d3add58340 Z:   21009 visible: 1 hidden: 0 alpha: 1.0 gralloc buffer: 0x0 color buffer: 0x78d3add70c70 transform: 0 display frame scale: 1.00 display frame offset: 0 0 display:     0     0  2400  1600 crop:  0.00  0.00  1.00  1.00 input: 1 resizable outset: 0 root: 0 shadow: 0 window id: 0x072c17b0 window type: 0x00000100 task_id: 5 window frame:     0     0    -1    -1 window frame scale: 1.00 window frame offset: 0 0 scaled window frame:     0     0    -1    -1 stylus tool: 0 
    Layer 0x78d3add58700 Z:   21010 visible: 1 hidden: 0 alpha: 1.0 gralloc buffer: 0x78d3addcf980 color buffer: 0x0 transform: 0 display frame scale: 1.00 display frame offset: 0 0 display:     0     0  2400  1600 crop:  0.00  0.00  2400.00  1600.00 input: 0 resizable outset: 0 root: 0 shadow: 0 window id: 0x08cb8ef3 window type: 0x00000100 task_id: 5 window frame:     0     0  2400  1600 window frame scale: 1.00 window frame offset: 0 0 scaled window frame:     0     0  2400  1600 stylus tool: 0 
    Layer 0x78d3add585c0 Z:  240999 visible: 0 hidden: 1 alpha: 0.0 gralloc buffer: 0x0 color buffer: 0x78d3add6fb40 transform: 0 display frame scale: 1.00 display frame offset: 0 0 display:  -600  -400  3000  2000 crop:  0.00  0.00  1.00  1.00 input: 1 resizable outset: 0 root: 0 shadow: 0 window id: 0x077267de window type: 0x00000100 task_id: 1 window frame:     0     0    -1    -1 window frame scale: 1.00 window frame offset: 0 0 scaled window frame:     0     0    -1    -1 stylus tool: 0 
    Layer 0x78d3add2f000 Z:   21015 visible: 0 hidden: 0 alpha: 1.0 gralloc buffer: 0x78d3addcf200 color buffer: 0x0 transform: 0 display frame scale: 1.00 display frame offset: 0 0 display:     0     0     0     0 crop:  0.00  0.00  0.00  0.00 input: 1 resizable outset: 0 root: 1 shadow: 0 window id: 0x0ae50457 window type: 0x00000100 task_id: 5 window frame:     0     0  2400  1600 window frame scale: 1.00 window frame offset: 0 0 scaled window frame:     0     0  2400  1600 stylus tool: 0 

  Cursor Layer: 0x78d3add58480 hotspot 7 7

  Ignored Tasks
    1 
  System Container
    Container 0x78d3ae68af80
      wl_surface: 0x78d3afc3abb0 viewport: 1080 x 223 geometry:     0     0    -1    -1 shadow opacity: 0.0 stylus tool: 0 UI scale: 2.00
      0 layers: [ ]
      0 visible layers: [ ]

  Task Containers
    Task Container 0x78d3add0da40 (task 5 "com.supercell.clashofclans")
      wl_surface: 0x78d3add71300 viewport: 2400 x 1600 geometry:     0     0  2400  1600 shadow opacity: 1.0 stylus tool: 0 UI scale: 2.00
      3 layers: [ 0x78d3add2f000 0x78d3add58700 0x78d3add58340 ]
      2 visible layers: [ 0x78d3add58340 0x78d3add58700 ]
    Task Container 0x78d3afc81240 (task 4 "com.android.vending")
      wl_surface: 0x78d3add6f320 viewport: 2400 x 1600 geometry:     0     0  2400  1600 shadow opacity: 1.0 stylus tool: 0 UI scale: 2.00
      1 layers: [ 0x78d3add58200 ]
      1 visible layers: [ 0x78d3add58200 ]

=======================================================================
Wayland service state dump on 10176.23.0 (which does not contains this bug)


WaylandLayerManager

  Layers
    Layer 0x7b8eeef5e200 Z:   21019 visible: 0 hidden: 1 alpha: 0.0 gralloc buffer: 0x0 color buffer: 0x7b8eeef77210 transform: 0 display frame scale: 1.00 display frame offset: 0 0 display:     0     0  2400  1600 crop:  0.00  0.00  1.00  1.00 input: 1 resizable outset: 0 root: 0 shadow: 0 window id: 0x00c9f332 window type: 0x00000100 task_id: 6 window frame:     0     0    -1    -1 window frame scale: 1.00 window frame offset: 0 0 scaled window frame:     0     0    -1    -1 stylus tool: 0 
    Layer 0x7b8eeef5df80 Z:   21015 visible: 0 hidden: 0 alpha: 1.0 gralloc buffer: 0x7b8eeef2f400 color buffer: 0x0 transform: 0 display frame scale: 1.00 display frame offset: 0 0 display:     0     0     0     0 crop:  0.00  0.00  0.00  0.00 input: 1 resizable outset: 0 root: 1 shadow: 0 window id: 0x0b885bd7 window type: 0x00000100 task_id: 6 window frame:     0     0  2400  1600 window frame scale: 1.00 window frame offset: 0 0 scaled window frame:     0     0  2400  1600 stylus tool: 0 
    Layer 0x7b8eeef5de40 Z:   21009 visible: 1 hidden: 0 alpha: 1.0 gralloc buffer: 0x0 color buffer: 0x7b8eeef77260 transform: 0 display frame scale: 1.00 display frame offset: 0 0 display:     0     0  2400  1600 crop:  0.00  0.00  1.00  1.00 input: 1 resizable outset: 0 root: 0 shadow: 0 window id: 0x0dee6e57 window type: 0x00000100 task_id: 6 window frame:     0     0    -1    -1 window frame scale: 1.00 window frame offset: 0 0 scaled window frame:     0     0    -1    -1 stylus tool: 0 
    Layer 0x7b8eeef36000 Z:   21005 visible: 1 hidden: 0 alpha: 1.0 gralloc buffer: 0x7b8ef083d100 color buffer: 0x0 transform: 0 display frame scale: 1.00 display frame offset: 0 0 display:     0     0  2400  1600 crop:  0.00  0.00  2400.00  1600.00 input: 1 resizable outset: 0 root: 1 shadow: 0 window id: 0x03d631a7 window type: 0x00000100 task_id: 15 window frame:     0     0  2400  1600 window frame scale: 1.00 window frame offset: 0 0 scaled window frame:     0     0  2400  1600 stylus tool: 0 
    Layer 0x7b8eeef5e480 Z:  311000 visible: 0 hidden: 1 alpha: 0.0 gralloc buffer: 0x7b8eeef2f800 color buffer: 0x0 transform: 0 display frame scale: 0.50 display frame offset: 0 0 display:  1773   609  1823   659 crop:  0.00  0.00  50.00  50.00 input: 1 resizable outset: 0 root: 0 shadow: 0 window id: 0x00000000 window type: 0x00000000 window frame:     0     0    -1    -1 window frame scale: 1.00 window frame offset: 0 0 scaled window frame:     0     0    -1    -1 stylus tool: 0 
    Layer 0x7b8eeef5dd00 Z:   21010 visible: 1 hidden: 0 alpha: 1.0 gralloc buffer: 0x7b8ef083f500 color buffer: 0x0 transform: 0 display frame scale: 1.00 display frame offset: 0 0 display:     0     0  2400  1600 crop:  0.00  0.00  2400.00  1600.00 input: 0 resizable outset: 0 root: 0 shadow: 0 window id: 0x090cde73 window type: 0x00000100 task_id: 6 window frame:     0     0  2400  1600 window frame scale: 1.00 window frame offset: 0 0 scaled window frame:     0     0  2400  1600 stylus tool: 0 
    Layer 0x7b8eeef5e5c0 Z:  240999 visible: 0 hidden: 1 alpha: 0.0 gralloc buffer: 0x0 color buffer: 0x7b8eeef758c0 transform: 0 display frame scale: 1.00 display frame offset: 0 0 display:  -600  -400  3000  2000 crop:  0.00  0.00  1.00  1.00 input: 1 resizable outset: 0 root: 0 shadow: 0 window id: 0x012c3d9e window type: 0x00000100 task_id: 6 window frame:     0     0    -1    -1 window frame scale: 1.00 window frame offset: 0 0 scaled window frame:     0     0    -1    -1 stylus tool: 0 

  Cursor Layer: 0x7b8eeef5e480 hotspot 0 0

  Ignored Tasks
    1 
  System Container
    Container 0x7b8eef88af80
      wl_surface: 0x7b8ef0c3abb0 viewport: 2400 x 1600 geometry:     0     0    -1    -1 shadow opacity: 0.0 stylus tool: 0 UI scale: 2.00
      input region (rect):     0     0     0     0
      0 layers: [ ]
      0 visible layers: [ ]

  Task Containers
    Task Container 0x7b8eeef1edc0 (task 15 "com.android.vending")
      wl_surface: 0x7b8eeef76a90 viewport: 2400 x 1600 geometry:     0     0  2400  1600 shadow opacity: 1.0 stylus tool: 0 UI scale: 2.00
      input region (rect):     0     0  2400  1600
      1 layers: [ 0x7b8eeef36000 ]
      1 visible layers: [ 0x7b8eeef36000 ]
    Task Container 0x7b8eeef1fae0 (task 6 "com.supercell.clashofclans")
      wl_surface: 0x7b8eeef77710 viewport: 2400 x 1600 geometry:     0     0  2400  1600 shadow opacity: 1.0 stylus tool: 0 UI scale: 2.00
      input region (rect):     0     0  2400  1600
      5 layers: [ 0x7b8eeef5e200 0x7b8eeef5dd00 0x7b8eeef5de40 0x7b8eeef5df80 0x7b8eeef5e5c0 ]
      2 visible layers: [ 0x7b8eeef5de40 0x7b8eeef5dd00 ]
Other informations:
- this bug happens for mouse, touchpad, touch MotionEvent but not for touchpad or mouse ScrollEvent.
- when scrolling with the touchpad we inject MotionEvent at low level in android and these injected MotionEvent works perfectly normally and does not induce this bug which could indicate that this issue is external to android/ARC++ and come from chrome. 

Also i tried without success to reproduce this bug with my own testing  applications. So this bug may happens only when native applications have complex surface hierarchy like Clash of clan...
regression happens exactly between 10176.24.0 and 10176.25.0.


This is the list of ARC++ changes between these two versions: https://android-build.googleplex.com/builds/4516580/branches/git_nyc-mr1-arc-m64/targets/cheets_arm-user/cls?end=4515450
About touchpad scrolling, even when i disable ag/2084297 the touchpad scrolling still not induce this bug. So likely the system_server (WindowManager, ActivityManager) is not responsible of this bug. And also likely the problem come from chrome/wayland_service.

dominik, reverting ag/3374414 fix this bug.

I was surprised that ag/3374414 have no dependency with chrome-side stuff and can be reverted without much issue. Still, ag/3374414 need to be reverted in both vendor/google_arc, device/google/cheets2 as some reformatting happened here recently, see ag/3405433.

Also i tried yesterday  to revert [1] and it does not works.

Let you decide what to do next, i'm available if you need any help.

[1] https://chromium.googlesource.com/chromium/src/+/3e2f94794c509dd78ed30c8582d575c9c97d69a5
Labels: -Pri-1 Pri-0
We have a critical need to get 64 back into shippable shape so upping priority here.

I put up a revert for ag/3374414 and the other CL that was associated with it by topic in frameworks/base. 

https://googleplex-android-review.git.corp.google.com/#/c/device/google/cheets2/+/3424641/
https://googleplex-android-review.git.corp.google.com/#/c/platform/frameworks/base/+/3424674/

If we believe these will fix the issue (even if it means external displays have problems again), we should land these ASAP. 

If there is not a better solution posted in the next 24 hours I will speculatively land these.
Not a developer, but this happens on anything using OpenGL. Try this app for OpenGL demos that reproduce this bug.
http://play.google.com/store/apps/details?id=de.unimarburg.gpapp
I am having this bug on chromeos 65.0.3299.0 as well, on my Pixelbook (dev channel). Seems odd for the same problem to appear in both the dev and beta channels. 
nachiket@vartak.org, not on anything that use Opengl: this sample OpenGl app https://github.com/googlesamples/android-ndk/tree/master/native-activity  does not reproduce this bug.

platypusdiamond@gmail.com, the commit that we think induce this bug has been pushed into master branch (M65, dev channel) and then has been cherry-picked into M64 release branch (beta channel).
 Issue 797585  has been merged into this issue.
Labels: -Pri-0 -M-64 M-65 Pri-1
Punting to 65 as we reverted the changes in 64.

Comment 33 by fouchal@google.com, Jan 11 2018

Issue 797504 has been merged into this issue.
I'm experiencing this issue with Netflix and Play Newsstand. Is it the same problem?
I do not experience this bug with Netflix or Play Newsstand, so most likely it is not the same thing.
Any new on when this is going to be fixed ? It's really cramping the style of several of our Chromebooks, making most Android games unplayable.
Status: Fixed (was: Assigned)
The fix has landed in M64 and M65, so this should be resolved in the next update.
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-65; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-65 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD
Status: Verified (was: Fixed)
10575.58.0, 67.0.3396.99 stable-channel eve

Sign in to add a comment