New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 798839 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 757607



Sign in to add a comment

Move texture target exception list handling to GPU context capabilities.

Project Member Reported by vmi...@chromium.org, Jan 3 2018

Issue description

Currently GLES2 platform specific texture target exception lists are passed from Browser to Renderers, via content flags.

Refactoring these lists to GPU context capabilities will reduce some code, and allow this GLES2 specific concept to be abstracted away behind the RasterInterface.
 
Description: Show this description

Comment 2 by piman@chromium.org, Jan 3 2018

Cc: reve...@chromium.org
Components: -Internals>GPU Internals>GPU>Internals
Description: Show this description

Comment 4 by piman@chromium.org, Jan 4 2018

Cc: hoegsberg@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b

commit cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b
Author: Victor Miura <vmiura@chromium.org>
Date: Fri Jan 05 04:30:17 2018

Move texture target exception list handling to GPU context capabilities.

This change moves the GLES2 texture target exception lists tracking out of
content / viz / cc, to GPU context capabilities.  The exception list is now
passed from Browser to GPU process via gpu::Preferences, then passed to GPU
clients via gpu::Capabilities.

BUG= 798839 , 757607 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ia09c248290ba58538b49b8895f7b627f3f92ff8d
Reviewed-on: https://chromium-review.googlesource.com/849491
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Victor Miura <vmiura@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527205}
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/cc/ipc/BUILD.gn
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/cc/ipc/cc_param_traits_macros.h
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/cc/layers/picture_layer_impl_unittest.cc
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/cc/raster/one_copy_raster_buffer_provider.cc
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/cc/resources/resource_provider.cc
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/cc/resources/resource_provider.h
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/cc/resources/resource_provider_unittest.cc
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/cc/test/fake_resource_provider.h
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/cc/test/layer_tree_test.cc
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/components/viz/common/BUILD.gn
[delete] https://crrev.com/33bd85d9705a40b4da795d400837134f6a81aff1/components/viz/common/resources/buffer_to_texture_target_map.cc
[delete] https://crrev.com/33bd85d9705a40b4da795d400837134f6a81aff1/components/viz/common/resources/buffer_to_texture_target_map.h
[delete] https://crrev.com/33bd85d9705a40b4da795d400837134f6a81aff1/components/viz/common/resources/buffer_to_texture_target_map_unittest.cc
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/components/viz/common/resources/resource_settings.h
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/components/viz/host/renderer_settings_creation.cc
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/components/viz/host/renderer_settings_creation.h
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/components/viz/service/display/gl_renderer.cc
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/components/viz/service/display/scoped_gpu_memory_buffer_texture.cc
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/components/viz/service/display/scoped_gpu_memory_buffer_texture.h
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/content/browser/compositor/viz_process_transport_factory.cc
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/content/browser/gpu/compositor_util.cc
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/content/browser/gpu/compositor_util.h
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/content/browser/gpu/gpu_data_manager_impl_private.cc
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/content/public/common/content_switches.cc
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/content/public/common/content_switches.h
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/content/renderer/gpu/compositor_dependencies.h
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/content/renderer/media/gpu/gpu_video_accelerator_factories_impl.cc
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/content/renderer/media/gpu/gpu_video_accelerator_factories_impl.h
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/content/renderer/pepper/pepper_graphics_2d_host.cc
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/content/renderer/pepper/pepper_graphics_2d_host.h
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/content/renderer/render_thread_impl.h
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/content/renderer/render_thread_impl_browsertest.cc
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/content/test/fake_compositor_dependencies.cc
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/content/test/fake_compositor_dependencies.h
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/gpu/command_buffer/common/capabilities.cc
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/gpu/command_buffer/common/capabilities.h
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/gpu/command_buffer/common/gpu_memory_buffer_support.cc
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/gpu/command_buffer/common/gpu_memory_buffer_support.h
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/gpu/command_buffer/service/gpu_preferences.h
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/gpu/command_buffer/service/raster_decoder.cc
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/gpu/ipc/client/BUILD.gn
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/gpu/ipc/common/BUILD.gn
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/gpu/ipc/common/gpu_command_buffer_traits_multi.h
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/gpu/ipc/common/gpu_preferences.mojom
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/gpu/ipc/common/gpu_preferences_struct_traits.h
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/media/video/gpu_video_accelerator_factories.h
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/services/ui/ws/server_window.cc
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/services/viz/privileged/interfaces/struct_traits_unittest.cc
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/services/viz/public/cpp/compositing/resource_settings_struct_traits.cc
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/services/viz/public/cpp/compositing/resource_settings_struct_traits.h
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/services/viz/public/cpp/compositing/struct_traits_unittest.cc
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/services/viz/public/interfaces/compositing/resource_settings.mojom
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/ui/aura/mus/mus_context_factory.cc
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/ui/gfx/buffer_types.h
[add] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/ui/gfx/ipc/buffer_types/BUILD.gn
[add] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/ui/gfx/ipc/buffer_types/OWNERS
[add] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/ui/gfx/ipc/buffer_types/gfx_ipc_export.h
[add] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/ui/gfx/ipc/buffer_types/gfx_param_traits.cc
[add] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/ui/gfx/ipc/buffer_types/gfx_param_traits.h
[add] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/ui/gfx/ipc/buffer_types/gfx_param_traits_macros.h
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/ui/gfx/ipc/gfx_param_traits_macros.h
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/ui/gfx/mojo/buffer_types.mojom
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/ui/gfx/mojo/buffer_types.typemap
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/ui/gfx/mojo/buffer_types_struct_traits.cc
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/ui/gfx/mojo/buffer_types_struct_traits.h
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/ui/ozone/BUILD.gn
[modify] https://crrev.com/cabdfac4b8e2ac3283efe34ec4f802c0164cdc6b/ui/ozone/common/gpu/ozone_gpu_messages.h

Status: Fixed (was: Started)

Sign in to add a comment