New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 798833 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
OOO until Feb 4th
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 793007



Sign in to add a comment

Remove tools-lint and just use lint in tools/

Project Member Reported by wnwen@chromium.org, Jan 3 2018

Issue description

We now regularly update the SDK. We shouldn't be separating out lint since it has created many problems before when we have version mismatch.

Looking to fail the build when we have "Unexpected failure during Lint" like  issue 793007 . This is a step towards removing sources of discrepancy.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60990c11cee109af3dbe79fa2423362ed706dbcd

commit 60990c11cee109af3dbe79fa2423362ed706dbcd
Author: Peter Wen <wnwen@chromium.org>
Date: Mon Jan 15 15:46:08 2018

Android: Prepare to remove tools-lint

Use tools/bin/lint instead of tools-lint/bin/lint as it is updated.
Effectively this moves lint from 25.3.2 to 26.0.0.

BUG= 798833 , 799070 
TBR=torne@chromium.org,mdjones@chromium.org,jrummell@chromium.org,alexmos@chromium.org,lambroslambrou@chromium.org,nyquist@chromium.org

Change-Id: Ic3e67694d8b19d2a0e7d33a9594e9dc3d9db0223
Reviewed-on: https://chromium-review.googlesource.com/857694
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529287}
[modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java
[modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java
[modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/build/android/lint/suppressions.xml
[modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/build/config/android/internal_rules.gni
[modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/chrome/android/java/AndroidManifest.xml
[modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/chrome/android/java/src/org/chromium/chrome/browser/SSLClientCertificateRequest.java
[modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateTabLayout.java
[modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/chrome/android/java/src/org/chromium/chrome/browser/ssl/CaptivePortalHelper.java
[modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/chrome/android/java/src/org/chromium/chrome/browser/survey/ChromeHomeSurveyController.java
[modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/chrome/android/javatests/src/org/chromium/chrome/browser/crash/LogcatExtractionRunnableTest.java
[modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java
[modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
[modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkVerifySignature.java
[modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/chrome/android/webapk/shell_apk/shell_apk_version.gni
[modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/WebApkSandboxedProcessService.java
[modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/chrome/test/android/javatests/src/org/chromium/chrome/test/util/ApplicationTestUtils.java
[modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/components/background_task_scheduler/android/java/src/org/chromium/components/background_task_scheduler/BackgroundTaskJobService.java
[modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncherHelper.java
[modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/content/public/android/java/src/org/chromium/content/browser/ContentView.java
[modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
[modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/content/shell/android/java/src/org/chromium/content_shell/Shell.java
[modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java
[modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/media/base/android/java/src/org/chromium/media/MediaPlayerBridge.java
[modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/remoting/android/java/src/org/chromium/chromoting/HostListAdapter.java

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/android_tools/+/c9f9bbf0a6c862fbef6115e80e8617093cd58e6b

commit c9f9bbf0a6c862fbef6115e80e8617093cd58e6b
Author: Peter Wen <wnwen@chromium.org>
Date: Mon Jan 15 16:19:00 2018

Remove tools-lint subdirectory

Just use tools/bin/lint instead.

BUG= 798833 

Change-Id: I278d5eb919304f1fe7769c0e973041df80400d60
Reviewed-on: https://chromium-review.googlesource.com/861404
Reviewed-by: John Budorick <jbudorick@chromium.org>

[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/org-eclipse-equinox-common-3.6.0.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/manifest-merger-25.3.2.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/jython-standalone-2.5.3.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/dvlib-25.3.2.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/annotations-25.3.2.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/jsilver-1.0.0.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/android.el
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/annotations-12.0.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/osgi-4.0.0.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/lint-api-25.3.2.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/asm-5.0.4.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/bcprov-jdk15on-1.48.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/commons-compress-1.8.1.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/commons-codec-1.4.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/commons-logging-1.1.1.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/repository-25.3.2.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/lint-checks-25.3.2.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/jfreechart-swt-1.0.9.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/common-25.3.2.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/uast-162.2228.14.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/builder-model-2.3.2.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/bin/lint
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/jobb-25.3.2.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/org-eclipse-core-commands-3.6.0.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/jfreechart-1.0.9.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/chimpchat-25.3.2.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/screenshot2-25.3.2.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/httpclient-4.1.1.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/archquery-25.3.2.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/jimfs-1.1.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/traceview-25.3.2.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/asm-tree-5.0.4.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/sdklib-25.3.2.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/hierarchyviewer2lib-25.3.2.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/x86_64/swt.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/asm-analysis-5.0.4.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/fat32lib.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/lombok-ast-0.2.3.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/gson-2.2.4.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/uiautomatorviewer-25.3.2.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/ddmlib-25.3.2.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/monkeyrunner-25.3.2.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/ecj-4.6.1.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/asset-studio-25.3.2.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/httpmime-4.1.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/kxml2-2.3.0.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/ddmuilib-25.3.2.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/org-eclipse-jface-3.6.2.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/httpcore-4.1.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/bcpkix-jdk15on-1.48.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/jcommon-1.0.12.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/layoutlib-api-25.3.2.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/lint-25.3.2.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/ddms-25.3.2.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/emma_device.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/x86/swt.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/proguard-project.txt
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/guava-18.0.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/sdk-common-25.3.2.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/swtmenubar-25.3.2.jar
[delete] https://crrev.com/0e0e5924744f42e1d1c4650d057c3ada194678fb/sdk/tools-lint/lib/devices.xml

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9e3ce37961d0c9a576bdff33f69bd77080d19b5

commit b9e3ce37961d0c9a576bdff33f69bd77080d19b5
Author: Peter Wen <wnwen@chromium.org>
Date: Wed Jan 17 19:09:20 2018

Android: Roll third_party/android_tools

Pick up change to remove tools-lint.

https://crrev.com/c9f9bbf0a6c862fbef6115e80e8617093cd58e6b

BUG= 798833 

Change-Id: I41f697ed5e8e9bc915113a9ff6407c6994df9b59
Reviewed-on: https://chromium-review.googlesource.com/867330
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529837}
[modify] https://crrev.com/b9e3ce37961d0c9a576bdff33f69bd77080d19b5/DEPS

Comment 4 by wnwen@chromium.org, Jan 17 2018

Status: Fixed (was: Assigned)

Sign in to add a comment