Chromebook Plus both click and touchstart events firing
Reported by
becca.k...@pearson.com,
Jan 3 2018
|
||||
Issue descriptionChrome Version: Google Chrome: 62.0.3202.97 Chrome OS Version: Platform 9901.77.0 Chrome OS Platform: Samsung Chromebook Plue Firmware Version: Google_Kevin.8785.220.0 There seems to be an issue that is exclusive to the Samsung Chromebook Plus device where the touch cascade is not cancelled if you prevent default on touchstart. Generally, if you prevent default an event on touchstart, the click event will not fire. On this particular device (Model XE513C24), the touch cascade is only cancelled if you add a prevent default for a touchend event which is different than any other device. Steps To Reproduce: (1)Open example html on a Samsung Chromebook Plus device. (Also at jsbin.com/qatixibumu) (2)Touch the Green box (3)Notice both X and O appear in the output box. In every other touch platform, on touchstart with a return false or preventDefault, the click event is cancelled so only X's appear Expected Result: Only X's should appear in output box on touch. Actual Result: Both X's and O's appear in output box on touch. How frequently does this problem reproduce? Always What is the impact to the user, and is there a workaround? If so, what is it? This causes a double-click effect if there is a listener attached to both touchstart and click. The only available workaround is to add a touchend listener to the touchstart event callback and call preventDefault in the function for the touchend event.
,
Jan 8 2018
,
Jan 8 2018
,
Jan 9 2018
I am unable to reproduce this issue. I am using a Caroline device on Chrome OS 10176.41.0, 64.0.3282.79
,
Jan 9 2018
Thanks for checking! Could you try with a kevin to see if it is something device-specific?
,
Jan 9 2018
I was able to reproduce this issue using a Kevin device. Using the same build as Caroline Chrome OS 10176.41.0, 64.0.3282.79
,
Jan 9 2018
Great, thanks for double-checking and confirming the issue exists on Kevin. abodenha@, could you help me figure out where to direct this? Basically there are 2 javascript events being thrown on a touchscreen interaction with Kevin (but not Caroline nor Minnie) which will result in an effective double-click.
,
Feb 7 2018
hmm, i think i know what is going on here, it's caused by the passive listener. in this CL we enabled passive_event_listeners for kevin(and only kevin) for performance maybe: commit 3e87b739eba791921a358bd77712d4b5cb5069a2 Author: Charlie Mooney <charliemooney@chromium.org> Date: Wed Sep 21 11:03:07 2016 -0700 make.conf: enable passive_event_listeners USE flag This CL enabled the "passive_event_listeners" USE flag for Kevin. BUG=chrome-os-partner:57500 TEST=used "equery-kevin u libchromeos-use-flags" to check that the USE flag I just enabled shows up for kevin ebuilds. (I temporarily modified that package to have an IUSE value in the ebuild that includes the new flag) Change-Id: Ic739b2d0cba77ef3eecbd1d5fba752e22bf0fad8 Signed-off-by: Charlie Mooney <charliemooney@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/387726 Reviewed-by: Mike Frysinger <vapier@chromium.org>
,
Feb 7 2018
an easy way to confirm this would be remove the args in chrome_dev.conf: localhost / # tail -1 /etc/chrome_dev.conf !--passive-listeners-default=true
,
Oct 16
Did this ever get fixed? Was it the passive listener?
,
Nov 12
Hello, Any update on this? |
||||
►
Sign in to add a comment |
||||
Comment 1 by maxkirsch@chromium.org
, Jan 8 2018Components: Internals>Input>Touch>Screen
Labels: -Pri-3 Pri-1