New issue
Advanced search Search tips

Issue 798828 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Internal failure should still upload performance stats

Project Member Reported by mar...@chromium.org, Jan 3 2018

Issue description

An internal failure could happen due to excessive resource usage, so getting as much data back is useful for diagnosis.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/b2c09b131a7a7cceb1121c86a4352d7b8b9b6c32

commit b2c09b131a7a7cceb1121c86a4352d7b8b9b6c32
Author: Seth Koehler <sethkoehler@google.com>
Date: Wed Jan 03 20:53:21 2018

Fix error with stats/bot_overhead included when duration is not.

When an error occurs during swarming execution and we clear out the
exit code and duration as part of b/69462084, we must also clear out
various stats (including bot_overhead) to prevent additional swarming
server errors of the form "Failed to update task: duration must be
set when performance_stats is set".

TESTED=task_runner_test.py and verified (by forcing an error in
client/isolatedserver.py) that we no longer see errors on the
swarming server associated with task_update (the forced error itself
still shows up as a task_error correctly).

Bug: 798828
Change-Id: I46dc2dd430e3389bd1da78612752b754ad377b8d
Reviewed-on: https://chromium-review.googlesource.com/847712
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/b2c09b131a7a7cceb1121c86a4352d7b8b9b6c32/appengine/swarming/swarming_bot/bot_code/task_runner.py

 Issue 799266  has been merged into this issue.
Project Member

Comment 3 by sheriffbot@chromium.org, Jan 8

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Pri-3 -Hotlist-Recharge-Cold Pri-2
Status: Available (was: Untriaged)

Sign in to add a comment