Use "data" attribute in cronet/android/BUILD.gn for data dependency |
||
Issue descriptionThere is a "data" attribute in gn which we can use to specify data dependency. e.g. https://cs.chromium.org/chromium/src/android_webview/test/BUILD.gn?rcl=ce146f1f300988c960e1eecf8a61b238d6fd7f7f&l=238 We should remove components/cronet/android/test/src/org/chromium/net/TestFilesInstaller.java which installs test asset files on the device, and just use the "data" attribute.
,
Jan 3 2018
Or perhaps we can work to find a similarly easy-to-override method.
,
Jan 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb99c7d55a4cbbe4fea419477f71d48bd6700417 commit cb99c7d55a4cbbe4fea419477f71d48bd6700417 Author: Helen Li <xunjieli@chromium.org> Date: Thu Jan 04 16:40:07 2018 Use "data" attribute in cronet/android/BUILD.gn This CL makes use of "data" attribute in cronet/android/BUILD.gn. The benefit is that we can avoid copying the files during test run. Bug: 798812 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I82f6fe5e1285a8edc4f1550d4da023cca388f2cc Reviewed-on: https://chromium-review.googlesource.com/849091 Reviewed-by: Paul Jensen <pauljensen@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#527005} [modify] https://crrev.com/cb99c7d55a4cbbe4fea419477f71d48bd6700417/components/cronet/android/BUILD.gn [modify] https://crrev.com/cb99c7d55a4cbbe4fea419477f71d48bd6700417/components/cronet/android/test/src/org/chromium/net/TestFilesInstaller.java
,
Jan 4 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by pauljensen@chromium.org
, Jan 3 2018