It's hard to tell in chrome://settings that your NTP is controlled by an extension |
||||||||||||||||||||||
Issue description
Chrome Version: 63.0.3239.84
OS: All
I reproed this on a Chromebook, but I can get the same thing on my Mac, so this is a UI problem across all chrome://settings.
My grandma's Chromebook had an extension that hijacked the NTP, but because the extension had checked the radio button to open a specific set of pages ("google.com" in particular), it was hard to see where the hijacking was happening and how to turn it off.
(1) Install an NTP extension, add it to the "On Startup" section of chrome://settings (or, it installs itself that way most likely). See screenshot one.png
(2) Click the "Open a specific page or set of pages" radio button, enter "google.com" in it (because you're an evil extension pretending you're not hijacking the ntp. See screenshot two.png
What is the expected result?
New tabs should open with google.com (because "Open the New Tab page" isn't selected)
What happens instead?
New tabs open with the extension. On startup, however, the setting is kept (and chrome starts with google.com)
I understand that "On Startup" is very different than "On a New Tab", but users can't tell the difference (i certainly couldn't), and can't see how to turn off this extension.
Can we surface "On New Tab" as a different section than "On Startup", if they're not meant to be the same? Or, can the radio buttons act like radio buttons and clear the previous selection?
,
Jan 3 2018
Postponing assignment here until we figure out NTP plans for 2018
,
Jan 4 2018
> What is the expected result? > New tabs should open with google.com (because "Open the New Tab page" isn't selected) I don't understand this expectation. A new tab always shows the new tab UI (whether it is Chrome's default UI or a UI provided by an extension that overrides the NTP). The contents of a new tab are unrelated to the "Open a specific set of pages". I do understand though that unless the user selects the "Open new tab page" option, the fact that the new tab page is overriden by an extension is not surfaced anywhere in the Settings page. Proposal: Perhaps we could simply show the NTP controlled indicator, even when a different radio button is selected, see screenshot. Thoughts?
,
Jan 8 2018
As a user, that would work for me! :)
,
Jan 25 2018
Posting some more details to help clarify some scenarios, and facilitate making a decsion: Case 0: NTP controlled by an extension, and "Open new tab page" selected. case0_tot.png: This is the only time we ever display the extension controlled indicator. In all following cases the NTP is controlled by an extension and "Open specific..." selected. Case 1: No policies. - case1_tot.png: The fact that NTP is controlled is not displayed. - case1_suggestion.png: Display extension controlled indicator, even though "Open specific..." is not selected. Case 2: RestoreOnStartupURLs policy. Note that because of the policy the startup URLs can't be changed (no dots menu), but the radio group selection can still be changed. - case2_tot.png: The fact that NTP is controlled is not displayed. - case2_suggestion.png: Display extension controlled indicator. Case 3: RestoreOnStartupURLs and RestoreOnStartup policies active. Note that because of the policies the user can't change the startup URLs, and can modify the radio group selection either. - case3_tot.png: The fact that NTP is controlled is not displayed. - case3_suggestion.png: Display extension controlled indicator.
,
Jan 29 2018
Re proposal on C3: SGTM
,
Jan 30 2018
,
Jan 30 2018
I'll make sure this gets worked on soon.
,
Feb 6 2018
,
Feb 9 2018
,
Feb 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/28a01a99409fc49d1a0388f74083206596f6cdfa commit 28a01a99409fc49d1a0388f74083206596f6cdfa Author: Esmael El-Moslimany <aee@chromium.org> Date: Sat Feb 10 02:42:40 2018 Settings: Always show ntp extension in "On startup" section Regardless of which "On startup" radio option is selected, always show ntp extensions. This makes it easier to disable the ntp extension. R=dpapad@chromium.org, scottchen@chromium.org Bug: 798802 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Icb50e9d1f563d11ccded31468ec8f145ea774d45 Reviewed-on: https://chromium-review.googlesource.com/912229 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#535941} [modify] https://crrev.com/28a01a99409fc49d1a0388f74083206596f6cdfa/chrome/browser/resources/settings/on_startup_page/on_startup_page.html [modify] https://crrev.com/28a01a99409fc49d1a0388f74083206596f6cdfa/chrome/browser/resources/settings/on_startup_page/on_startup_page.js
,
Feb 12 2018
Verified the fix on Mac 10.12.6, Windows-10, Ubuntu 14.04 on Chrome version #66.0.3345.0 as per the comment#14 Attaching screen shot for reference. Observed "NTP extension in "On startup" section even other radio buttons are selected" Hence, the fix is working as expected. Adding the verified label. Thanks!
,
Feb 12 2018
,
Feb 12 2018
Thank you so much for the fix, y'all! Much appreciated! ❤️ |
||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||
Comment 1 by n...@chromium.org
, Jan 3 2018