New issue
Advanced search Search tips

Issue 798799 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Task



Sign in to add a comment

migrate puffin use from CrOS to AOSP

Project Member Reported by ahass...@chromium.org, Jan 3 2018

Issue description

We moved puffin to AOSP, so we need to start building using the AOSP version.

The steps for doing this:
- Add AOSP puffin repository to internal and external manifests.
- Change puffin ebuild to use the AOSP repository.
- Remove CrOS puffin repositories from internal and external manifests.
 
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 4 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/341abe26aa66bc1361c288c583dd8291b4dddeaf

commit 341abe26aa66bc1361c288c583dd8291b4dddeaf
Author: Amin Hassani <ahassani@google.com>
Date: Thu Jan 04 22:35:22 2018

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/f9748b6e2ac8672141fce6f2a7435c2d752060da

commit f9748b6e2ac8672141fce6f2a7435c2d752060da
Author: Amin Hassani <ahassani@google.com>
Date: Sat Jan 06 00:42:53 2018

puffin: build puffin from AOSP

We have migrated puffin to AOSP, we need to change the ebuild to use
ASOP version instead.

BUG= chromium:798799 
TEST=unittests pass

Change-Id: I7715f3fb052002a79b8490f0f36253aaaf382566
Reviewed-on: https://chromium-review.googlesource.com/849297
Commit-Ready: Amin Hassani <ahassani@chromium.org>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/f9748b6e2ac8672141fce6f2a7435c2d752060da/dev-util/puffin/puffin-9999.ebuild

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/manifest/+/ad391e6da3ed4ec418763ff1c43b8f107c83bbdf

commit ad391e6da3ed4ec418763ff1c43b8f107c83bbdf
Author: Amin Hassani <ahassani@google.com>
Date: Sat Jan 06 07:59:08 2018

Remove puffin repository in CrOS

We have migrated puffin to AOSP. This is not needed anymore.

BUG= chromium:798799 
TEST=repo upload
TEST=unittests pass
CQ-DEPEND=CL:849297

Change-Id: Iad3dcd7244991d3000818b22fe61d97276651430
Reviewed-on: https://chromium-review.googlesource.com/849300
Commit-Ready: Amin Hassani <ahassani@chromium.org>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/ad391e6da3ed4ec418763ff1c43b8f107c83bbdf/full.xml

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/19fa005adc54a966455463275a5e5662aa6c3802

commit 19fa005adc54a966455463275a5e5662aa6c3802
Author: Amin Hassani <ahassani@google.com>
Date: Fri Jan 19 01:40:39 2018

Status: Fixed (was: Started)

Sign in to add a comment