New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 798777 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Remoting UI is hidden if Chrome font size is set to very large

Project Member Reported by dbbrooks@chromium.org, Jan 3 2018

Issue description

Chrome Version: 65.0.3310.0
OS: Win, Mac

Note: Found during Accessibility Review of new Media Remoting UI.

What steps will reproduce the problem?
(1) In Chrome, go to settings, and under Appearance, change Font size to Very large.
(2) Open Cast dialog and cast a tab to a Chromecast device

What is the expected result? Media Remoting UI in dialog should be shown correctly.

What happens instead? The Media Remoting UI get's hidden. See screenshot.

 
Remoting_UI_Accessibility.PNG
10.5 KB View Download
Labels: OS-Mac
Labels: -Pri-3 M-65 Pri-1
Owner: imch...@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd3e4c09bdbb6d433e81681de04a99b70792219a

commit fd3e4c09bdbb6d433e81681de04a99b70792219a
Author: Derek Cheng <imcheng@chromium.org>
Date: Fri Jan 19 06:53:54 2018

[Media Router UI] Fix media remoting UI controls runover on large fonts.

This done by removing the white-space: nowrap; attribute.

Bug:  798777 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2f4af3cc8f6d2c790dab6124a4d9aad0639b8128
Reviewed-on: https://chromium-review.googlesource.com/875416
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530443}
[modify] https://crrev.com/fd3e4c09bdbb6d433e81681de04a99b70792219a/chrome/browser/resources/media_router/elements/route_controls/route_controls.css

Components: -Internals>Cast Internals>Cast>UI
Labels: Merge-Request-65
Status: Fixed (was: Assigned)
As the issue requires Cast device to test and verify which is not available with ET and Inhouse team, hence forwarding this to MTV for help in verification if the Cast device is available there, adding the label as TE-NeedsTriageFromMTV.

Thanks!
Cc: viswatej...@techmahindra.com
Labels: TE-NeedsTriageFromMTV
Project Member

Comment 7 by sheriffbot@chromium.org, Jan 24 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by gov...@chromium.org, Jan 24 2018

Pls merge your change to M65 branch 3325 ASAP so we can pick it up for tomorrow's dev release. Thank you.
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 24 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a76d99a834b29fedf030483b209f7d473cf1b94c

commit a76d99a834b29fedf030483b209f7d473cf1b94c
Author: Derek Cheng <imcheng@chromium.org>
Date: Wed Jan 24 21:46:02 2018

[Media Router UI] Fix media remoting UI controls runover on large fonts.

This done by removing the white-space: nowrap; attribute.

Bug:  798777 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2f4af3cc8f6d2c790dab6124a4d9aad0639b8128
Reviewed-on: https://chromium-review.googlesource.com/875416
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#530443}(cherry picked from commit fd3e4c09bdbb6d433e81681de04a99b70792219a)
Reviewed-on: https://chromium-review.googlesource.com/884506
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#71}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/a76d99a834b29fedf030483b209f7d473cf1b94c/chrome/browser/resources/media_router/elements/route_controls/route_controls.css

Status: Verified (was: Fixed)
Verified on 65.0.3325.18.

Sign in to add a comment