New issue
Advanced search Search tips

Issue 798772 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 808745
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

QuickView/FileManagerBrowserTest is flaky on linux-chromeos-dbg

Project Member Reported by glevin@chromium.org, Jan 3 2018

Issue description

Chrome Version: 65.0.3311.0
OS: Chrome

QuickView/FileManagerBrowserTest in browser_tests has been occasionally flaky since at least 12/07/17.  See for example:
  https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/3060
  https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/3499
  https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/3542

Final try from that last run:

Retrying 1 test (retry #3)
Still waiting for the following processes to finish:
	./browser_tests --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=QuickView/FileManagerBrowserTest.Test/2 --single_process --test-launcher-bot-mode --test-launcher-output=/b/s/w/it1Im2xu/.org.chromium.Chromium.bWOOmQ/resultsY39P1K/test_results.xml --test-launcher-summary-output=/b/s/w/ioepd3Wb/output.json --user-data-dir=/b/s/w/it1Im2xu/.org.chromium.Chromium.bWOOmQ/dJCXa27
[0103/034247.690114:ERROR:kill_posix.cc(84)] Unable to terminate process group 29091: No such process (3)
[ RUN      ] QuickView/FileManagerBrowserTest.Test/2
    ...
[29091:29091:0103/034245.928500:INFO:CONSOLE(71)] "Uncaught TypeError: Cannot read property 'contentWindow' of null", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/foreground/elements/files_safe_media.js (71)
[29091:29091:0103/034246.503364:INFO:CONSOLE(0)] "[FAIL] openQuickViewForFoldersAfterClose: API Test Error in openQuickViewForFoldersAfterClose: The error count is not 0.
Actual: 1
Expected: 0
Error
    at Object.handleRequest (extensions::binding:64:27)
    at Object.<anonymous> (extensions::binding:374:32)
    at Object.<anonymous> (extensions::test:230:18)
    at Object.handleRequest (extensions::binding:64:27)
    at Object.<anonymous> (extensions::binding:374:32)
    at chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js:36:17", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/_generated_background_page.html (0)
[29091:29091:0103/034246.503983:INFO:CONSOLE(0)] "Uncaught (in promise) chrome.test.failure", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/_generated_background_page.html (0)
../../chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc:599: Failure
Failed
Failed 1 of 1 tests
[29091:29091:0103/034247.228298:WARNING:event_router.cc(423)] Not all file watchers are removed. This can happen when the Files app is open during shutdown.
[29091:29091:0103/034247.230434:INFO:chrome_cryptauth_service.cc(233)] Profile is not authenticated yet; waiting before starting CryptAuth managers.
[29091:29091:0103/034247.427670:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[  FAILED  ] QuickView/FileManagerBrowserTest.Test/2, where GetParam() = (0, 0xca3ce97 pointing to "openQuickViewForFoldersAfterClose") (16442 ms)
[457/457] QuickView/FileManagerBrowserTest.Test/2 (17831 ms)
1 test failed:
    QuickView/FileManagerBrowserTest.Test/2 (../../chrome/browser/chromeos/file_manager/file_manager_browsertest.cc:40)

+tetsui@, would you mind taking a look or triaging this, since you took care of the last time this test flaked ( Issue 668142 )?
 
Components: Tests>Disabled
this is the most flaky bug right now, so I am going to go ahead and disable the test for now.
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f6bacf5ffb4334acedb86e43f88d3fb582ef34c

commit 5f6bacf5ffb4334acedb86e43f88d3fb582ef34c
Author: Dominic Battre <battre@chromium.org>
Date: Thu Jan 04 12:59:07 2018

Disabled flaky QuickView.FileManagerBrowserTest.openQuickViewForFoldersAfterClose

TBR=tetsui@chromium.org,hirono@chromium.org

Bug:  798772 
Change-Id: Ib5190f6f5bd9e1aafbb83d06bc0c5cc07ef4a320
Reviewed-on: https://chromium-review.googlesource.com/850352
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526967}
[modify] https://crrev.com/5f6bacf5ffb4334acedb86e43f88d3fb582ef34c/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Cc: yamaguchi@chromium.org fukino@chromium.org
Status: Started (was: Assigned)
It seems it started to flake from https://crrev.com/c/771453 , which is a fix for    https://crbug.com/783734  .
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2bf5ec6cff5f6eecf5a580ae61fbf39ce149039d

commit 2bf5ec6cff5f6eecf5a580ae61fbf39ce149039d
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Tue Jan 09 08:57:47 2018

Fix and enable flaky openQuickViewForFoldersAfterClose test.

openQuickViewForFoldersAfterClose started to flake after
https://crrev.com/c/771453, which is a fix for  https://crbug.com/783734 .

The CL modified contentWindow.postMessage to be called asynchronously,
but there was no guarantee that contentWindow is still available when
the QuickView is immediately closed.

TEST=out/Release/browser_tests
'--gtest_filter=QuickView/FileManagerBrowserTest.Test/*'
--gtest_repeat=100
BUG= 798772 

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7d5dec7a7b8ef2ccb4e3de3e69ed376e58545adb
Reviewed-on: https://chromium-review.googlesource.com/856378
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527941}
[modify] https://crrev.com/2bf5ec6cff5f6eecf5a580ae61fbf39ce149039d/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/2bf5ec6cff5f6eecf5a580ae61fbf39ce149039d/ui/file_manager/file_manager/foreground/elements/files_safe_media.js

Status: Fixed (was: Started)
Components: Tests>Disabled
Labels: Test-Disabled
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d532b44ae1f17234429c8d653fd5cca2a253b0e6

commit d532b44ae1f17234429c8d653fd5cca2a253b0e6
Author: Yuta Kitamura <yutak@chromium.org>
Date: Mon Feb 05 07:12:57 2018

Revert "Fix and enable flaky openQuickViewForFoldersAfterClose test."

This reverts commit 2bf5ec6cff5f6eecf5a580ae61fbf39ce149039d.

Reason for revert: This did not actually fix the flakiness.
( crbug.com/808745 )

Original change's description:
> Fix and enable flaky openQuickViewForFoldersAfterClose test.
> 
> openQuickViewForFoldersAfterClose started to flake after
> https://crrev.com/c/771453, which is a fix for  https://crbug.com/783734 .
> 
> The CL modified contentWindow.postMessage to be called asynchronously,
> but there was no guarantee that contentWindow is still available when
> the QuickView is immediately closed.
> 
> TEST=out/Release/browser_tests
> '--gtest_filter=QuickView/FileManagerBrowserTest.Test/*'
> --gtest_repeat=100
> BUG= 798772 
> 
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I7d5dec7a7b8ef2ccb4e3de3e69ed376e58545adb
> Reviewed-on: https://chromium-review.googlesource.com/856378
> Reviewed-by: Naoki Fukino <fukino@chromium.org>
> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#527941}

TBR=fukino@chromium.org,tetsui@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  798772 
Change-Id: I4a7f9102c9554f4fce81a331c1b68e1efd0ba716
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/899388
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534343}
[modify] https://crrev.com/d532b44ae1f17234429c8d653fd5cca2a253b0e6/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/d532b44ae1f17234429c8d653fd5cca2a253b0e6/ui/file_manager/file_manager/foreground/elements/files_safe_media.js

Status: Assigned (was: Fixed)
Reopening per Comment 7.
Mergedinto: 808745
Status: Duplicate (was: Assigned)
Sorry, I think we can track the issue by  Issue 808745 .

Sign in to add a comment