Small fix-ups Q1 2018 |
||||
Issue descriptionTracking minor bugs / fixes
,
Jan 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/mosys/+/849ee42ca9f7242a60083aa0cfc755d8cbfbf732 commit 849ee42ca9f7242a60083aa0cfc755d8cbfbf732 Author: Simon Glass <sjg@chromium.org> Date: Mon Jan 08 03:41:48 2018 Mark 'mosys platform signature' as 'unibuild-only' This command should only be used with unibuild since it accesses the master configuration. BUG= chromium:798771 BRANCH=none TEST=none Change-Id: Ie8bb1fe05b37331f15a292d8524f9bfe26642e57 Reviewed-on: https://chromium-review.googlesource.com/786638 Reviewed-by: Jason Clinton <jclinton@chromium.org> Tested-by: Simon Glass <sjg@chromium.org> [modify] https://crrev.com/849ee42ca9f7242a60083aa0cfc755d8cbfbf732/lib/misc/sku.c
,
Feb 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/mosys/+/38e74b2134b8722d73b055dfb17b6dea45587b93 commit 38e74b2134b8722d73b055dfb17b6dea45587b93 Author: Simon Glass <sjg@chromium.org> Date: Tue Feb 06 06:21:11 2018 mosys: Drop unused variable in platform_id_cmd() This causes a warning in the build. Drop it. BUG= chromium:798771 BRANCH=none TEST=FEATURES=test emerge-coral --nodeps mosys See the warning is gone Signed-off-by: Simon Glass <sjg@chromium.org> Change-Id: I4dcef9e51a5d5fbaf75bf62428789375dacbee13 Reviewed-on: https://chromium-review.googlesource.com/847919 Commit-Ready: Simon Glass <sjg@chromium.org> Tested-by: Simon Glass <sjg@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> (cherry picked from commit fa21f8a60c03ad3f008859d266c37309168b74c2) Reviewed-on: https://chromium-review.googlesource.com/903250 Commit-Queue: Patrick Berny <pberny@chromium.org> Tested-by: Patrick Berny <pberny@chromium.org> Trybot-Ready: Patrick Berny <pberny@chromium.org> [modify] https://crrev.com/38e74b2134b8722d73b055dfb17b6dea45587b93/core/command/platform.c
,
Feb 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/mosys/+/df57f27365e2a12fe43f9fbf8c7c87a49e9481be commit df57f27365e2a12fe43f9fbf8c7c87a49e9481be Author: Simon Glass <sjg@chromium.org> Date: Tue Feb 06 06:24:37 2018 Mark 'mosys platform signature' as 'unibuild-only' This command should only be used with unibuild since it accesses the master configuration. BUG= chromium:798771 BRANCH=none TEST=none (cherry picked from commit 849ee42ca9f7242a60083aa0cfc755d8cbfbf732) Change-Id: Ie8bb1fe05b37331f15a292d8524f9bfe26642e57 Reviewed-on: https://chromium-review.googlesource.com/786638 Reviewed-by: Jason Clinton <jclinton@chromium.org> Tested-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/903253 Commit-Queue: Patrick Berny <pberny@chromium.org> Tested-by: Patrick Berny <pberny@chromium.org> Trybot-Ready: Patrick Berny <pberny@chromium.org> [modify] https://crrev.com/df57f27365e2a12fe43f9fbf8c7c87a49e9481be/lib/misc/sku.c
,
Feb 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/firmware/+/c6d32caa4d98f0aa36c8c70bfad8bbf2dbd6bdad commit c6d32caa4d98f0aa36c8c70bfad8bbf2dbd6bdad Author: Simon Glass <sjg@chromium.org> Date: Wed Feb 21 04:31:55 2018 chromeos-config: Use the correct import for libcros_config_host This is using an old import for this module. Fix it. BUG= chromium:798771 TEST= PYTHONPATH=~/c:~/c/src/platform2/chromeos-config \ python pack_firmware_unittest.py Change-Id: I45d1bfe6d751acb44b92b706a7f4c11f8b6d5fe7 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/925061 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Reviewed-by: Jason Clinton <jclinton@chromium.org> Reviewed-by: C Shapiro <shapiroc@google.com> [modify] https://crrev.com/c6d32caa4d98f0aa36c8c70bfad8bbf2dbd6bdad/pack_firmware_unittest.py
,
Feb 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/firmware/+/21175b0ca222ddde001dc5ee1ec68878fe741b66 commit 21175b0ca222ddde001dc5ee1ec68878fe741b66 Author: Simon Glass <sjg@chromium.org> Date: Thu Feb 22 18:34:18 2018 pack_firmware: Use the filename with CrosConfig() We now support passing a filename to CrosConfig rather than a File object. Update the firmware packer to use this. BUG= chromium:798771 TEST= PYTHONPATH=~/c:~/c/src/platform2/chromeos-config \ python pack_firmware_unittest.py Change-Id: I8de57c8bfffa8f0a81db821e1aee4fa5c5aed256 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/930705 Reviewed-by: Jason Clinton <jclinton@chromium.org> Reviewed-by: C Shapiro <shapiroc@google.com> [modify] https://crrev.com/21175b0ca222ddde001dc5ee1ec68878fe741b66/pack_firmware_unittest.py [modify] https://crrev.com/21175b0ca222ddde001dc5ee1ec68878fe741b66/pack_firmware.py
,
Mar 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/0d58296e98f71ea4ef59dd4a231a077b5d770435 commit 0d58296e98f71ea4ef59dd4a231a077b5d770435 Author: Simon Glass <sjg@chromium.org> Date: Sun Mar 04 04:04:11 2018 chromeos-config: Format code with clang-format The 'cros lint' pre-submit check currenty passes, but clang-format makes a number of suggested changes to the code. It is easier to follow these rules since it reduces the burden of getting the code formating correct. Update the code to match clang-format's view of the situation. It is possible to enable clang-format in the pre-submit, but this does work when using 'repo upload' outside the chroot (I get a 'permission denied' error). BUG= chromium:798771 TEST=clang-format -i -style=file $(find . -name '*.h' -o -name '*.cc') Change-Id: I2e731e8d1887c4d072bd6844ece991d79de829fa Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/937390 Reviewed-by: C Shapiro <shapiroc@google.com> [modify] https://crrev.com/0d58296e98f71ea4ef59dd4a231a077b5d770435/chromeos-config/cros_config_main.cc [modify] https://crrev.com/0d58296e98f71ea4ef59dd4a231a077b5d770435/chromeos-config/libcros_config/lookup.cc [modify] https://crrev.com/0d58296e98f71ea4ef59dd4a231a077b5d770435/chromeos-config/libcros_config/cros_config.cc [modify] https://crrev.com/0d58296e98f71ea4ef59dd4a231a077b5d770435/chromeos-config/libcros_config/fake_cros_config.cc [modify] https://crrev.com/0d58296e98f71ea4ef59dd4a231a077b5d770435/chromeos-config/libcros_config/fake_cros_config.h [modify] https://crrev.com/0d58296e98f71ea4ef59dd4a231a077b5d770435/chromeos-config/libcros_config/identity.h [modify] https://crrev.com/0d58296e98f71ea4ef59dd4a231a077b5d770435/chromeos-config/libcros_config/cros_config_interface.h [modify] https://crrev.com/0d58296e98f71ea4ef59dd4a231a077b5d770435/chromeos-config/libcros_config/identity.cc [modify] https://crrev.com/0d58296e98f71ea4ef59dd4a231a077b5d770435/chromeos-config/libcros_config/cros_config_unittest.cc [modify] https://crrev.com/0d58296e98f71ea4ef59dd4a231a077b5d770435/chromeos-config/libcros_config/fake_cros_config_unittest.cc [modify] https://crrev.com/0d58296e98f71ea4ef59dd4a231a077b5d770435/chromeos-config/cros_config_main_unittest.cc [modify] https://crrev.com/0d58296e98f71ea4ef59dd4a231a077b5d770435/chromeos-config/libcros_config/cros_config_json.cc [modify] https://crrev.com/0d58296e98f71ea4ef59dd4a231a077b5d770435/chromeos-config/libcros_config/cros_config_common.cc [modify] https://crrev.com/0d58296e98f71ea4ef59dd4a231a077b5d770435/chromeos-config/libcros_config/cros_config.h
,
Mar 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/mosys/+/32f3f93c67bd1fedddcd9ab4fc226f63df809f01 commit 32f3f93c67bd1fedddcd9ab4fc226f63df809f01 Author: Simon Glass <sjg@chromium.org> Date: Tue Mar 27 01:14:54 2018 mosys: Drop unused variable in platform_id_cmd() This causes a warning in the build. Drop it. BUG= chromium:798771 BRANCH=none TEST=FEATURES=test emerge-coral --nodeps mosys See the warning is gone Signed-off-by: Simon Glass <sjg@chromium.org> Change-Id: I4dcef9e51a5d5fbaf75bf62428789375dacbee13 Reviewed-on: https://chromium-review.googlesource.com/847919 Commit-Ready: Simon Glass <sjg@chromium.org> Tested-by: Simon Glass <sjg@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> (cherry picked from commit fa21f8a60c03ad3f008859d266c37309168b74c2) Reviewed-on: https://chromium-review.googlesource.com/981208 Commit-Queue: YH Lin <yueherngl@chromium.org> Tested-by: YH Lin <yueherngl@chromium.org> [modify] https://crrev.com/32f3f93c67bd1fedddcd9ab4fc226f63df809f01/core/command/platform.c
,
Mar 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/mosys/+/180bbfafa41b79fc0fdbc41712e23496b8489990 commit 180bbfafa41b79fc0fdbc41712e23496b8489990 Author: Simon Glass <sjg@chromium.org> Date: Tue Mar 27 01:18:41 2018 Mark 'mosys platform signature' as 'unibuild-only' This command should only be used with unibuild since it accesses the master configuration. BUG= chromium:798771 BRANCH=none TEST=none Change-Id: Ie8bb1fe05b37331f15a292d8524f9bfe26642e57 Reviewed-on: https://chromium-review.googlesource.com/786638 Reviewed-by: Jason Clinton <jclinton@chromium.org> Tested-by: Simon Glass <sjg@chromium.org> (cherry picked from commit 849ee42ca9f7242a60083aa0cfc755d8cbfbf732) Reviewed-on: https://chromium-review.googlesource.com/981211 Commit-Queue: YH Lin <yueherngl@chromium.org> Tested-by: YH Lin <yueherngl@chromium.org> [modify] https://crrev.com/180bbfafa41b79fc0fdbc41712e23496b8489990/lib/misc/sku.c
,
Apr 17 2018
,
Sep 10
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/crosutils/+/00fec7fc93c626e0bf3c0a1340b91660fade9fff commit 00fec7fc93c626e0bf3c0a1340b91660fade9fff Author: Simon Glass <sjg@chromium.org> Date: Mon Sep 10 05:09:06 2018 build_image: Add a -r alias for --noenable_rootfs_verification It is annoying to have to type such a long flag and remember that is has underscores, etc. Add a short-form flag. BUG= chromium:798771 TEST=manually try it with the following change: # Parse command line. FLAGS "$@" || exit 1 echo flags ${FLAGS_enable_rootfs_verification} exit 1 $ ./build_image -r --[no]enable_bootcache: Default all bootloaders to NOT use boot cache. (default: false) -r,--[no]enable_rootfs_verification: Default all bootloaders to use kernel-based root fs integrity checking. (default: true) $ ./build_image --board=grunt test -r flags 1 $ /build_image --board=grunt test --noenable_rootfs_verification flags 1 $ ./build_image --board=grunt test flags 0 Change-Id: Ie2c8ad320ffc5bbab3401fdcec6905fa4222e618 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/951702 Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/00fec7fc93c626e0bf3c0a1340b91660fade9fff/build_image |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Jan 5 2018