New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 798765 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocked on:
issue 773287



Sign in to add a comment

Two Windows GPU.FYI bots purple with python exception KeyError('root',)

Project Member Reported by jmad...@chromium.org, Jan 3 2018

Issue description

First failing builds:

https://ci.chromium.org/buildbot/chromium.gpu.fyi/Win7%20Experimental%20Release%20%28NVIDIA%29/2828
https://ci.chromium.org/buildbot/chromium.gpu.fyi/Win7%20x64%20dEQP%20Release%20%28NVIDIA%29/8410

Exception:


Traceback (most recent call last):
  File "E:\b\rr\tmphnfftx\rw\checkout\scripts\slave\.recipe_deps\recipe_engine\recipe_engine\run.py", line 275, in _new_run
    recipe_result = recipe_script.run(api, self.properties, self.environ)
  File "E:\b\rr\tmphnfftx\rw\checkout\scripts\slave\.recipe_deps\recipe_engine\recipe_engine\loader.py", line 98, in run
    self.run_steps, properties, environ, self.PROPERTIES, api=api)
  File "E:\b\rr\tmphnfftx\rw\checkout\scripts\slave\.recipe_deps\recipe_engine\recipe_engine\loader.py", line 626, in invoke_with_properties
    arg_names, **additional_args)
  File "E:\b\rr\tmphnfftx\rw\checkout\scripts\slave\.recipe_deps\recipe_engine\recipe_engine\loader.py", line 589, in _invoke_with_properties
    return callable_obj(*props, **additional_args)
  File "E:\b\rr\tmphnfftx\rw\checkout\scripts/slave\recipes\chromium.py", line 50, in RunSteps
    api.chromium_tests.main_waterfall_steps()
  File "E:\b\rr\tmphnfftx\rw\checkout\scripts\slave\.recipe_deps\recipe_engine\recipe_engine\recipe_api.py", line 750, in _inner
    return func(*a, **kw)
  File "E:\b\rr\tmphnfftx\rw\checkout\scripts/slave\recipe_modules\chromium_tests\api.py", line 840, in main_waterfall_steps
    update_step, bot_db = self.prepare_checkout(bot_config)
  File "E:\b\rr\tmphnfftx\rw\checkout\scripts\slave\.recipe_deps\recipe_engine\recipe_engine\recipe_api.py", line 750, in _inner
    return func(*a, **kw)
  File "E:\b\rr\tmphnfftx\rw\checkout\scripts/slave\recipe_modules\chromium_tests\api.py", line 202, in prepare_checkout
    bot_config, root_solution_revision, disable_syntax_validation)
  File "E:\b\rr\tmphnfftx\rw\checkout\scripts\slave\.recipe_deps\recipe_engine\recipe_engine\recipe_api.py", line 750, in _inner
    return func(*a, **kw)
  File "E:\b\rr\tmphnfftx\rw\checkout\scripts/slave\recipe_modules\chromium_checkout\api.py", line 79, in ensure_checkout
    disable_syntax_validation=disable_syntax_validation)
  File "E:\b\rr\tmphnfftx\rw\checkout\scripts\slave\.recipe_deps\recipe_engine\recipe_engine\recipe_api.py", line 750, in _inner
    return func(*a, **kw)
  File "E:\b\rr\tmphnfftx\rw\checkout\scripts\slave\.recipe_deps\depot_tools\recipes\recipe_modules\bot_update\api.py", line 334, in ensure_checkout
    co_root = result['root']
KeyError: 'root'

Seems like an infra bug. CC'ing troopers.
 

Comment 1 by kbr@chromium.org, Jan 3 2018

Components: Infra>Client>Chrome
Status: Untriaged (was: Available)
That is a terrible error message that means that bot_update failed.

This appears in the bot_update step's log:

Error: Command 'git checkout --quiet 2597f8672ac64e29173d3b9ec14a6fdfb73e2582' returned non-zero exit status 128 in E:\b\c\b\Win7_x64_dEQP_Release__NVIDIA_\src\third_party\devtools-node-modules
fatal: cannot create directory at 'third_party/node_modules/eslint/node_modules/file-entry-cache/node_modules/flat-cache/node_modules/del/node_modules/globby/node_modules/array-union/node_modules/array-uniq': Filename too long
Components: -Infra>Client>Chrome
Labels: -Infra-Troopers
Owner: chenwilliam@chromium.org
Status: Assigned (was: Untriaged)
... which is to say, this is caused by https://chromium.googlesource.com/chromium/src/+/48fbfe0faf98c982606fcf6d2732c9adcf086f1a, which appears in the blamelist of both first failures.

Removing from troopers and I>C>C.
Cc: johnchen@chromium.org
 Issue 798779  has been merged into this issue.
Will have a fix for this soon.

Comment 6 by kbr@chromium.org, Jan 3 2018

Blockedon: 773287
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa8741897906c4295af364929280573b3bee718e

commit fa8741897906c4295af364929280573b3bee718e
Author: Will Chen <chenwilliam@chromium.org>
Date: Wed Jan 03 20:29:26 2018

DevTools: roll devtools-node-modules to fix Windows bot issue

I inadvertently broke some Windows bots when I landed:
https://chromium-review.googlesource.com/c/chromium/src/+/848322

This sync'd the devtools-node-modules repo for all platforms, which caused
an issue on Windows because some of the node modules were deeply nested
(npm v2 and earlier installs it in a deeply nested manner). I restructured
the repo by installing it with npm v5 which flattens the node modules directory
which should solve these bot issues.

Bug:  798765 
Change-Id: I09056dbf6db3e4101918910f9c23d1cab260cc85
Reviewed-on: https://chromium-review.googlesource.com/848510
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526789}
[modify] https://crrev.com/fa8741897906c4295af364929280573b3bee718e/DEPS

Status: Fixed (was: Assigned)
Landed the fix and looks like the bots have successfully gone past that step.
Awesome. Thanks for the quick fix.

Sign in to add a comment