[Autofill] use emplace_back for pairs |
||
Issue descriptionIn these locations: https://cs.chromium.org/search/?q=push_back%5C(std::make_pair+file:autofill&sq=package:chromium&type=cs Instead of some_vector.push_back(std::make_pair(a, b)) we can use some_vector.emplace_back(a, b)
,
Jan 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/96fe9307614a2269cf6dd037a7bbaf749247e226 commit 96fe9307614a2269cf6dd037a7bbaf749247e226 Author: Hwanseung Lee <hs1217.lee@samsung.com> Date: Thu Jan 04 14:15:48 2018 [Autofill] use vector.emplace_back instead of push_back with pair Instead of some_vector.push_back(std::make_pair(a, b)) we can use some_vector.emplace_back(a, b) Bug: 798758 Change-Id: Ib470b5b809a255933706fb03db3cf9ce81fa9fef Reviewed-on: https://chromium-review.googlesource.com/848485 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#526981} [modify] https://crrev.com/96fe9307614a2269cf6dd037a7bbaf749247e226/components/autofill/core/browser/region_combobox_model.cc [modify] https://crrev.com/96fe9307614a2269cf6dd037a7bbaf749247e226/components/autofill/core/browser/region_combobox_model_unittest.cc
,
Jan 5 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by hs1217....@samsung.com
, Jan 4 2018Status: Started (was: Untriaged)