New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 798751 link

Starred by 1 user
Status: Fixed
Owner:
w...@chromium.org
Closed: Jan 2018
Cc:
█ fdegros@chromium.org
asvitk...@chromium.org
skare@chromium.org
isherman@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Allocator/StatisticsRecorderTest.NotInitialized/[0|1] started failing under Fuchsia FYI

Project Member Reported by w...@chromium.org, Jan 3 2018 
Tests fail with:

[ RUN      ] Allocator/StatisticsRecorderTest.NotInitialized/0
../../base/metrics/statistics_recorder_unittest.cc:127: Failure
Value of: StatisticsRecorder::IsActive()
  Actual: true
Expected: false
[  FAILED  ] Allocator/StatisticsRecorderTest.NotInitialized/0, where GetParam() = false (9 ms)

suggesting that some global state from an earlier test is not being properly torn down.

Comment 1 by asvitk...@chromium.org, Jan 3 2018

Owner: fdegros@chromium.org
Maybe caused by:

https://chromium-review.googlesource.com/830997

Comment 2 by asvitk...@chromium.org, Jan 3 2018

Status: Assigned (was: Untriaged)

Comment 3 by w...@chromium.org, Jan 3 2018

Cc: fdegros@chromium.org asvitk...@chromium.org
Owner: w...@chromium.org
Status: Started (was: Assigned)
This started with the landing of https://chromium-review.googlesource.com/830997, which changed the way that the "global" StatisticsRecorder instance is managed. 

By inspection, it appears that the tests will fail if anything calls StatisticsRecorder::Initialize() in the test process - then StatisticsRecorder::IsActive() will be true even after the test has uninitialized the test instance of the StatisticsRecorder, because UninitializeForTesting() was removed, so the global instance, if any, is not correctly cleaned-up before the tests run.

See https://ci.chromium.org/buildbot/chromium.fyi/Fuchsia%20ARM64/3848 for an example of a failed run.

I'll revert this for now.

Comment 4 by w...@chromium.org, Jan 3 2018

Status: Fixed (was: Started)
Reverted by https://chromium-review.googlesource.com/c/chromium/src/+/848273.
►

Sign in to add a comment