drop-handler-should-not-stop-navigate.html is flaky on leak bot |
||
Issue descriptionThe dashboard shows that it has been flaky for a while: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=fast%2Fevents%2Fdrop-handler-should-not-stop-navigate.html japhet@: The revision log shows that you were the last one that modified the file. Could you triage this and assign to the right owner? Thank you.
,
Jan 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/814252e7381fd19fab86440f56e567ed3f9bdcad commit 814252e7381fd19fab86440f56e567ed3f9bdcad Author: Hiroshige Hayashizaki <hiroshige@chromium.org> Date: Thu Jan 04 00:28:51 2018 Mark virtual/stable/http/tests/navigation/navigation-interrupted-by-fragment.html as leaking TBR=xidachen@chromium.org NOTRY=true Bug: 798735 Change-Id: Ic222eca158f094d52bcb09bbf959d0d6572d2ce8 Reviewed-on: https://chromium-review.googlesource.com/849640 Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#526870} [modify] https://crrev.com/814252e7381fd19fab86440f56e567ed3f9bdcad/third_party/WebKit/LayoutTests/LeakExpectations
,
Jan 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79e1a5b5dd6f339c52390e908e0ecc984f147820 commit 79e1a5b5dd6f339c52390e908e0ecc984f147820 Author: tzik <tzik@chromium.org> Date: Fri Jan 12 06:34:59 2018 Mark fast/events/only-valid-drop-targets-receive-file-drop.html as leaking LayoutTest leak detector detects its failure on the CI. As this seems to have the same cause to similar leaking tests, suppress this for now. Bug: 798735 Change-Id: I014b0921d80395ade8d20a26fc589dc826b17d50 Reviewed-on: https://chromium-review.googlesource.com/863225 Reviewed-by: Keishi Hattori <keishi@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#528895} [modify] https://crrev.com/79e1a5b5dd6f339c52390e908e0ecc984f147820/third_party/WebKit/LayoutTests/LeakExpectations
,
Jan 17 2018
These tests turned out to be not leaking. Below is what is happening. 1. BeforeUnload event gets fired 2. testRunner.NotifyDone() is called => Navigate to about:blank 3. BeforeUnload prevent default does not work => Navigate to the next page (as default) 4. Leak detection runs on the next page, reporting the increasing number of doms
,
Jan 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44f972fdc0ef63ef92faf1512d7dbe6c5bc8b6e7 commit 44f972fdc0ef63ef92faf1512d7dbe6c5bc8b6e7 Author: Yuzu Saijo <yuzus@chromium.org> Date: Wed Jan 17 08:38:50 2018 Rewrite the layout tests that use preventDefault in beforeunload handler This CL rewrites the layout tests that were failing to prevent the default action in beforeunload handler. It was causing a navigation after navigating to about:blank, which resulted in flaky leaks. (Leak detector counted the instances during a navigation to another page, not on about:blank as it is supposed to.) Thic CL stops the navigation after navigating to about:blank by modifying the laytout tests. Bug: 802982, 798735 Change-Id: I621642410e89012067b3b2f1ba0907cc1adad402 Reviewed-on: https://chromium-review.googlesource.com/869639 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#529675} [modify] https://crrev.com/44f972fdc0ef63ef92faf1512d7dbe6c5bc8b6e7/third_party/WebKit/LayoutTests/fast/events/drop-handler-should-not-stop-navigate-expected.txt [modify] https://crrev.com/44f972fdc0ef63ef92faf1512d7dbe6c5bc8b6e7/third_party/WebKit/LayoutTests/fast/events/drop-handler-should-not-stop-navigate.html [modify] https://crrev.com/44f972fdc0ef63ef92faf1512d7dbe6c5bc8b6e7/third_party/WebKit/LayoutTests/fast/events/only-valid-drop-targets-receive-file-drop-expected.txt [modify] https://crrev.com/44f972fdc0ef63ef92faf1512d7dbe6c5bc8b6e7/third_party/WebKit/LayoutTests/fast/events/only-valid-drop-targets-receive-file-drop.html |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jan 3 2018