New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 798705 link

Starred by 6 users
Status: Fixed
Owner:
jochen@chromium.org
Closed: Jan 2018
Cc:
jochen@chromium.org
█ krajshree@chromium.org
ajha@chromium.org
clamy@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
█ brajkumar@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: <a download href="blob:..."> (and filesystem) results in navigation instead of download

Project Member Reported by sc00335...@techmahindra.com, Jan 3 2018 
Chrome Version: 65.0.3310.0
OS: Mac 10.13.1, Ubuntu 14.04,Windows 10

What steps will reproduce the problem?
(1) Launched chrome and navigated to chrome://settings/help
(2) Opened devtools >> Toggled device toolbar >> Clicked on 3 dot menu >> Click Capture full size screenshot and observe

Issue 1: Navigate back >> Then Navigate forrward and observe -- blank page is seen.

 Issue 2 : Capture full size screenshot 3-4 times and chrome hangs

 Issue 3 : After clicking on capture full size screenshot unwanted pixels are seen

 Issue 4 : On capturing fullsize screenshot on same page zooms the inspected view 

Attaching screencasts of bug in Mac and Linux.

Good Build:65.0.3309.0
Bad Build:65.0.3310.0

Will provide bisect info in a while.
Linux.png
224 KB View Download
capture full screenshot_linux.ogv
5.8 MB View Download
Mac behaviour.webm
4.1 MB View Download

Comment 1 by sc00335...@techmahindra.com, Jan 3 2018

Labels: hasbisect-per-revision
Owner: jochen@chromium.org
Status: Assigned (was: Untriaged)
You are probably looking for a change made after 526474 (known good), but no later than 526475 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/cbce1149c9ae08297b816effbf456c02f97df8db..f2d2fe87028de36a489f7db3f5fb28da2e9d9b2b

Reviewed-on: https://chromium-review.googlesource.com/758236

Suspecting same from changelog.

@jochen: Please confirm the bug and help in re-assigning if it is not related to your change.

Thanks!

Comment 2 by nyerramilli@chromium.org, Jan 3 2018

Labels: RegressedIn-65 Target-65 FoundIn-65

Comment 3 by jochen@chromium.org, Jan 5 2018

Cc: clamy@chromium.org
Summary: Regression: <a download href="blob:..."> results in navigation instead of download (was: Regression: Unwanted pixels are seen and chrome hangs on capturing full screenshot in devtools)

Comment 4 by jochen@chromium.org, Jan 5 2018

Cc: nyerramilli@chromium.org jochen@chromium.org ranjitkan@chromium.org rbasuvula@chromium.org
 Issue 799393  has been merged into this issue.

Comment 5 by jochen@chromium.org, Jan 5 2018 

I got a fix ready, however, clamy@ wants to first land a refactoring.

Comment 6 by jmukthavaram@chromium.org, Jan 11 2018 

clamy@,
Could you please take a look into this issue as per C#5?
Thanks in advance!!
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e64bca2cec1bc5906982905430bdee5ca5de8cb5

commit e64bca2cec1bc5906982905430bdee5ca5de8cb5
Author: Jochen Eisinger <jochen@chromium.org>
Date: Fri Jan 12 09:17:03 2018

Plumb suggested_filename through OpenURL path

If we navigate to a blob URL, we'll use OpenURL() to initiate the
navigation. In order to correctly handle <a download>, we'll also need
to plumb the download attribute's content (aka suggested filename)
through

BUG= 798705 
R=clamy@chromium.org

Change-Id: I3e86c67efacc1657786a1ea23ab765802bef3297
Reviewed-on: https://chromium-review.googlesource.com/848897
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528910}
[modify] https://crrev.com/e64bca2cec1bc5906982905430bdee5ca5de8cb5/chrome/browser/ui/browser_navigator.cc
[modify] https://crrev.com/e64bca2cec1bc5906982905430bdee5ca5de8cb5/chrome/browser/ui/browser_navigator_params.cc
[modify] https://crrev.com/e64bca2cec1bc5906982905430bdee5ca5de8cb5/chrome/browser/ui/browser_navigator_params.h
[modify] https://crrev.com/e64bca2cec1bc5906982905430bdee5ca5de8cb5/chrome/test/data/extensions/api_test/webnavigation/download/test_download.js
[modify] https://crrev.com/e64bca2cec1bc5906982905430bdee5ca5de8cb5/content/browser/frame_host/navigation_controller_impl.cc
[modify] https://crrev.com/e64bca2cec1bc5906982905430bdee5ca5de8cb5/content/browser/frame_host/navigation_entry_impl.cc
[modify] https://crrev.com/e64bca2cec1bc5906982905430bdee5ca5de8cb5/content/browser/frame_host/navigation_entry_impl.h
[modify] https://crrev.com/e64bca2cec1bc5906982905430bdee5ca5de8cb5/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/e64bca2cec1bc5906982905430bdee5ca5de8cb5/content/browser/frame_host/navigator.h
[modify] https://crrev.com/e64bca2cec1bc5906982905430bdee5ca5de8cb5/content/browser/frame_host/navigator_impl.cc
[modify] https://crrev.com/e64bca2cec1bc5906982905430bdee5ca5de8cb5/content/browser/frame_host/navigator_impl.h
[modify] https://crrev.com/e64bca2cec1bc5906982905430bdee5ca5de8cb5/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/e64bca2cec1bc5906982905430bdee5ca5de8cb5/content/browser/security_exploit_browsertest.cc
[modify] https://crrev.com/e64bca2cec1bc5906982905430bdee5ca5de8cb5/content/common/frame_messages.h
[modify] https://crrev.com/e64bca2cec1bc5906982905430bdee5ca5de8cb5/content/public/browser/navigation_controller.h
[modify] https://crrev.com/e64bca2cec1bc5906982905430bdee5ca5de8cb5/content/public/browser/page_navigator.h
[modify] https://crrev.com/e64bca2cec1bc5906982905430bdee5ca5de8cb5/content/renderer/render_frame_impl.cc

Comment 8 by jochen@chromium.org, Jan 12 2018

Status: Fixed (was: Assigned)

Comment 9 by jochen@chromium.org, Jan 15 2018

Summary: Regression: <a download href="blob:..."> (and filesystem) results in navigation instead of download (was: Regression: <a download href="blob:..."> results in navigation instead of download)

Comment 10 by jochen@chromium.org, Jan 15 2018 

 Issue 801586  has been merged into this issue.

Comment 11 by nyerramilli@chromium.org, Feb 2 2018

Labels: ET-HYD-Reported
►

Sign in to add a comment