Issue metadata
Sign in to add a comment
|
setDragImage no longer works
Reported by
maarten....@42.nl,
Jan 3 2018
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.108 Safari/537.36 Steps to reproduce the problem: 1. Go to http://mereskin.github.io/dnd/#drag-image 2. Now drag the "I have custom dragImage. I don't work in IE." green block. 3. Notice that it shows a 'file icon' but not the drag image. What is the expected behavior? The expected behavior is that it is possible to see a custom image. What went wrong? Chrome shows a 'file icon' but no custom image. Did this work before? Yes 53 Does this work in other browsers? N/A Chrome version: 63.0.3239.108 Channel: stable OS Version: OS X 10.12.6 Flash Version:
,
Jan 3 2018
,
Jan 4 2018
Able to reproduce the issue on reported version 63.0.3239.108 and latest cancary 65.0.3310.0 using Mac 10.13.1 and Windows-10hence providing Bisect Info Note: Unable to drag the image on chrome reported version using Ubuntu 14.04 and on build# 50.0.2661.0 seeing the excepted behaviour. On windows in intermediate builds seeing the inconsistent behaviour in reproducing the issue. Bisect Info: ================ Good build: 63.0.3215.0 Bad build: 63.0.3216.0 You are probably looking for a change made after 501850 (known good), but no later than 501851 (first known bad). https://chromium.googlesource.com/chromium/src/+log/2700afca42099e3af0c2eed7a1fef7f1559c55d3..29a37905268827ff553fc2ba476ed3ed95b090b8 Reviewed-on: https://chromium-review.googlesource.com/665171 @Philip Rogers: Please confirm the issue and help in re-assigning if it is not related to your change. Adding ReleaseBlock-Stable as it seems recent break, feel free to remove it if not applicable. Thanks!
,
Jan 4 2018
CC'ing dcheng@chromium.org, as the owner(pdr@chromium.org) is on leave until March
,
Jan 4 2018
The suspected CL was also reported in issue 792404 for an apparently different type of regression.
,
Jan 4 2018
,
Jan 4 2018
,
Jan 4 2018
,
Jan 4 2018
,
Jan 4 2018
,
Jan 4 2018
The bug is that data-drag-image="#dragImage" is set on the draggable image. The element with id dragImage is positioned off the screen, and is thus clipped out because it does not intersect.
,
Jan 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0fca210a0133dfcdda8b2dcc1e7e9c84a5b10edd commit 0fca210a0133dfcdda8b2dcc1e7e9c84a5b10edd Author: Chris Harrelson <chrishtr@chromium.org> Date: Fri Jan 05 18:21:40 2018 [PE] Don't clip a drag image to the viewport unless it is larger than the viewport. The clipping is applied only as a protection against images being so big they are a memory or IPC payload issue. Furthermore, when drag images are specified, the drag image may be offscreen. Bug: 798704 Change-Id: I4015f6daa61d5e0504968952d0c530adfe926eef Reviewed-on: https://chromium-review.googlesource.com/851732 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#527324} [modify] https://crrev.com/0fca210a0133dfcdda8b2dcc1e7e9c84a5b10edd/third_party/WebKit/Source/core/clipboard/DataTransfer.cpp [modify] https://crrev.com/0fca210a0133dfcdda8b2dcc1e7e9c84a5b10edd/third_party/WebKit/Source/core/clipboard/DataTransferTest.cpp [modify] https://crrev.com/0fca210a0133dfcdda8b2dcc1e7e9c84a5b10edd/third_party/WebKit/Source/platform/geometry/FloatSize.h
,
Jan 5 2018
,
Jan 6 2018
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 8 2018
Approving merge to M64. Branch:3282
,
Jan 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a2c6f0b1802f06e39163443daa92c477e2d2b50 commit 7a2c6f0b1802f06e39163443daa92c477e2d2b50 Author: Chris Harrelson <chrishtr@chromium.org> Date: Tue Jan 09 19:21:48 2018 [PE] Don't clip a drag image to the viewport unless it is larger than the viewport. The clipping is applied only as a protection against images being so big they are a memory or IPC payload issue. Furthermore, when drag images are specified, the drag image may be offscreen. TBR=chrishtr@chromium.org (cherry picked from commit 0fca210a0133dfcdda8b2dcc1e7e9c84a5b10edd) Bug: 798704 Change-Id: I4015f6daa61d5e0504968952d0c530adfe926eef Reviewed-on: https://chromium-review.googlesource.com/851732 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Stephen Chenney <schenney@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#527324} Reviewed-on: https://chromium-review.googlesource.com/857325 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#465} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/7a2c6f0b1802f06e39163443daa92c477e2d2b50/third_party/WebKit/Source/core/clipboard/DataTransfer.cpp [modify] https://crrev.com/7a2c6f0b1802f06e39163443daa92c477e2d2b50/third_party/WebKit/Source/core/clipboard/DataTransferTest.cpp [modify] https://crrev.com/7a2c6f0b1802f06e39163443daa92c477e2d2b50/third_party/WebKit/Source/platform/geometry/FloatSize.h
,
Jan 9 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by krajshree@chromium.org
, Jan 3 2018