Issue metadata
Sign in to add a comment
|
Regression : Unnecessary ChromeVox focus is seen at top of the screen on continuous clicking on Uber Tray |
||||||||||||||||||||||||
Issue descriptionChrome Version: 64.0.3282.65/ 10176.36.0 beta-channel Kip,Daisy and Reks OS: Chrome What steps will reproduce the problem? (1)Sign into User -> Now at Uber Tray go to 'Accessibility' -> Select 'ChromeVox(spoken feedback)' (2)'ChromeVox(spoken feedback)' will be enabled -> Now open browser -> click on Address bar -> Now click on Uber Tray contnuously and observe unnecessary ChromeVox(Orange) focus at top of the screen (Please refer Video and screenshot) Note : Issue is seen in Sign-out screen (Please refer 'Actual_UnnecessaryFocusInSignOutScreen' video) Expected: No such ChromeVox(Orange) focus should be seen at top of the screen Actual: Instead unnecessary ChromeVox(Orange) focus is seen at top of the screen This is Regression issue as same is working fine in M-63 Note : Issue is seen on latest M-65 also
,
Feb 21 2018
Are you the right owner for this sort of bug? This is marked as release block stable for 65, so we need a fix in the next couple weeks.
,
Feb 21 2018
This relates to the focus highlight changes made by katie@. Moving over to her for further comment. Not a p1 though it is a regression.
,
Feb 21 2018
It looks to me like the the entire window is getting focus for just a moment after closing the uber tray, before the chromevox focus rect is returned to the address bar.
I believe all focus rects are drawn in the right place, but the bug is that an unexpected focus rect is drawn for a very short time on the whole window instead of going straight to the address bar, upon opening the uber tray.
I can add a logging at chromevox/cvox2/background/output.js range_ function formatNodeAndAncestors to see that the 'window' object is being added to the focus rect locations_:
window {left: 0, top: 35, width: 1366, height: 685}
So the focus ring is being drawn where chromevox wants it.
HOWEVER, agreed that this is not P1, and I'm not even sure it should be a launch blocker, since it's a tiny visual glitch on Chromevox rather than a focus bug or focus rect location bug. Reassigning back to David to see why the window is being added to the locations_ in output.js.
In discussion with dmazzoni, removing releaseblock-stable, and thinking about ways to make the focus ring behave more gracefully if a region is only focused for a few ms, to avoid the flashing behavior seen here. I'll track that in a separate bug.
,
Feb 23 2018
Thanks for investigating! This is along with other focus highlight issues, not core to ChromeVox, so re-prioritizing.
,
Feb 23 2018
The NextAction date has arrived: 2018-02-23
,
Feb 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f04a7fe57b6766698791205635b03d6ccdbbcc20 commit f04a7fe57b6766698791205635b03d6ccdbbcc20 Author: Katie D <katie@chromium.org> Date: Tue Feb 27 19:27:25 2018 Clean up rects input to AccessibilityFocusRingController::setFocusRings. This will remove duplicates and not bother to re-run logic if the rects in the list have not changed. While this doesn't fix a bug in which unnecessary chromevox focus is seen for a short while, it helps to clean up related code. Bug: 798691 Change-Id: I581789056390d370c67f0b2aebbace34bc714de2 Reviewed-on: https://chromium-review.googlesource.com/938672 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#539520} [modify] https://crrev.com/f04a7fe57b6766698791205635b03d6ccdbbcc20/ash/accessibility/accessibility_focus_ring_controller.cc
,
Jul 20
C#7>> @katie : Issue is working fine on latest M-69 69.0.3494.0/10893.0.0 Could you please tag this Issue as Fixed if there is no further work to be done here Thanks..!!
,
Jul 26
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by nyerramilli@chromium.org
, Feb 2 2018