gn gen disallows pure objective-c xctest files when generating xcode project
Reported by
peterhanspers@webrtc.org,
Jan 3 2018
|
|||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.84 Safari/537.36 Steps to reproduce the problem: 1. Modify the BUILD file and add an xctest file that ends in ".m" to a unit test target. 2. Run gn gen to generate an xcode project. 3. Observe that the new .m file is not included in the target, and the tests are not run as part of the target. What is the expected behavior? Xctest files that end in .m should also be considered when generating the xcode project. What went wrong? Xctest files that end in .m are filtered out in tools/gn/xcode_writer.cc. Did this work before? No Chrome version: 63.0.3239.84 Channel: n/a OS Version: OS X 10.12.6 Flash Version:
,
Jan 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af32cb03c8daf3696b972cae2c6791bdd6e05bb2 commit af32cb03c8daf3696b972cae2c6791bdd6e05bb2 Author: Peter Hanspers <peterhanspers@chromium.org> Date: Thu Jan 04 09:55:32 2018 Allow objective-c xctest files when generating xcode project. Bug: 798687 Change-Id: Idfa075e10f121fd6a7e09ee56f628610f2332ec7 Reviewed-on: https://chromium-review.googlesource.com/848834 Commit-Queue: Peter Hanspers <peterhanspers@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Yuke Liao <liaoyuke@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#526946} [modify] https://crrev.com/af32cb03c8daf3696b972cae2c6791bdd6e05bb2/tools/gn/xcode_writer.cc
,
Jan 4 2018
Thanks for filing the issue! This issue seems to be out of scope for triaging from ET end as it seems to be related to build. Hence , adding label TE-NeedsTriageHelp for further investigation.
,
Jan 4 2018
,
Jan 4 2018
,
Jan 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f1e844fc287579dd0e31c0256139bb32b22f2d34 commit f1e844fc287579dd0e31c0256139bb32b22f2d34 Author: Peter Hanspers <peterhanspers@chromium.org> Date: Fri Jan 05 10:32:12 2018 Allow EarlGrey objective-c xctest files. Bug: 798687 Change-Id: I5cf2c183581675cd62b792bcbeb2471b28434e62 Reviewed-on: https://chromium-review.googlesource.com/850612 Commit-Queue: Peter Hanspers <peterhanspers@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#527252} [modify] https://crrev.com/f1e844fc287579dd0e31c0256139bb32b22f2d34/tools/gn/xcode_writer.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by krajshree@chromium.org
, Jan 3 2018