New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 798684 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

power_LoadTest: add input activity simulation for more accurate power data

Project Member Reported by coconutruben@chromium.org, Jan 3 2018

Issue description

Right now PLT doesn't simulate any user input. This might be giving us too low power numbers, since we don't wake the keyboard, or the touchscreen etc should they go into a low power state.

This bug is to track the efforts towards building a proper input activity simulation for power_LoadTest.

The first effort here is waking the base on detachables whenever we scroll/navigate to a new page.
 
Owner: coconutruben@chromium.org
Status: Assigned (was: Available)
Sending Ruben's way as I believe he's working on this already for poppy
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/07f76b70ab4c7fd552d409f8feff7eac1cec03a8

commit 07f76b70ab4c7fd552d409f8feff7eac1cec03a8
Author: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Date: Mon Apr 16 16:20:43 2018

power_LoadTest: wake up the base when test navigates to new page

The power difference between an autosuspended base & an always on
base on detachables is significant (so far), thus we autosuspend
the base. However, this would mask real power consumption if during
PLT the base was always autosuspended.
This CL wakes the base every time PLT navigates to a new page for
10 seconds. It also wakes the base for 1s every time PLT scrolls.
On non-detachables it does nothing.

This functionality requires the PLT extension to ping the test
every time something happens. However I assume that any overhead these
HTTP Requests might cause is overshadowed by the requests being sent
and received for the actual PLT page loading.

BUG=b:63933645
BUG=chromium:798684
TEST=test_that <ip> power_LoadTest.1hour
(on DUT)
watch -n 4 -d cat /sys/bus/usb/devices/1-2/power/runtime_active_time
> observe the value increase whenever scroll or page navigation happens

Change-Id: I2a25b351985383cb99710591516d330dc0df348e
Reviewed-on: https://chromium-review.googlesource.com/686066
Commit-Ready: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Tested-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Reviewed-by: Todd Broch <tbroch@chromium.org>

[modify] https://crrev.com/07f76b70ab4c7fd552d409f8feff7eac1cec03a8/client/cros/power/power_utils.py
[modify] https://crrev.com/07f76b70ab4c7fd552d409f8feff7eac1cec03a8/client/cros/httpd.py
[modify] https://crrev.com/07f76b70ab4c7fd552d409f8feff7eac1cec03a8/client/site_tests/power_LoadTest/extension/test.js
[modify] https://crrev.com/07f76b70ab4c7fd552d409f8feff7eac1cec03a8/client/site_tests/power_LoadTest/power_LoadTest.py
[modify] https://crrev.com/07f76b70ab4c7fd552d409f8feff7eac1cec03a8/client/site_tests/power_LoadTest/extension/ct.js

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/d745871a600d5f9da893d1e1ac4981805b7cba1a

commit d745871a600d5f9da893d1e1ac4981805b7cba1a
Author: Puthikorn Voravootivat <puthik@chromium.org>
Date: Tue Apr 17 23:51:58 2018

Revert "power_LoadTest: wake up the base when test navigates to new page"

This reverts commit 07f76b70ab4c7fd552d409f8feff7eac1cec03a8.

Reason for revert: This broke PLT

Original change's description:
> power_LoadTest: wake up the base when test navigates to new page
> 
> The power difference between an autosuspended base & an always on
> base on detachables is significant (so far), thus we autosuspend
> the base. However, this would mask real power consumption if during
> PLT the base was always autosuspended.
> This CL wakes the base every time PLT navigates to a new page for
> 10 seconds. It also wakes the base for 1s every time PLT scrolls.
> On non-detachables it does nothing.
> 
> This functionality requires the PLT extension to ping the test
> every time something happens. However I assume that any overhead these
> HTTP Requests might cause is overshadowed by the requests being sent
> and received for the actual PLT page loading.
> 
> BUG=b:63933645
> BUG=chromium:798684
> TEST=test_that <ip> power_LoadTest.1hour
> (on DUT)
> watch -n 4 -d cat /sys/bus/usb/devices/1-2/power/runtime_active_time
> > observe the value increase whenever scroll or page navigation happens
> 
> Change-Id: I2a25b351985383cb99710591516d330dc0df348e
> Reviewed-on: https://chromium-review.googlesource.com/686066
> Commit-Ready: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
> Tested-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
> Reviewed-by: Todd Broch <tbroch@chromium.org>

Bug: b:63933645, chromium:798684
Change-Id: I962e50539403c5db016249782a7face1a5924a9e
Reviewed-on: https://chromium-review.googlesource.com/1016060
Reviewed-by: Puthikorn Voravootivat <puthik@chromium.org>
Commit-Queue: Puthikorn Voravootivat <puthik@chromium.org>
Tested-by: Puthikorn Voravootivat <puthik@chromium.org>
Trybot-Ready: Puthikorn Voravootivat <puthik@chromium.org>

[modify] https://crrev.com/d745871a600d5f9da893d1e1ac4981805b7cba1a/client/cros/power/power_utils.py
[modify] https://crrev.com/d745871a600d5f9da893d1e1ac4981805b7cba1a/client/cros/httpd.py
[modify] https://crrev.com/d745871a600d5f9da893d1e1ac4981805b7cba1a/client/site_tests/power_LoadTest/extension/test.js
[modify] https://crrev.com/d745871a600d5f9da893d1e1ac4981805b7cba1a/client/site_tests/power_LoadTest/power_LoadTest.py
[modify] https://crrev.com/d745871a600d5f9da893d1e1ac4981805b7cba1a/client/site_tests/power_LoadTest/extension/ct.js

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/7d68bc0645b3b7192cafd4d2face01afb65dbc98

commit 7d68bc0645b3b7192cafd4d2face01afb65dbc98
Author: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Date: Thu Apr 26 06:00:35 2018

power_LoadTest: wake up the base when test navigates to new page

The power difference between an autosuspended base & an always on
base on detachables is significant (so far), thus we autosuspend
the base. Keeping the base suspended during PLT masks real power
consumption.
This CL wakes the base every time PLT navigates to a new page for
10 seconds, and wakes the base for 1s every time PLT scrolls.
On non-detachables it does nothing.
On detachables without the base it logs a warning.

This functionality requires the PLT extension to ping the test
every time something happens. However I assume that any overhead these
HTTP Requests might cause is overshadowed by the requests being sent
and received for the actual PLT page loading.

BUG=b:63933645
BUG=chromium:798684
TEST=test_that <ip> power_LoadTest.1hour
(on DUT)
watch -n 4 -d cat /sys/bus/usb/devices/1-2/power/runtime_active_time
> observe the value increase whenever scroll or page navigation happens

Change-Id: I90b50951e3872a9c405cb14e53f256fd99238941
Reviewed-on: https://chromium-review.googlesource.com/1018603
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Reviewed-by: Puthikorn Voravootivat <puthik@chromium.org>

[modify] https://crrev.com/7d68bc0645b3b7192cafd4d2face01afb65dbc98/client/cros/power/power_utils.py
[modify] https://crrev.com/7d68bc0645b3b7192cafd4d2face01afb65dbc98/client/cros/httpd.py
[modify] https://crrev.com/7d68bc0645b3b7192cafd4d2face01afb65dbc98/client/site_tests/power_LoadTest/extension/test.js
[modify] https://crrev.com/7d68bc0645b3b7192cafd4d2face01afb65dbc98/client/site_tests/power_LoadTest/power_LoadTest.py
[modify] https://crrev.com/7d68bc0645b3b7192cafd4d2face01afb65dbc98/client/site_tests/power_LoadTest/extension/ct.js

Sign in to add a comment