New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 798676 link

Starred by 1 user
Status: Fixed
Owner:
jochen@chromium.org
Closed: Jan 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unable to 'Auto download' in https://permission.site/

Reported by shruti.j...@etouch.net, Jan 3 2018 
Chrome Version:65.0.3310.0  a4f3664d72558b103a0e24d718e4ef0faff17a79-refs/heads/master@{#526575}

OS: Win(7,8,10), Mac(10.12.6) and Linux(14.04 LTS).

Steps to reproduce:
1.Launch chrome and Navigate https://permission.site/
2.Click on 'Auto download' button and observe

Actual Result:  Unable to 'Auto download' from https://permission.site/
Expected Result:File should get 'Auto download ' from https://permission.site/

This is regression issue broken in ‘M-65’ and will Soon inform the bisect info.

Using the per-revision bisect providing the bisect results,
Good Build: 65.0.3309.0
Bad Build: 65.0.3310.0

Thank You!

Comment 1 by shruti.j...@etouch.net, Jan 3 2018

Labels: hasbisect-per-revision RegressedIn-65 Target-65 FoundIn-65
Owner: jochen@chromium.org
Status: Assigned (was: Unconfirmed)
Kindly refer the Bisect-info:

You are probably looking for a change made after 526474 (known good), but no later than 526475 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/cbce1149c9ae08297b816effbf456c02f97df8db..f2d2fe87028de36a489f7db3f5fb28da2e9d9b2b

Suspect : https://chromium.googlesource.com/chromium/src/+/f2d2fe87028de36a489f7db3f5fb28da2e9d9b2b

@Jochen Eisinger: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thank You!
Expected.mp4
1017 KB View Download
Actual.mp4
432 KB View Download

Comment 2 by ranjitkan@chromium.org, Jan 3 2018

Labels: ReleaseBlock-Stable
Tagging with a blocker label, please undo if not the case.

Thanks.!

Comment 3 by jochen@chromium.org, Jan 3 2018 

this doesn't work in firefox either. The issue is that the website doesn't attach the <a> element to the DOM before clicking on it.

Created a pull request to fix this site: https://github.com/chromium/permission.site/pull/42
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/640b4e204bf8f07832bca2ef915ad06d06e65219

commit 640b4e204bf8f07832bca2ef915ad06d06e65219
Author: Jochen Eisinger <jochen@chromium.org>
Date: Thu Jan 04 14:25:29 2018

Don't block navigations to data urls that will result in downloads

BUG= 798676 
R=clamy@chromium.org

Change-Id: Ie0999280241dd4da438be6b6be792c5472c3c672
Reviewed-on: https://chromium-review.googlesource.com/849997
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526984}
[modify] https://crrev.com/640b4e204bf8f07832bca2ef915ad06d06e65219/content/browser/frame_host/data_url_navigation_throttle.cc
[modify] https://crrev.com/640b4e204bf8f07832bca2ef915ad06d06e65219/content/browser/frame_host/form_submission_throttle_browsertest.cc
[modify] https://crrev.com/640b4e204bf8f07832bca2ef915ad06d06e65219/content/browser/frame_host/interstitial_page_navigator_impl.cc
[modify] https://crrev.com/640b4e204bf8f07832bca2ef915ad06d06e65219/content/browser/frame_host/navigation_handle_impl.cc
[modify] https://crrev.com/640b4e204bf8f07832bca2ef915ad06d06e65219/content/browser/frame_host/navigation_handle_impl.h
[modify] https://crrev.com/640b4e204bf8f07832bca2ef915ad06d06e65219/content/browser/frame_host/navigation_handle_impl_unittest.cc
[modify] https://crrev.com/640b4e204bf8f07832bca2ef915ad06d06e65219/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/640b4e204bf8f07832bca2ef915ad06d06e65219/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/640b4e204bf8f07832bca2ef915ad06d06e65219/content/public/browser/navigation_handle.cc
[modify] https://crrev.com/640b4e204bf8f07832bca2ef915ad06d06e65219/third_party/WebKit/Source/core/loader/FrameLoader.cpp

Comment 5 by jochen@chromium.org, Jan 4 2018

Status: Fixed (was: Assigned)

Comment 6 by nyerramilli@chromium.org, Feb 2 2018

Labels: ET-MUM-Reported
►

Sign in to add a comment