Issue metadata
Sign in to add a comment
|
Chrome OS compile error: variable parseHtmlSubset is undeclared |
||||||||||||||||||||||
Issue descriptionChrome Version: r526600 OS: Chrome OS Compile failure: python ../../third_party/closure_compiler/js_binary.py --compiler ../../third_party/closure_compiler/compiler/compiler.jar --output gen/chrome/browser/resources/chromeos/login/offline_ad_login.js --deps gen/ui/webui/resources/js/load_time_data.js_library --sources ../../chrome/browser/resources/chromeos/login/offline_ad_login.js --flags extra_annotation_name=attribute extra_annotation_name=demo extra_annotation_name=element extra_annotation_name=group extra_annotation_name=hero extra_annotation_name=homepage extra_annotation_name=status extra_annotation_name=submodule source_map_format=V3 compilation_level=SIMPLE_OPTIMIZATIONS jscomp_error=accessControls jscomp_error=ambiguousFunctionDecl jscomp_error=checkTypes jscomp_error=checkVars jscomp_error=constantProperty jscomp_error=deprecated jscomp_error=externsValidation jscomp_error=globalThis jscomp_error=invalidCasts jscomp_error=missingProperties jscomp_error=missingReturn jscomp_error=nonStandardJsDocs jscomp_error=suspiciousCode jscomp_error=undefinedNames jscomp_error=undefinedVars jscomp_error=unknownDefines jscomp_error=uselessCode jscomp_error=visibility language_in=ECMASCRIPT6_STRICT language_out=ECMASCRIPT5_STRICT chrome_pass polymer_pass jscomp_off=duplicate --externs ../../third_party/closure_compiler/externs/polymer-1.0.js ../../ui/webui/resources/js/load_time_data.js:118: ERROR - variable parseHtmlSubset is undeclared return parseHtmlSubset('<b>' + rawString + '</b>', opts.tags, opts.attrs) ^^^^^^^^^^^^^^^ 1 error(s), 0 warning(s) Happened on r526552, then I synced to r526600 and still happening. Only affects CrOS build, not normal Linux build.
,
Jan 3 2018
It seems that on Chrome OS offline_ad_login.js depends upon load_time_data.js, which expects parseHtmlSubset to exist (from parse_html_subset.js), but load_time_data does not depend upon parse_html_subset.
It's an easy fix:
--- a/ui/webui/resources/js/BUILD.gn
+++ b/ui/webui/resources/js/BUILD.gn
@@ -56,6 +56,7 @@ js_library("i18n_behavior") {
js_library("load_time_data") {
deps = [
":assert",
+ ":parse_html_subset",
"//third_party/jstemplate:jstemplate",
]
}
Not sure how this is passing on the tree, but seems like an obvious problem. CL to fix: https://crrev.com/c/848592
,
Jan 3 2018
Note: This only affects the webui_closure_compile target (not the main "chrome" target).
,
Jan 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a7d45a117fd114d0271574a4dd8309dc7620cd9 commit 0a7d45a117fd114d0271574a4dd8309dc7620cd9 Author: Matt Giuca <mgiuca@chromium.org> Date: Wed Jan 03 06:53:16 2018 Fix Chrome OS compile. JS library load_time_data now properly depends upon parse_html_subset. Bug: 798657 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I70724a633dcf4e3088162693c9bae16fbf8d3468 Reviewed-on: https://chromium-review.googlesource.com/848592 Commit-Queue: Matt Giuca <mgiuca@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Reviewed-by: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#526640} [modify] https://crrev.com/0a7d45a117fd114d0271574a4dd8309dc7620cd9/ui/webui/resources/js/BUILD.gn
,
Jan 9 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mgiuca@chromium.org
, Jan 3 2018