New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 798653 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Bookmark manager displays incorrect message for unmodifiable folders

Reported by 93m4qau...@gmail.com, Jan 3 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.108 Safari/537.36

Steps to reproduce the problem:
1. Launch Chrome with a policy that does not allow adding bookmarks
2. Open a managed bookmarks folder in chrome://bookmarks.

What is the expected behavior?
Since bookmarking is not allowed on the managed folder, the bookmark manager should display "This folder is empty".

What went wrong?
Even though bookmarking is not allowed in unmodifiable folders (the bookmarks manager menu "Add new bookmark" option is grayed out), the bookmark manager still displays "To bookmark pages, click the star in the address bar", leading the user to think that bookmarking should be possible but for some reason doesn't work.

Did this work before? N/A 

Chrome version: 63.0.3239.108  Channel: stable
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: 

This seems like something that would be pretty easy to fix.
 
Labels: Needs-Triage-M63
Cc: dlei@google.com calamity@chromium.org
Components: -UI UI>Browser>Bookmarks
Labels: -Pri-2 Hotlist-GoodFirstBug Proj-MaterialDesign-WebUI OS-Chrome OS-Linux OS-Mac Pri-3
Status: Available (was: Unconfirmed)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70eaf83098872bfb2e9da2f1e369fb79d6a0196f

commit 70eaf83098872bfb2e9da2f1e369fb79d6a0196f
Author: Ayush Khandelwal <k.ayush@samsung.com>
Date: Fri Feb 23 04:09:11 2018

Empty bookmarks folder display message

* if list is empty and modifiable:
   "To bookmark pages, click the star in the address bar"

* if list is empty and unmodifiable:
   "This folder is empty"

Bug:  798653 

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1cd88758158a7c13abe938f4698180916d0e595a
Reviewed-on: https://chromium-review.googlesource.com/878421
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#538696}
[modify] https://crrev.com/70eaf83098872bfb2e9da2f1e369fb79d6a0196f/AUTHORS
[modify] https://crrev.com/70eaf83098872bfb2e9da2f1e369fb79d6a0196f/chrome/app/bookmarks_strings.grdp
[modify] https://crrev.com/70eaf83098872bfb2e9da2f1e369fb79d6a0196f/chrome/browser/resources/md_bookmarks/list.js
[modify] https://crrev.com/70eaf83098872bfb2e9da2f1e369fb79d6a0196f/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc

Status: Fixed (was: Available)
Failed to verify fix on latest Chromium development build 66.0.3354.0.

1. Downloaded the latest raw Chromium build from download-chromium.appspot.com.
2. Launched Chromium.
3. Switched into Guest mode.
4. Opened chrome://bookmarks.

Upon opening the bookmark manager in Guest mode on the latest Chromium build, "To bookmark pages, click the star in the address bar" is still seen.
Summary: Bookmark manager displays incorrect message for unmodifiable folders (was: Guest mode bookmarks manager still displays "To bookmark pages, click the star in the address bar" even though bookmarking is not allowed)
This issue has been repurposed for unmodifiable folders in general. The bookmark manager should not be accessible in guest mode which is tracked in  Issue 813451 .
Checked the issue on chrome version 66.0.3355.0 using Windows 10, Ubuntu 14.04 and Mac 10.13.1. 

The issue is still seen, i.e., after navigating to chrome://bookmarks in guest mode we are able to see "To bookmark pages, click the star in the address bar". 
Hence we aren't adding any verified labels.

Thanks!
I understand that completely eliminating the bookmark manager in Guest mode is a different bug, and that this bug is for changing the message for unmodifiable folders. Since this issue doesn't appear to be fixed (as it can't be verified per comment #5 and comment #7), could you reopen this bug and look into why the fix isn't working?
This bug is fixed for managed folders, but not guest mode. Guest mode is not going to be fixed here, it's just going to be disabled entirely. I'll change the description to match.
Description: Show this description
Labels: Needs-Feedback
@calamity: As per comment#9 it is understood that the issue is fixed for managed folders, but not guest mode. We have checked the issue on latest canary 66.0.3356.0 by signing into chrome in chrome://settings then clicked on a bookmark folder in Chrome://bookmarks, we observed similar behaviour on the versions with and without fix. Attaching the screenshot of the same. Could you please let us know if anything missed from our end and help us in verifying the fix.

Thanks!
Bookmark CL Verif.png
150 KB View Download
Add a folder in managed mode that has no bookmarks in it. The message will be different.
<removing Needs-Feedback>
<reattempting to remove Needs-Feedback>
Labels: -Needs-Feedback
Since this bug has been repurposed, could you provide verification steps if possible?
The description is already updated.

Sign in to add a comment