New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 798635 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug
Team-Security-UX



Sign in to add a comment

Page info desktop - cookies entry appears to be elided despite there being enough space to show all text.

Project Member Reported by patricia...@chromium.org, Jan 3 2018

Issue description

Chrome Version       : 65.0.3310.0
OS Version: Linux
URLs (if applicable) : All websites show this, including about:blank
Other browsers tested: N/A (Chrome specific)

What steps will reproduce the problem?
1. Navigate to about:blank
2. Click the info icon next to the omnibox
3. Observe the "Cookies (0 in use..." button.

What is the expected result?
The button should read "Cookies (0 in use)".

What happens instead of that?
It shows an ellipsis at the end as if the text has been elided due to lack of space. But the only missing character is a end parens, so there is definitely enough space (see screenshot). 
 
Screenshot from 2018-01-03 13-04-12.png
10.7 KB View Download
Note this also causes PageInfoBubbleViewTest.UpdatingSiteDataRetainsLayout in the unit_tests target to fail.
Cc: krajshree@chromium.org ajha@chromium.org sc00335...@techmahindra.com brajkumar@chromium.org ligim...@chromium.org
 Issue 796821  has been merged into this issue.
Cc: patricia...@chromium.org
Components: UI>Localization
Labels: -Pri-3 Pri-2
Owner: ----
Status: Untriaged (was: Started)
r525047 (https://chromium.googlesource.com/chromium/src/+/7a64aa11ac3dbb42be7bb8b07840e416006f1f1f) contains a translation error for en_GB. Also see https://cs.chromium.org/chromium/src/components/strings/components_strings_en-GB.xtb?rcl=d36f4e564c7ad8e4e5d9033f2791052c29846020&l=633

[Language]
en_GB

[Version number]
Since Chrome 65.0.3300.0

[OS details]
Ubuntu 14.04, Windows 10, Mac 10.12

[Where is the poor translation?]
In the Page Info Bubble. To see it, follow the instructions in the bug description under "What steps will reproduce the problem?".

[attach any screenshots below]
See screenshot attached in the bug description.

The translation should be 
<translation id="5571347317547569613">({NUM_COOKIES,plural, =1{One in use}other{# in use}})</translation>

instead of
<translation id="5571347317547569613">({NUM_COOKIES,plural, =1{One in use}other{# in use}}...</translation>
Cc: jungshik@google.com js...@chromium.org
Owner: js...@chromium.org
Status: Assigned (was: Untriaged)
Assigning to jshin@, could you ptal and reassign if needed. Thank you.
Labels: M-65
Pls note r525047 is auto generated CL for translation extraction/dump.

Comment 7 by js...@chromium.org, Jan 3 2018

I updated the string internally.

Are you planning to import strings once more or do you need to fix the string in the chromium repo?  

Comment 8 by js...@chromium.org, Jan 5 2018

govind@:  If this string has to be manually fixed in the chromium git repo, let me know. 

jshin@, sorry for the delay in reply as I'm OOO till Jan 10th. If you can fix the string manually in the chromium git repo will be great. Thank you.
Thanks. I'll do, then. 
Status: Fixed (was: Assigned)
Thanks jshin@ for fixing this! Looks good now :)

Comment 12 by js...@chromium.org, Jan 10 2018

It's fixed by importing updated strings on January 8. 


Sign in to add a comment