blocking bug for Rich Entity Suggest
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ccc1e6b9b43ed4d11d6a41c044be9058055412c commit 1ccc1e6b9b43ed4d11d6a41c044be9058055412c Author: Dave Schuyler <dschuyler@chromium.org> Date: Tue Mar 27 00:42:18 2018 [Omnibox] Show answers in rich layout This Cl displays AiS (Answers in Suggest) differently iff OmniboxRichEntitySuggestions is enabled. This is a step toward presenting rich entity suggestions. Bug: 798631 Change-Id: I0ef87d9bdffdb392f32662a4f13a3721e2826d47 Reviewed-on: https://chromium-review.googlesource.com/981459 Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#545907} [modify] https://crrev.com/1ccc1e6b9b43ed4d11d6a41c044be9058055412c/chrome/browser/ui/views/omnibox/omnibox_result_view.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db91e01afac24625e7644e5939b81ee0adc91375 commit db91e01afac24625e7644e5939b81ee0adc91375 Author: Dave Schuyler <dschuyler@chromium.org> Date: Fri Apr 13 03:42:45 2018 [Omnibox] Parse and track image url and dominant color This CL will parse the rich entity image dominant color and the image URL. The data is not yet used on the client, that will happen in a later CL. (Similar to the prior CLs which moved the values from the CompleteServer to GWS; then from GWS to Chrome; now this moves the values from the received JSON data to closer to the GUI code). TBR=mpearson@chromium.org Bug: 798631 Change-Id: I1d4a31e4b149669c058340ad856ebf89f0663147 Reviewed-on: https://chromium-review.googlesource.com/994129 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#550500} [modify] https://crrev.com/db91e01afac24625e7644e5939b81ee0adc91375/chrome/browser/autocomplete/search_provider_unittest.cc [modify] https://crrev.com/db91e01afac24625e7644e5939b81ee0adc91375/components/omnibox/browser/autocomplete_match.cc [modify] https://crrev.com/db91e01afac24625e7644e5939b81ee0adc91375/components/omnibox/browser/autocomplete_match.h [modify] https://crrev.com/db91e01afac24625e7644e5939b81ee0adc91375/components/omnibox/browser/base_search_provider.cc [modify] https://crrev.com/db91e01afac24625e7644e5939b81ee0adc91375/components/omnibox/browser/base_search_provider_unittest.cc [modify] https://crrev.com/db91e01afac24625e7644e5939b81ee0adc91375/components/omnibox/browser/search_provider.cc [modify] https://crrev.com/db91e01afac24625e7644e5939b81ee0adc91375/components/omnibox/browser/search_suggestion_parser.cc [modify] https://crrev.com/db91e01afac24625e7644e5939b81ee0adc91375/components/omnibox/browser/search_suggestion_parser.h [modify] https://crrev.com/db91e01afac24625e7644e5939b81ee0adc91375/components/omnibox/browser/search_suggestion_parser_unittest.cc
Reposting comment on this bug, as my comment on the changelist was overlooked. --- You TBRed this to me. Please tell me what part of it you want/need me to review. What has been already reviewed? ---
#6 Sorry about that. The TBR was for chrome/browser/autocomplete/search_provider_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c7affc0317e0e19db6af29707cf68c012e17e145 commit c7affc0317e0e19db6af29707cf68c012e17e145 Author: Dave Schuyler <dschuyler@chromium.org> Date: Thu Apr 26 20:43:37 2018 [Omnibox] Fetch and draw entity images This CL will fetch the entity image_url (if present) and draw the image in the result. While the image is being downloaded, a placeholder dot consisting of the image's dominant color is shown. Bug: 798631 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id11f362a0f9140ba7fd525d860fe76dda817e94a Reviewed-on: https://chromium-review.googlesource.com/1016127 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#554138} [modify] https://crrev.com/c7affc0317e0e19db6af29707cf68c012e17e145/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm [modify] https://crrev.com/c7affc0317e0e19db6af29707cf68c012e17e145/chrome/browser/ui/omnibox/chrome_omnibox_client.cc [modify] https://crrev.com/c7affc0317e0e19db6af29707cf68c012e17e145/chrome/browser/ui/omnibox/chrome_omnibox_client.h [modify] https://crrev.com/c7affc0317e0e19db6af29707cf68c012e17e145/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc [modify] https://crrev.com/c7affc0317e0e19db6af29707cf68c012e17e145/chrome/browser/ui/views/omnibox/omnibox_result_view.cc [modify] https://crrev.com/c7affc0317e0e19db6af29707cf68c012e17e145/components/omnibox/browser/autocomplete_match.cc [modify] https://crrev.com/c7affc0317e0e19db6af29707cf68c012e17e145/components/omnibox/browser/autocomplete_match.h [modify] https://crrev.com/c7affc0317e0e19db6af29707cf68c012e17e145/components/omnibox/browser/omnibox_client.h [modify] https://crrev.com/c7affc0317e0e19db6af29707cf68c012e17e145/components/omnibox/browser/omnibox_controller.cc [modify] https://crrev.com/c7affc0317e0e19db6af29707cf68c012e17e145/components/omnibox/browser/omnibox_controller.h [modify] https://crrev.com/c7affc0317e0e19db6af29707cf68c012e17e145/components/omnibox/browser/omnibox_popup_model.cc [modify] https://crrev.com/c7affc0317e0e19db6af29707cf68c012e17e145/components/omnibox/browser/omnibox_popup_model.h [modify] https://crrev.com/c7affc0317e0e19db6af29707cf68c012e17e145/ios/chrome/browser/ui/omnibox/chrome_omnibox_client_ios.h [modify] https://crrev.com/c7affc0317e0e19db6af29707cf68c012e17e145/ios/chrome/browser/ui/omnibox/chrome_omnibox_client_ios.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db64731f00ebeb144992c8cf0ccf52f19acbd900 commit db64731f00ebeb144992c8cf0ccf52f19acbd900 Author: Dave Schuyler <dschuyler@chromium.org> Date: Tue May 08 18:41:52 2018 [Omnibox] make rich suggestion images 32px; make placeholders round rect This Cl adjusts the size of rich suggestion images (and placeholders). The placeholders are also now rounded rectangles. The images (non-placeholder) are not rounded rectangles because I'd like to look into doing that processing on the server. Bug: 798631 Change-Id: I656c6f850db251f8f5ee81d2e95dd5f6b95aa32f Reviewed-on: https://chromium-review.googlesource.com/1048609 Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#556897} [modify] https://crrev.com/db64731f00ebeb144992c8cf0ccf52f19acbd900/chrome/browser/ui/views/omnibox/omnibox_match_cell_view.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d99c328dcb55ac51f4e6a678eda34a2ba55592a3 commit d99c328dcb55ac51f4e6a678eda34a2ba55592a3 Author: Dave Schuyler <dschuyler@chromium.org> Date: Wed Jun 13 23:41:06 2018 [Omnibox] center rich layout images; change entity images to 32px This CL changes the rich layout images to be centered in a box to the left of the text lines. This allows for answer images and entity images to be different sizes without doing a lot of less readable math. Bug: 798631 Change-Id: I882305ca09353266f02115446f481bff00b00e12 Reviewed-on: https://chromium-review.googlesource.com/1094263 Reviewed-by: Kevin Bailey <krb@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#567048} [modify] https://crrev.com/d99c328dcb55ac51f4e6a678eda34a2ba55592a3/chrome/browser/ui/views/omnibox/omnibox_match_cell_view.cc
Comment 1 by dschuyler@chromium.org
, Jan 3 2018Labels: -Type-Bug Type-Feature