Chrome histogram "Security.TreatInsecureOriginAsSecure" is not reported |
||
Issue descriptionChrome histogram "Security.TreatInsecureOriginAsSecure" is registered before StatisticsRecorder is even initialized. As a consequence, it is "lost" and doesn't appear in chrome://histograms. For that reason, it is probably not uploaded as UMA metrics either.
,
Jan 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3226102363fa5a99183cfd891dd614e89896332 commit e3226102363fa5a99183cfd891dd614e89896332 Author: François Degros <fdegros@chromium.org> Date: Mon Jan 08 01:18:30 2018 StatisticsRecorder doesn't need to be explicitly initialized. StatisticsRecorder automatically and lazily initializes itself when necessary. This simplifies its API and makes it less tricky to use. It removes pitfalls where some methods were a no-op or would crash when StatisticsRecorder wasn't initialized whereas the same methods had side effects when StatisticsRecorder was initialized. Now, all methods always act as advertised. This also means that histograms like Security.TreatInsecureOriginAsSecure that used to be registered before StatisticsRecorder was initialized are not lost anymore and are now correctly recorded. Added comments. Change-Id: Iac359538f0dba6169a6fc3f7f3b71b8e8d682944 Bug: 798603 Reviewed-on: https://chromium-review.googlesource.com/846586 Commit-Queue: François Degros <fdegros@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#527553} [modify] https://crrev.com/e3226102363fa5a99183cfd891dd614e89896332/base/metrics/statistics_recorder.cc [modify] https://crrev.com/e3226102363fa5a99183cfd891dd614e89896332/base/metrics/statistics_recorder.h [modify] https://crrev.com/e3226102363fa5a99183cfd891dd614e89896332/base/metrics/statistics_recorder_unittest.cc
,
Jan 9 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by fdegros@chromium.org
, Jan 3 2018