References don't follow std::make_unique |
||
Issue descriptionNow that we like using std::make_unique (or base::MakeUnique) everywhere, code search seems unable to find constructors called via a std::make_unique instantiation. Steps to reproduce: 1. Go to https://cs.chromium.org/chromium/src/chrome/browser/ui/omnibox/chrome_omnibox_navigation_observer.h?type=cs&q=ChromeOmniboxNavigationObserver&l=58 2. Click the constructor. 3. Skim through references. A bunch of constructor calls in tests show up, and src/buildtools/third_party/libc++/trunk/include/memory, which is std::make_unique, but it does not look for callers for that particular std::make_unique instantiation, notably this one: https://cs.chromium.org/chromium/src/chrome/browser/ui/omnibox/chrome_omnibox_client.cc?rcl=5a7ad6df8624441a683d1be0e508f73e89914d8a&l=129 I feel like this used to work? Was there some change in backend recently? Or am I just making this up?
,
May 14 2018
This looks like it's working fine now, can't reproduce. Please re-open if I've misunderstood this bug. |
||
►
Sign in to add a comment |
||
Comment 1 by aga...@chromium.org
, Jan 3 2018