New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 798600 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

References don't follow std::make_unique

Project Member Reported by davidben@chromium.org, Jan 2 2018

Issue description

Now that we like using std::make_unique (or base::MakeUnique) everywhere, code search seems unable to find constructors called via a std::make_unique instantiation.

Steps to reproduce:
1. Go to https://cs.chromium.org/chromium/src/chrome/browser/ui/omnibox/chrome_omnibox_navigation_observer.h?type=cs&q=ChromeOmniboxNavigationObserver&l=58
2. Click the constructor.
3. Skim through references.

A bunch of constructor calls in tests show up, and src/buildtools/third_party/libc++/trunk/include/memory, which is std::make_unique, but it does not look for callers for that particular std::make_unique instantiation, notably this one:

https://cs.chromium.org/chromium/src/chrome/browser/ui/omnibox/chrome_omnibox_client.cc?rcl=5a7ad6df8624441a683d1be0e508f73e89914d8a&l=129

I feel like this used to work? Was there some change in backend recently? Or am I just making this up?
 
I don't think codesearch has ever shown second-order callers. There's certainly a chance that it did -- there was a backend change (from Grok to Kythe, if you feel like looking those up internally) -- but I don't even know how that would work.

I'm including you on a thread to see if someone more familiar with those systems knows the answer here.

Comment 2 by j...@chromium.org, May 14 2018

Status: WontFix (was: Untriaged)
This looks like it's working fine now, can't reproduce. Please re-open if I've misunderstood this bug.

Sign in to add a comment