BuildTime.InThePast fails on Fuchsia/x86-64 FYI bot |
||||||
Issue descriptionThis test started failing on our bot at around 12:37 PST today, with output like: [00000.761] 01752.01800> [ RUN ] BuildTime.InThePast [00000.761] 01752.01800> ../../base/build_time_unittest.cc:29: Failure [00000.761] 01752.01800> Expected: (base::GetBuildTime()) < (base::Time::Now()), actual: 2017-12-03 05:00:00.000 UTC vs 2016-01-01 00:00:00.043 UTC [00000.761] 01752.01800> ../../base/build_time_unittest.cc:30: Failure [00000.761] 01752.01800> Expected: (base::GetBuildTime()) < (base::Time::NowFromSystemTime()), actual: 2017-12-03 05:00:00.000 UTC vs 2016-01-01 00:00:00.043 UTC [00000.761] 01752.01800> [ FAILED ] BuildTime.InThePast (1 ms) This repros for me locally, as well as on the bot, and rolling-back to a build that passed the bot does not resolve it, suggesting it's a failure specific to the time/date, rather than to a particular build. The issue also appears to be confined to the x86-64 build.
,
Jan 2 2018
This is a limitation of the prototype RTC driver, addressed by https://fuchsia-review.googlesource.com/c/zircon/+/104220 - an SDK roll will "fix" it.
,
Jan 3 2018
Issue 798253 has been merged into this issue.
,
Jan 3 2018
Note that issue 798253 tracks disabling of some SSL tests due to this issue; remember to re-enable them once we have a working SDK boot image.
,
Jan 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/61fdf783baf8b1e83f21d4f09241f8c3239876d5 commit 61fdf783baf8b1e83f21d4f09241f8c3239876d5 Author: Wez <wez@chromium.org> Date: Thu Jan 04 01:20:43 2018 Roll Fuchsia SDK to 16f4a04b24e5affe5e3e4a43016f667894a54e63. This includes a fix for the Real-Time Clock driver for x86-64. Bug: 798578 , 707030 Change-Id: I633c221cb8f65f16cb683658665656d273ba8423 Reviewed-on: https://chromium-review.googlesource.com/849613 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#526887} [modify] https://crrev.com/61fdf783baf8b1e83f21d4f09241f8c3239876d5/DEPS
,
Jan 4 2018
,
Jan 8 2018
Can the SSL tests be re-enabled? Otherwise, that bug should be un-duped from this one.
,
Jan 8 2018
Re #7: Thanks for the reminder - have sent a revert of your SSL-tests disabling patch. :)
,
Jan 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0e5c91ded7619a987ae412256c00dc1a92a49fe commit e0e5c91ded7619a987ae412256c00dc1a92a49fe Author: Wez <wez@chromium.org> Date: Tue Jan 09 00:08:47 2018 Revert "Disable some SSL tests on Fuchsia" This reverts commit 0a57f7db67a683e0811a107c9bfb7c8aebddb2b4. Reason for revert: These were disabled to work around an RTC driver bug in Fuchsia/x64, which has since been resolved. Original change's description: > Disable some SSL tests on Fuchsia > > Bug: 798253 > TBR: kinuko > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > Change-Id: I98878c3452c00dccaecfd1c73223176f474d782c > Reviewed-on: https://chromium-review.googlesource.com/847434 > Reviewed-by: Max Morin <maxmorin@chromium.org> > Commit-Queue: Max Morin <maxmorin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#526461} TBR=kinuko@chromium.org,maxmorin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 798253 , 798578 Change-Id: Ic06c08e6936ee13f1492001b0bb288a540a4db0d Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/854512 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#527820} [modify] https://crrev.com/e0e5c91ded7619a987ae412256c00dc1a92a49fe/content/network/url_loader_unittest.cc
,
Jan 9 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by w...@chromium.org
, Jan 2 2018