New issue
Advanced search Search tips

Issue 798569 link

Starred by 1 user
Status: Fixed
Owner:
steve...@chromium.org
Closed: May 2018
Cc:
derat@chromium.org
xiy...@chromium.org
jamescook@chromium.org
steve...@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 796007



Sign in to add a comment

Cleanup up chromeos related folders in chrome/browser

Project Member Reported by sky@chromium.org, Jan 2 2018 
To avoid having a big ball of code with lots of inter dependencies we have tried to avoid code in chrome/browser depending upon platform specific UI code. This is why c/b/DEPS has a -chrome/browser/ui/views. ChromeOS related code in the chrome directory currently spans the following directories:

chrome/browser/chromeos
chrome/browser/ui/ash
chrome/browser/ui/views/ash

I propose the following structure:

c/b/chromeos: non-ui related code. This should NOT depend upon anything in c/b/ui (DEPS should enforce this).

c/b/ui/chromeos: c/b/ui/ash and c/b/ui/views/ash move here. This would additionally contain any ui specific code that is in c/b/chromeos.

Comment 1 by steve...@chromium.org, Jan 2 2018

Components: UI>Shell
Labels: Proj-Mustash-Mash
Owner: steve...@chromium.org
Status: Assigned (was: Untriaged)
We should definitely merge c/b/ui/views/ash -> c/b/ui/ash; there is very little in there and ash implies views.

Since there is no c/b/ui/chomeos, I would just as soon not rename c/b/ui/ash, but won't object any more than that; having "ash" as a synonym for "chromeos UI" still seems convenient to me.

I am also in full support of fixing the c/b/chromeos deps violations and will start moving forward on that since it seems pretty non objectionable.

Comment 2 by sky@chromium.org, Jan 2 2018 

For symmetry it's nice that if we have c/b/chromeos, we also have c/b/ui/chromeos. But we do have the top-level ash directory, so I certainly see the argument for having c/b/ui/ash rather than c/b/ui/chromeos.

Comment 3 by jamescook@chromium.org, Jan 3 2018 

Moving UI code from chrome/browser/chromeos into c/b/ui/<anywhere> will result in a tremendous amount of code churn for (IMHO) little benefit. There are tens of thousands of lines of cros-specific UI code in c/b/chromeos (e.g. all of login).

Frankly, I have considered going the other way, just accepting that c/b/chromeos has UI code in it and moving all of c/b/ui/ash and c/b/ui/views/ash into c/b/chromeos.

Can you provide a couple of specific examples of files/subdirs of c/b/chromeos that you think should move?

Maybe we should chat briefly about this on VC, or one of you guys could write a brief ddoc with examples?

Comment 4 by jamescook@chromium.org, Jan 3 2018 

I chatted with sky@ in person and he has convinced me of his worldview. The plan in the original description SGTM. I prefer c/b/ui/chromeos to c/b/ui/ash (since direct access into //ash should decrease with mustash) but I don't feel that strongly.

For reference:
* c/b/ui/ash - 23K LoC
* c/b/chromeos - 260K LoC, unclear how much is UI

Also, if we do decide to move c/b/ui/ash elsewhere, let's take the opportunity to rename c/b/ui/ash/launcher to c/b/ui/ash/shelf.

Comment 5 by steve...@chromium.org, Jan 4 2018

Status: Started (was: Assigned)
I think I disovered why we have c/b/ui/views/ash:

c/b/ui/DEPS has:
  "-chrome/browser/ui/views",

So, currently we put ash code with c/b/ui/views dependencies in c/b/ui/views/ash.

We could:
1. Add "+chrome/browser/ui/views" to c/b/ui/ash/DEPS like we do for e.g. c/b/ui/aura/DEPS.
2. Create c/b/ui/ash/views and add the DEPS exception there.
3. Leave the code as-is.

Thoughts? Other suggestions?

Comment 6 by jamescook@chromium.org, Jan 5 2018 

Yeah, I think the ash-only TabScrubber needs to access the views tab strip.

I'm fine with +c/b/ui/views in c/b/ui/ash, or just + the necessary tab strip files for tab scrubber.

Comment 7 by sky@chromium.org, Jan 5 2018 

I'm ok with c/b/ui/ash (or c/b/ui/chromeos) having a + for c/b/ui/views.
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81d07beb47cbb80858ccfed60e824317a390e602

commit 81d07beb47cbb80858ccfed60e824317a390e602
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Jan 08 22:13:02 2018

Eliminate chrome/browser/ui/views/ash

Bug:  798569 
Change-Id: Ic53607c53d7548902781616a43cadad30200e8a8
Reviewed-on: https://chromium-review.googlesource.com/852861
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527779}
[modify] https://crrev.com/81d07beb47cbb80858ccfed60e824317a390e602/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/81d07beb47cbb80858ccfed60e824317a390e602/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/81d07beb47cbb80858ccfed60e824317a390e602/chrome/browser/ui/ash/DEPS
[rename] https://crrev.com/81d07beb47cbb80858ccfed60e824317a390e602/chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.cc
[rename] https://crrev.com/81d07beb47cbb80858ccfed60e824317a390e602/chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.h
[rename] https://crrev.com/81d07beb47cbb80858ccfed60e824317a390e602/chrome/browser/ui/ash/tab_scrubber.cc
[rename] https://crrev.com/81d07beb47cbb80858ccfed60e824317a390e602/chrome/browser/ui/ash/tab_scrubber.h
[rename] https://crrev.com/81d07beb47cbb80858ccfed60e824317a390e602/chrome/browser/ui/ash/tab_scrubber_browsertest.cc
[rename] https://crrev.com/81d07beb47cbb80858ccfed60e824317a390e602/chrome/browser/ui/ash/time_to_first_present_recorder_browsertest.cc
[delete] https://crrev.com/7851ea3411dd04c74549373df930b4688576218e/chrome/browser/ui/views/ash/OWNERS
[modify] https://crrev.com/81d07beb47cbb80858ccfed60e824317a390e602/chrome/test/BUILD.gn

Comment 9 by steve...@chromium.org, Jan 9 2018 

There are 178 files in src/chrome/browser/ui/ash.

The more refactoring I do, the less excited I am about renaming c/b/ui/ash -> c/b/ui/chromeos. Here are my reasons:

1. "Ash" at this point is roughly synonymous with "Chrome OS UI" and is a whole lot less wordy than "Chrome OS UI".

2. We have src/chromeos and src/ash. With the recent re-factoring, we are pretty close to:
* c/b/chromeos = code dependent on src/chromeos or otherwise specific to Chrome OS but not
  generally UI related (and specifically not Ash related).
* c/b/ui/ash = code supporting src/ash

I am planning to close this issue once my remaining CL moving Ash related inititalization to ChromeBrowserMainExtraPartsAsh: https://chromium-review.googlesource.com/c/chromium/src/+/857322

Comment 10 by jamescook@chromium.org, Jan 10 2018 

I'm OK with that. sky?

Comment 11 by sky@chromium.org, Jan 10 2018 

I'm fine closing out.
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbe837495557fb6e2fab193cef65634a179eeb04

commit dbe837495557fb6e2fab193cef65634a179eeb04
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Thu Jan 11 19:22:11 2018

Move network ui from c/b/chromeos to c/b/ui/ash

This primarily moves some UI focused networking files from
c/b/chromeos to c/b/ui/ash.

It also moves the UI classes that were owned by
ChromeBrowserMainChromeOS to ChromeBrowserMainExtraPartsAsh.

Bug:  798569 
For header rename in browser_prefs.cc:
TBR=bauerb@chromium.org

Change-Id: Ia6275766b1a31afdb26404aeee544acad0dde1b9
Reviewed-on: https://chromium-review.googlesource.com/852823
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528705}
[modify] https://crrev.com/dbe837495557fb6e2fab193cef65634a179eeb04/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/dbe837495557fb6e2fab193cef65634a179eeb04/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/dbe837495557fb6e2fab193cef65634a179eeb04/chrome/browser/chromeos/chrome_browser_main_chromeos.h
[modify] https://crrev.com/dbe837495557fb6e2fab193cef65634a179eeb04/chrome/browser/chromeos/net/DEPS
[modify] https://crrev.com/dbe837495557fb6e2fab193cef65634a179eeb04/chrome/browser/chromeos/options/vpn_config_view.cc
[modify] https://crrev.com/dbe837495557fb6e2fab193cef65634a179eeb04/chrome/browser/chromeos/options/wifi_config_view.cc
[modify] https://crrev.com/dbe837495557fb6e2fab193cef65634a179eeb04/chrome/browser/chromeos/options/wimax_config_view.cc
[modify] https://crrev.com/dbe837495557fb6e2fab193cef65634a179eeb04/chrome/browser/chromeos/tether/tether_service.cc
[modify] https://crrev.com/dbe837495557fb6e2fab193cef65634a179eeb04/chrome/browser/chromeos/tether/tether_service_unittest.cc
[modify] https://crrev.com/dbe837495557fb6e2fab193cef65634a179eeb04/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/dbe837495557fb6e2fab193cef65634a179eeb04/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/dbe837495557fb6e2fab193cef65634a179eeb04/chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.cc
[modify] https://crrev.com/dbe837495557fb6e2fab193cef65634a179eeb04/chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.h
[modify] https://crrev.com/dbe837495557fb6e2fab193cef65634a179eeb04/chrome/browser/ui/ash/chrome_shell_delegate.cc
[rename] https://crrev.com/dbe837495557fb6e2fab193cef65634a179eeb04/chrome/browser/ui/ash/network/data_promo_notification.cc
[rename] https://crrev.com/dbe837495557fb6e2fab193cef65634a179eeb04/chrome/browser/ui/ash/network/data_promo_notification.h
[rename] https://crrev.com/dbe837495557fb6e2fab193cef65634a179eeb04/chrome/browser/ui/ash/network/data_promo_notification_unittest.cc
[rename] https://crrev.com/dbe837495557fb6e2fab193cef65634a179eeb04/chrome/browser/ui/ash/network/enrollment_dialog_view.cc
[rename] https://crrev.com/dbe837495557fb6e2fab193cef65634a179eeb04/chrome/browser/ui/ash/network/enrollment_dialog_view.h
[rename] https://crrev.com/dbe837495557fb6e2fab193cef65634a179eeb04/chrome/browser/ui/ash/network/network_connect_delegate_chromeos.cc
[rename] https://crrev.com/dbe837495557fb6e2fab193cef65634a179eeb04/chrome/browser/ui/ash/network/network_connect_delegate_chromeos.h
[rename] https://crrev.com/dbe837495557fb6e2fab193cef65634a179eeb04/chrome/browser/ui/ash/network/network_state_notifier.cc
[rename] https://crrev.com/dbe837495557fb6e2fab193cef65634a179eeb04/chrome/browser/ui/ash/network/network_state_notifier.h
[rename] https://crrev.com/dbe837495557fb6e2fab193cef65634a179eeb04/chrome/browser/ui/ash/network/network_state_notifier_unittest.cc
[rename] https://crrev.com/dbe837495557fb6e2fab193cef65634a179eeb04/chrome/browser/ui/ash/network/networking_config_delegate_chromeos.cc
[rename] https://crrev.com/dbe837495557fb6e2fab193cef65634a179eeb04/chrome/browser/ui/ash/network/networking_config_delegate_chromeos.h
[rename] https://crrev.com/dbe837495557fb6e2fab193cef65634a179eeb04/chrome/browser/ui/ash/network/networking_config_delegate_chromeos_browsertest.cc
[rename] https://crrev.com/dbe837495557fb6e2fab193cef65634a179eeb04/chrome/browser/ui/ash/network/tether_notification_presenter.cc
[rename] https://crrev.com/dbe837495557fb6e2fab193cef65634a179eeb04/chrome/browser/ui/ash/network/tether_notification_presenter.h
[rename] https://crrev.com/dbe837495557fb6e2fab193cef65634a179eeb04/chrome/browser/ui/ash/network/tether_notification_presenter_unittest.cc
[modify] https://crrev.com/dbe837495557fb6e2fab193cef65634a179eeb04/chrome/test/BUILD.gn

Comment 13 by steve...@chromium.org, Jan 11 2018 

Current Progress:

* chrome/browser/ui/views/ash was moved to chrome/browser/ui/ash/
* chrome/browser/ui/ash renaims 'ash' at least for now
  Justification: The code is specific to src/ash.
* Some UI specific code was moved from c/b/chromeos -> c/b/ui/ash.

Still TODO:
* Add README.md files to c/b/chromeos and c/b/ui/ash
* Move (some) remaining UI specific files from c/b/chromeos -> c/b/ui/ash

Comment 14 by steve...@chromium.org, Feb 12 2018

Labels: -Pri-3 M-66 Pri-2

Comment 15 by steve...@chromium.org, Mar 13 2018

Labels: -M-66 M-67

Comment 16 by jamescook@chromium.org, Apr 19 2018

Components: Internals>Services>Ash
Labels: -Proj-Mustash-Mash
Project Member

Comment 17 by bugdroid1@chromium.org, Apr 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8db2b8aa028223a21f7bd71f372a6ff2640d160f

commit 8db2b8aa028223a21f7bd71f372a6ff2640d160f
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Sat Apr 21 02:15:42 2018

Separate NetworkPortalNotificationController from NetworkPortalDetectorImpl

NetworkPortalNotificationController is UI code and belongs in
chrome/browser/ui/ash (move will take place in a follow-up).

For renamed API call from auto_enrollment_check_screen.cc:
TBR=emaxx@chromium.org

Bug:  798569 
Change-Id: I3a89d980c0adc4d05a339226afae534f40e2b0a1
Reviewed-on: https://chromium-review.googlesource.com/1013125
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Qiang Xu <warx@google.com>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552550}
[modify] https://crrev.com/8db2b8aa028223a21f7bd71f372a6ff2640d160f/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/8db2b8aa028223a21f7bd71f372a6ff2640d160f/chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc
[modify] https://crrev.com/8db2b8aa028223a21f7bd71f372a6ff2640d160f/chrome/browser/chromeos/login/lock/screen_locker.cc
[modify] https://crrev.com/8db2b8aa028223a21f7bd71f372a6ff2640d160f/chrome/browser/chromeos/login/screens/update_screen.cc
[modify] https://crrev.com/8db2b8aa028223a21f7bd71f372a6ff2640d160f/chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc
[modify] https://crrev.com/8db2b8aa028223a21f7bd71f372a6ff2640d160f/chrome/browser/chromeos/net/network_portal_detector_impl.cc
[modify] https://crrev.com/8db2b8aa028223a21f7bd71f372a6ff2640d160f/chrome/browser/chromeos/net/network_portal_detector_impl.h
[modify] https://crrev.com/8db2b8aa028223a21f7bd71f372a6ff2640d160f/chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc
[modify] https://crrev.com/8db2b8aa028223a21f7bd71f372a6ff2640d160f/chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc
[modify] https://crrev.com/8db2b8aa028223a21f7bd71f372a6ff2640d160f/chrome/browser/chromeos/net/network_portal_detector_test_impl.cc
[modify] https://crrev.com/8db2b8aa028223a21f7bd71f372a6ff2640d160f/chrome/browser/chromeos/net/network_portal_detector_test_impl.h
[modify] https://crrev.com/8db2b8aa028223a21f7bd71f372a6ff2640d160f/chrome/browser/chromeos/net/network_portal_notification_controller.cc
[modify] https://crrev.com/8db2b8aa028223a21f7bd71f372a6ff2640d160f/chrome/browser/chromeos/net/network_portal_notification_controller.h
[modify] https://crrev.com/8db2b8aa028223a21f7bd71f372a6ff2640d160f/chrome/browser/extensions/api/networking_config_chromeos_apitest_chromeos.cc
[modify] https://crrev.com/8db2b8aa028223a21f7bd71f372a6ff2640d160f/chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.cc
[modify] https://crrev.com/8db2b8aa028223a21f7bd71f372a6ff2640d160f/chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.h
[modify] https://crrev.com/8db2b8aa028223a21f7bd71f372a6ff2640d160f/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
[modify] https://crrev.com/8db2b8aa028223a21f7bd71f372a6ff2640d160f/chromeos/network/portal_detector/mock_network_portal_detector.h
[modify] https://crrev.com/8db2b8aa028223a21f7bd71f372a6ff2640d160f/chromeos/network/portal_detector/network_portal_detector.h
[modify] https://crrev.com/8db2b8aa028223a21f7bd71f372a6ff2640d160f/chromeos/network/portal_detector/network_portal_detector_stub.cc
[modify] https://crrev.com/8db2b8aa028223a21f7bd71f372a6ff2640d160f/chromeos/network/portal_detector/network_portal_detector_stub.h
Project Member

Comment 18 by bugdroid1@chromium.org, Apr 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e9181c91cd5c3b3d5b40972747276ef17a02d5d

commit 4e9181c91cd5c3b3d5b40972747276ef17a02d5d
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Apr 27 00:04:33 2018

Add README.md for c/b/chromeos, c/b/ui/ash

Bug:  798569 
Change-Id: Icbf148140ecf76f02f795bf8022e5a397933d638
Reviewed-on: https://chromium-review.googlesource.com/1030818
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554200}
[add] https://crrev.com/4e9181c91cd5c3b3d5b40972747276ef17a02d5d/chrome/browser/chromeos/README.md
[add] https://crrev.com/4e9181c91cd5c3b3d5b40972747276ef17a02d5d/chrome/browser/ui/ash/README.md
Project Member

Comment 19 by bugdroid1@chromium.org, Apr 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e44d52698bade6feb3b863e3cb25cccd310dbf2

commit 2e44d52698bade6feb3b863e3cb25cccd310dbf2
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Apr 27 00:55:14 2018

Move NetworkPortalNotificationController to c/b/ui/ash

This CL:
* Moves NetworkPortalNotificationController to c/b/ui/ash
* Eliminates NetworkPortalDetectorObserver and the src/ash dependencies
  in NetworkPortalNotificationController.
* Instead directly (and more correctly) observe
  chromeos::NetworkPortalDetector in ash::TrayNetworkStateObserver.

For added DEPS for components/captive_portal (file moved):
TBR=mmenke@chromium.org

Bug:  798569 
Change-Id: I0042c9067d4f3a64edc2185cd01c9ebe9a1abe3e
Reviewed-on: https://chromium-review.googlesource.com/1029450
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554242}
[modify] https://crrev.com/2e44d52698bade6feb3b863e3cb25cccd310dbf2/ash/BUILD.gn
[modify] https://crrev.com/2e44d52698bade6feb3b863e3cb25cccd310dbf2/ash/system/network/network_feature_pod_button.cc
[modify] https://crrev.com/2e44d52698bade6feb3b863e3cb25cccd310dbf2/ash/system/network/network_feature_pod_button.h
[delete] https://crrev.com/e63d006db1eae906d7c78f695c9bddabf03e3f06/ash/system/network/network_portal_detector_observer.h
[modify] https://crrev.com/2e44d52698bade6feb3b863e3cb25cccd310dbf2/ash/system/network/tray_network.cc
[modify] https://crrev.com/2e44d52698bade6feb3b863e3cb25cccd310dbf2/ash/system/network/tray_network.h
[modify] https://crrev.com/2e44d52698bade6feb3b863e3cb25cccd310dbf2/ash/system/network/tray_network_state_observer.cc
[modify] https://crrev.com/2e44d52698bade6feb3b863e3cb25cccd310dbf2/ash/system/network/tray_network_state_observer.h
[modify] https://crrev.com/2e44d52698bade6feb3b863e3cb25cccd310dbf2/ash/system/tray/system_tray_notifier.cc
[modify] https://crrev.com/2e44d52698bade6feb3b863e3cb25cccd310dbf2/ash/system/tray/system_tray_notifier.h
[modify] https://crrev.com/2e44d52698bade6feb3b863e3cb25cccd310dbf2/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/2e44d52698bade6feb3b863e3cb25cccd310dbf2/chrome/browser/chromeos/net/DEPS
[modify] https://crrev.com/2e44d52698bade6feb3b863e3cb25cccd310dbf2/chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc
[modify] https://crrev.com/2e44d52698bade6feb3b863e3cb25cccd310dbf2/chrome/browser/chromeos/net/network_portal_web_dialog.h
[modify] https://crrev.com/2e44d52698bade6feb3b863e3cb25cccd310dbf2/chrome/browser/extensions/api/networking_config_chromeos_apitest_chromeos.cc
[modify] https://crrev.com/2e44d52698bade6feb3b863e3cb25cccd310dbf2/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/2e44d52698bade6feb3b863e3cb25cccd310dbf2/chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.cc
[add] https://crrev.com/2e44d52698bade6feb3b863e3cb25cccd310dbf2/chrome/browser/ui/ash/network/DEPS
[rename] https://crrev.com/2e44d52698bade6feb3b863e3cb25cccd310dbf2/chrome/browser/ui/ash/network/network_portal_notification_controller.cc
[rename] https://crrev.com/2e44d52698bade6feb3b863e3cb25cccd310dbf2/chrome/browser/ui/ash/network/network_portal_notification_controller.h
[rename] https://crrev.com/2e44d52698bade6feb3b863e3cb25cccd310dbf2/chrome/browser/ui/ash/network/network_portal_notification_controller_unittest.cc
[modify] https://crrev.com/2e44d52698bade6feb3b863e3cb25cccd310dbf2/chrome/test/BUILD.gn
Project Member

Comment 20 by bugdroid1@chromium.org, May 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2505c48018d0fe9a8d7c1b28f3f68a9f2f43b097

commit 2505c48018d0fe9a8d7c1b28f3f68a9f2f43b097
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri May 04 06:40:57 2018

Merge display service providers and move to ash

ConsoleServiceProvider and DisplayPowerServiceProvider both now
implement org.chromium.DisplayService so merge them and their
delegate implementations and move them to src/ash since the
implementaitons only have ash dependencies.

The new implementation is owned by the recently introduced
AshDBusServices class.

BUG= 798569 

Change-Id: I54d3b332a68ba453613745ed8ead966efb925de9
Reviewed-on: https://chromium-review.googlesource.com/1041283
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556003}
[modify] https://crrev.com/2505c48018d0fe9a8d7c1b28f3f68a9f2f43b097/ash/BUILD.gn
[modify] https://crrev.com/2505c48018d0fe9a8d7c1b28f3f68a9f2f43b097/ash/dbus/ash_dbus_services.cc
[modify] https://crrev.com/2505c48018d0fe9a8d7c1b28f3f68a9f2f43b097/ash/dbus/ash_dbus_services.h
[add] https://crrev.com/2505c48018d0fe9a8d7c1b28f3f68a9f2f43b097/ash/dbus/display_service_provider.cc
[add] https://crrev.com/2505c48018d0fe9a8d7c1b28f3f68a9f2f43b097/ash/dbus/display_service_provider.h
[modify] https://crrev.com/2505c48018d0fe9a8d7c1b28f3f68a9f2f43b097/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/2505c48018d0fe9a8d7c1b28f3f68a9f2f43b097/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/2505c48018d0fe9a8d7c1b28f3f68a9f2f43b097/chrome/browser/chromeos/chrome_browser_main_chromeos.h
[delete] https://crrev.com/f28d67fcf037d672ece700defceb58801ec34b18/chrome/browser/chromeos/dbus/chrome_console_service_provider_delegate.cc
[delete] https://crrev.com/f28d67fcf037d672ece700defceb58801ec34b18/chrome/browser/chromeos/dbus/chrome_console_service_provider_delegate.h
[delete] https://crrev.com/f28d67fcf037d672ece700defceb58801ec34b18/chrome/browser/chromeos/dbus/chrome_display_power_service_provider_delegate.cc
[delete] https://crrev.com/f28d67fcf037d672ece700defceb58801ec34b18/chrome/browser/chromeos/dbus/chrome_display_power_service_provider_delegate.h
[modify] https://crrev.com/2505c48018d0fe9a8d7c1b28f3f68a9f2f43b097/chromeos/BUILD.gn
[delete] https://crrev.com/f28d67fcf037d672ece700defceb58801ec34b18/chromeos/dbus/services/console_service_provider.cc
[delete] https://crrev.com/f28d67fcf037d672ece700defceb58801ec34b18/chromeos/dbus/services/console_service_provider.h
[delete] https://crrev.com/f28d67fcf037d672ece700defceb58801ec34b18/chromeos/dbus/services/display_power_service_provider.cc
[delete] https://crrev.com/f28d67fcf037d672ece700defceb58801ec34b18/chromeos/dbus/services/display_power_service_provider.h
Project Member

Comment 21 by bugdroid1@chromium.org, May 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93d3e5b1bf523d28335621945b0496b6df7f3ffa

commit 93d3e5b1bf523d28335621945b0496b6df7f3ffa
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Sat May 05 01:14:50 2018

Move ash_constants.h to ash/public

This also converts everything to inlined constexpr.

Bug:  798569 
Change-Id: Ia5f026a2e30b8a590e761860d063d42cfdf54bbc
Reviewed-on: https://chromium-review.googlesource.com/1043647
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556284}
[modify] https://crrev.com/93d3e5b1bf523d28335621945b0496b6df7f3ffa/ash/BUILD.gn
[modify] https://crrev.com/93d3e5b1bf523d28335621945b0496b6df7f3ffa/ash/accessibility/accessibility_controller.h
[modify] https://crrev.com/93d3e5b1bf523d28335621945b0496b6df7f3ffa/ash/accessibility/accessibility_controller_unittest.cc
[delete] https://crrev.com/03bb7d18441a1d38de0797f1902627a9855c3353/ash/ash_constants.cc
[modify] https://crrev.com/93d3e5b1bf523d28335621945b0496b6df7f3ffa/ash/autoclick/autoclick_controller.cc
[modify] https://crrev.com/93d3e5b1bf523d28335621945b0496b6df7f3ffa/ash/autoclick/autoclick_controller.h
[modify] https://crrev.com/93d3e5b1bf523d28335621945b0496b6df7f3ffa/ash/components/autoclick/autoclick_application.cc
[modify] https://crrev.com/93d3e5b1bf523d28335621945b0496b6df7f3ffa/ash/display/cursor_window_controller.cc
[modify] https://crrev.com/93d3e5b1bf523d28335621945b0496b6df7f3ffa/ash/display/cursor_window_controller.h
[modify] https://crrev.com/93d3e5b1bf523d28335621945b0496b6df7f3ffa/ash/frame/caption_buttons/frame_caption_button.cc
[modify] https://crrev.com/93d3e5b1bf523d28335621945b0496b6df7f3ffa/ash/frame/frame_border_hit_test.cc
[modify] https://crrev.com/93d3e5b1bf523d28335621945b0496b6df7f3ffa/ash/login/ui/login_bubble.cc
[modify] https://crrev.com/93d3e5b1bf523d28335621945b0496b6df7f3ffa/ash/login/ui/login_button.cc
[modify] https://crrev.com/93d3e5b1bf523d28335621945b0496b6df7f3ffa/ash/login/ui/login_pin_view.cc
[modify] https://crrev.com/93d3e5b1bf523d28335621945b0496b6df7f3ffa/ash/login/ui/login_user_view.cc
[modify] https://crrev.com/93d3e5b1bf523d28335621945b0496b6df7f3ffa/ash/public/cpp/BUILD.gn
[rename] https://crrev.com/93d3e5b1bf523d28335621945b0496b6df7f3ffa/ash/public/cpp/ash_constants.h
[modify] https://crrev.com/93d3e5b1bf523d28335621945b0496b6df7f3ffa/ash/root_window_controller.cc
[modify] https://crrev.com/93d3e5b1bf523d28335621945b0496b6df7f3ffa/ash/shelf/login_shelf_view.cc
[modify] https://crrev.com/93d3e5b1bf523d28335621945b0496b6df7f3ffa/ash/shelf/shelf_button.cc
[modify] https://crrev.com/93d3e5b1bf523d28335621945b0496b6df7f3ffa/ash/shelf/shelf_view.cc
[modify] https://crrev.com/93d3e5b1bf523d28335621945b0496b6df7f3ffa/ash/shell.cc
[modify] https://crrev.com/93d3e5b1bf523d28335621945b0496b6df7f3ffa/ash/system/ime_menu/ime_menu_tray.cc
[modify] https://crrev.com/93d3e5b1bf523d28335621945b0496b6df7f3ffa/ash/system/tray/actionable_view.cc
[modify] https://crrev.com/93d3e5b1bf523d28335621945b0496b6df7f3ffa/ash/system/tray/system_menu_button.cc
[modify] https://crrev.com/93d3e5b1bf523d28335621945b0496b6df7f3ffa/ash/system/tray/tray_background_view.cc
[modify] https://crrev.com/93d3e5b1bf523d28335621945b0496b6df7f3ffa/ash/system/tray/tray_popup_utils.cc
[modify] https://crrev.com/93d3e5b1bf523d28335621945b0496b6df7f3ffa/ash/system/user/button_from_view.cc
[modify] https://crrev.com/93d3e5b1bf523d28335621945b0496b6df7f3ffa/ash/wm/non_client_frame_controller.cc
[modify] https://crrev.com/93d3e5b1bf523d28335621945b0496b6df7f3ffa/ash/wm/resize_handle_window_targeter.cc
[modify] https://crrev.com/93d3e5b1bf523d28335621945b0496b6df7f3ffa/ash/wm/resize_shadow_and_cursor_unittest.cc
[modify] https://crrev.com/93d3e5b1bf523d28335621945b0496b6df7f3ffa/ash/wm/splitview/split_view_divider.cc
[modify] https://crrev.com/93d3e5b1bf523d28335621945b0496b6df7f3ffa/ash/wm/window_util.cc
[modify] https://crrev.com/93d3e5b1bf523d28335621945b0496b6df7f3ffa/ash/wm/workspace/multi_window_resize_controller_unittest.cc
[modify] https://crrev.com/93d3e5b1bf523d28335621945b0496b6df7f3ffa/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/93d3e5b1bf523d28335621945b0496b6df7f3ffa/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc
[modify] https://crrev.com/93d3e5b1bf523d28335621945b0496b6df7f3ffa/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/93d3e5b1bf523d28335621945b0496b6df7f3ffa/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
Project Member

Comment 22 by bugdroid1@chromium.org, May 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd12853a699cf427d072d8662213580abadf3d18

commit cd12853a699cf427d072d8662213580abadf3d18
Author: Muyuan Li <muyuanli@chromium.org>
Date: Sat May 12 00:06:56 2018

move c/b/chromeos/assistant to c/b/ui/ash/.

Bug:  798569 
Test: Manual build and test
Change-Id: I8050699311b1cb5c19859178ee5dcedebfa2538f
Reviewed-on: https://chromium-review.googlesource.com/1054700
Commit-Queue: Muyuan Li <muyuanli@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558066}
[modify] https://crrev.com/cd12853a699cf427d072d8662213580abadf3d18/chrome/browser/chromeos/BUILD.gn
[delete] https://crrev.com/b11895a7e82539e7422b6b67fe04025f99ede15a/chrome/browser/chromeos/assistant/DEPS
[delete] https://crrev.com/b11895a7e82539e7422b6b67fe04025f99ede15a/chrome/browser/chromeos/assistant/assistant_client.h
[modify] https://crrev.com/cd12853a699cf427d072d8662213580abadf3d18/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/cd12853a699cf427d072d8662213580abadf3d18/chrome/browser/chromeos/chrome_browser_main_chromeos.h
[modify] https://crrev.com/cd12853a699cf427d072d8662213580abadf3d18/chrome/browser/chromeos/login/session/chrome_session_manager.cc
[modify] https://crrev.com/cd12853a699cf427d072d8662213580abadf3d18/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/cd12853a699cf427d072d8662213580abadf3d18/chrome/browser/ui/BUILD.gn
[rename] https://crrev.com/cd12853a699cf427d072d8662213580abadf3d18/chrome/browser/ui/ash/assistant/assistant_card_renderer.cc
[rename] https://crrev.com/cd12853a699cf427d072d8662213580abadf3d18/chrome/browser/ui/ash/assistant/assistant_card_renderer.h
[rename] https://crrev.com/cd12853a699cf427d072d8662213580abadf3d18/chrome/browser/ui/ash/assistant/assistant_client.cc
[add] https://crrev.com/cd12853a699cf427d072d8662213580abadf3d18/chrome/browser/ui/ash/assistant/assistant_client.h
[rename] https://crrev.com/cd12853a699cf427d072d8662213580abadf3d18/chrome/browser/ui/ash/assistant/platform_audio_input_host.cc
[rename] https://crrev.com/cd12853a699cf427d072d8662213580abadf3d18/chrome/browser/ui/ash/assistant/platform_audio_input_host.h
[modify] https://crrev.com/cd12853a699cf427d072d8662213580abadf3d18/chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.cc
[modify] https://crrev.com/cd12853a699cf427d072d8662213580abadf3d18/chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.h
[modify] https://crrev.com/cd12853a699cf427d072d8662213580abadf3d18/chrome/browser/ui/ash/session_controller_client.cc

Comment 23 by steve...@chromium.org, May 14 2018

Labels: -M-67 M-68
Project Member

Comment 24 by bugdroid1@chromium.org, May 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/acb53bd0a13e18d85743f30c83dd560ea1e8f175

commit acb53bd0a13e18d85743f30c83dd560ea1e8f175
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Tue May 15 19:04:54 2018

Narrow and document ash/ DEPS in c/b/chromeos

This also eliminates a few unnecessary includes.

Bug:  798569 
For c/b/chromeos/policy DEPS changes:
TBR=emaxx@chromium.org

Change-Id: I80a73a68819f0295f9c81b910467c6e38dd2571e
Reviewed-on: https://chromium-review.googlesource.com/1041568
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558796}
[modify] https://crrev.com/acb53bd0a13e18d85743f30c83dd560ea1e8f175/chrome/browser/chromeos/DEPS
[add] https://crrev.com/acb53bd0a13e18d85743f30c83dd560ea1e8f175/chrome/browser/chromeos/accessibility/DEPS
[add] https://crrev.com/acb53bd0a13e18d85743f30c83dd560ea1e8f175/chrome/browser/chromeos/app_mode/arc/DEPS
[add] https://crrev.com/acb53bd0a13e18d85743f30c83dd560ea1e8f175/chrome/browser/chromeos/arc/DEPS
[modify] https://crrev.com/acb53bd0a13e18d85743f30c83dd560ea1e8f175/chrome/browser/chromeos/certificate_provider/pin_dialog_manager.cc
[modify] https://crrev.com/acb53bd0a13e18d85743f30c83dd560ea1e8f175/chrome/browser/chromeos/display/DEPS
[modify] https://crrev.com/acb53bd0a13e18d85743f30c83dd560ea1e8f175/chrome/browser/chromeos/extensions/DEPS
[delete] https://crrev.com/57b825bc05416a02bada7a88907e58e49545cbe9/chrome/browser/chromeos/hats/DEPS
[modify] https://crrev.com/acb53bd0a13e18d85743f30c83dd560ea1e8f175/chrome/browser/chromeos/input_method/DEPS
[modify] https://crrev.com/acb53bd0a13e18d85743f30c83dd560ea1e8f175/chrome/browser/chromeos/lock_screen_apps/state_controller.cc
[modify] https://crrev.com/acb53bd0a13e18d85743f30c83dd560ea1e8f175/chrome/browser/chromeos/login/DEPS
[modify] https://crrev.com/acb53bd0a13e18d85743f30c83dd560ea1e8f175/chrome/browser/chromeos/net/DEPS
[modify] https://crrev.com/acb53bd0a13e18d85743f30c83dd560ea1e8f175/chrome/browser/chromeos/policy/DEPS
[add] https://crrev.com/acb53bd0a13e18d85743f30c83dd560ea1e8f175/chrome/browser/chromeos/policy/remote_commands/DEPS
[modify] https://crrev.com/acb53bd0a13e18d85743f30c83dd560ea1e8f175/chrome/browser/chromeos/power/idle_action_warning_dialog_view.cc
[add] https://crrev.com/acb53bd0a13e18d85743f30c83dd560ea1e8f175/chrome/browser/chromeos/status/DEPS
[add] https://crrev.com/acb53bd0a13e18d85743f30c83dd560ea1e8f175/chrome/browser/chromeos/system_logs/DEPS
[add] https://crrev.com/acb53bd0a13e18d85743f30c83dd560ea1e8f175/chrome/browser/chromeos/ui/DEPS

Comment 26 by steve...@chromium.org, May 16 2018

Status: Fixed (was: Started)
The major goals for this issue have been accomplished:
* c/b/ui/views/ash has been eliminated
* c/b/chromeos and c/b/ui/ash have README.md files describing what belongs where
* c/b/chromeos and c/b/ui/ash DEPS have been narrowed with specific bugs assigned to each violation.

Further work will be tracked individually.
Project Member

Comment 28 by bugdroid1@chromium.org, Jun 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26121cb9c1988b713d8a4ad2fe849ef7f5399099

commit 26121cb9c1988b713d8a4ad2fe849ef7f5399099
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Jun 25 20:54:40 2018

Remove remaining +ash and !ash in chrome/ DEPS

Bug:  798569 
Change-Id: I68aa4c7f08458324a6a59aa9cd2d8bfafeb95c99
Reviewed-on: https://chromium-review.googlesource.com/1111024
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570173}
[modify] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/DEPS
[modify] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/chromeos/DEPS
[modify] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/chromeos/accessibility/DEPS
[delete] https://crrev.com/1f404f7107727532c665a6aed5806b5ff8ef46dd/chrome/browser/chromeos/arc/DEPS
[add] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/chromeos/arc/accessibility/DEPS
[add] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/chromeos/arc/boot_phase_monitor/DEPS
[add] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/chromeos/arc/screen_capture/DEPS
[add] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/chromeos/arc/voice_interaction/DEPS
[modify] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/chromeos/display/DEPS
[modify] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/chromeos/display/output_protection_controller_ash.cc
[modify] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/chromeos/input_method/DEPS
[modify] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/chromeos/login/DEPS
[add] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/chromeos/login/lock/DEPS
[modify] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/chromeos/login/ui/DEPS
[modify] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/chromeos/policy/DEPS
[modify] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/chromeos/system_logs/DEPS
[modify] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/devtools/protocol/DEPS
[modify] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/extensions/DEPS
[modify] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/extensions/api/automation/DEPS
[modify] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/extensions/api/virtual_keyboard_private/DEPS
[add] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/extensions/system_display/DEPS
[modify] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/media/webrtc/DEPS
[modify] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/resource_coordinator/DEPS
[modify] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/ui/DEPS
[delete] https://crrev.com/1f404f7107727532c665a6aed5806b5ff8ef46dd/chrome/browser/ui/app_list/DEPS
[delete] https://crrev.com/1f404f7107727532c665a6aed5806b5ff8ef46dd/chrome/browser/ui/app_list/arc/DEPS
[add] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/ui/app_list/search/answer_card/DEPS
[modify] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/ui/app_list/search/answer_card/answer_card_web_contents.cc
[modify] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/ui/ash/DEPS
[modify] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/ui/ash/assistant/web_contents_manager.cc
[modify] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/ui/ash/ksv/DEPS
[modify] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/ui/ash/launcher/DEPS
[modify] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/ui/ash/multi_user/DEPS
[modify] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/ui/ash/network/DEPS
[modify] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/ui/aura/accessibility/DEPS
[modify] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/ui/aura/accessibility/automation_manager_aura.cc
[delete] https://crrev.com/1f404f7107727532c665a6aed5806b5ff8ef46dd/chrome/browser/ui/toolbar/DEPS
[modify] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/ui/views/DEPS
[modify] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/ui/views/apps/DEPS
[modify] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/ui/views/frame/DEPS
[add] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/ui/views/tabs/DEPS
[modify] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/ui/views/tabs/window_finder_ash.cc
[add] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/ui/views/touch_uma/DEPS
[modify] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/ui/webui/chromeos/emulator/DEPS
[modify] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/ui/webui/chromeos/login/DEPS
[modify] https://crrev.com/26121cb9c1988b713d8a4ad2fe849ef7f5399099/chrome/browser/ui/window_sizer/DEPS
►

Sign in to add a comment