New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 798561 link

Starred by 1 user
Status: Fixed
Owner:
cjgrant@chromium.org
Closed: Jan 2018
Cc:
█ ymalik@chromium.org
█ asimjour@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

Reticle not visible when laser hits keyboard

Project Member Reported by cjgrant@chromium.org, Jan 2 2018 
ToT as of Jan 2nd:  When editing omnibox search text, the reticle is not rendered while hovering on the keyboard.  The keyboard still works though.

For visual consistency, we should be showing the reticle.

Separate from the visibility, we also need a way to orient the reticle, as the keyboard isn't a single plane.  The keyboard apparently reports the hit location, but not plane on which the hit occurred.  We may be able to work around this by pointing the reticle at the user.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/082ce18a6c43db66a14ae214364e54d2c702c28a

commit 082ce18a6c43db66a14ae214364e54d2c702c28a
Author: Christopher Grant <cjgrant@chromium.org>
Date: Tue Jan 02 23:22:19 2018

VR: Draw the controller group after the keyboard

This allows the reticle to appear on the keyboard while typing.

BUG= 798561 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I647849e9556647bbbf25dc855761329926037edc
Reviewed-on: https://chromium-review.googlesource.com/847932
Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526546}
[modify] https://crrev.com/082ce18a6c43db66a14ae214364e54d2c702c28a/chrome/browser/vr/ui_scene_creator.cc

Comment 2 by cjgrant@chromium.org, Jan 3 2018

Status: Fixed (was: Started)

Comment 3 by dougman@chromium.org, Feb 7 2018

Labels: Test-Complete
►

Sign in to add a comment