No visual feedback of update button in MD chrome://extension |
|||||||
Issue descriptionIn current Dev, clicking the Update button in chrome://extension has no visual feedback indicating that anything has happened (no spinner that at least spins a cycle, no visual repopulation of elements). This might be WAI, but James suggested I'd check with you. Feel free to reassign/close as WAI.
,
Feb 7 2018
Assigning to bettes@ for UX input
,
Feb 12 2018
,
Feb 13 2018
Re-directing to namratakannan@ for UX consultation. Also attaching a screenshot of a toast notification from the Bookmarks page. Maybe a similar approach (without the "undo" button) would suffice.
,
Feb 14 2018
Yup. We can display a spinner when we click on update as the update is processing and show a similar toast for feedback once the update is done. Some screenshots attached.
,
Feb 14 2018
Could we disable the "Update" button and place the spinner next to the button (on the right). This would make the implementation a bit simpler, and also matches what we do in other similar cases, see screenshot from chrome://settings/resetProfileSettings.
,
Feb 14 2018
Update for extensions is VERY fast. Do we really need a spinner?
,
Feb 14 2018
The spinner is there to add visual feedback that anything happened at all. Updating is so fast that a user can't tell whether the button is connected to anything at all. A spinner fake-spinning for half a second would mitigate that.
,
Feb 16 2018
@6, that SGTM, but defer to Namrata for final call on UX. I do agree that we should have a spinner, even if "fake" in some cases. I think extension update times can vary though depending on size of the extension, network conditions, etc...?
,
Feb 17 2018
Is the spinner necessary in addition to the toast? How about only having the toast as follows: 1) As soon as the user clicks "Update" the toast shows up saying "Updating extensions..." 2) Once updating is done, it changes to what is shown in the 2nd screenshot of comment#5. Even if 1 is too short, 2 stays for a few seconds visible, so the user always has feedback. Thoughts?
,
Feb 17 2018
,
Feb 20 2018
Like the idea by Demetrios. Updated mocks to reflect this. This approach should work for both short and long wait-times for update.
,
Feb 20 2018
LGTM
,
Feb 20 2018
Thanks everyone. Assigning this to aee@, now that we have finalized mocks.
,
Feb 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e9b4a41be1eea9bfdf8ec9a7b719db7b7cf91ad commit 4e9b4a41be1eea9bfdf8ec9a7b719db7b7cf91ad Author: Esmael El-Moslimany <aee@chromium.org> Date: Mon Feb 26 16:55:16 2018 MD Extensions: display toast while and after extensions are updated Bug: 798555 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7e2f540e7aaf515d7a2b0e3cc19fdee792bd92b1 Reviewed-on: https://chromium-review.googlesource.com/932980 Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#539168} [modify] https://crrev.com/4e9b4a41be1eea9bfdf8ec9a7b719db7b7cf91ad/chrome/app/md_extensions_strings.grdp [modify] https://crrev.com/4e9b4a41be1eea9bfdf8ec9a7b719db7b7cf91ad/chrome/browser/policy/policy_browsertest.cc [modify] https://crrev.com/4e9b4a41be1eea9bfdf8ec9a7b719db7b7cf91ad/chrome/browser/resources/md_extensions/toolbar.html [modify] https://crrev.com/4e9b4a41be1eea9bfdf8ec9a7b719db7b7cf91ad/chrome/browser/resources/md_extensions/toolbar.js [modify] https://crrev.com/4e9b4a41be1eea9bfdf8ec9a7b719db7b7cf91ad/chrome/browser/ui/webui/extensions/extensions_ui.cc [modify] https://crrev.com/4e9b4a41be1eea9bfdf8ec9a7b719db7b7cf91ad/chrome/test/data/webui/extensions/extension_toolbar_test.js
,
Feb 26 2018
,
Aug 31
Issue 28814 has been merged into this issue. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by dpa...@chromium.org
, Jan 4 2018Labels: -Type-Bug Proj-MaterialDesign-WebUI OS-Chrome OS-Linux OS-Mac OS-Windows Type-Feature
Owner: ----