New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 798521 link

Starred by 1 user
Status: Fixed
Owner:
aboxhall@chromium.org
Closed: Feb 2018
Cc:
pbomm...@chromium.org
█ viswatej...@techmahindra.com
█ sc00335...@techmahindra.com
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

Open Color picker is not working

Reported by arto.paa...@gmail.com, Jan 2 2018 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3309.0 Safari/537.36

Steps to reproduce the problem:
1. Open DevTools
2. Inspect any element
3. Click the colored square before the css color property value

What is the expected behavior?
Color picker should open.

What went wrong?
Color picker won't open. Nothing happens when the square is clicked.

Did this work before? Yes Version 63.0.3239.84 (Official Build) (64-bit)

Chrome version: 65.0.3309.0  Channel: canary
OS Version: OS X 10.13.2
Flash Version: 

The color picker works for other css properites than "color". For example, it works for "background" and "border-color" properties.

Comment 1 by viswatej...@techmahindra.com, Jan 3 2018 

Able to reproduce the issue on reported version 65.0.3309.0 using Ubuntu 14.04, Mac 10.13.1 and Windows-10 hence providing Bisect Info

Bisect Info:
================
Good build: 65.0.3286.0
Bad build: 65.0.3287.0

You are probably looking for a change made after 522124 (known good), but no later than 522125 (first known bad).

https://chromium.googlesource.com/chromium/src/+log/7c099ecf34993d728d703c510a3e260d29cca9ed..9e8423ab9c4443dbff2708f25b7c69acbd74ba0a

Reviewed-on: https://chromium-review.googlesource.com/627346

@Alice Boxhall: Please confirm the issue and help in re-assigning if it is not related to your change.
Adding ReleaseBlock-Stable as it seems recent break, feel free to remove it if not applicable.

Thanks!

Comment 2 by sc00335...@techmahindra.com, Jan 3 2018

Cc: ranjitkan@chromium.org pbomm...@chromium.org sc00335...@techmahindra.com viswatej...@techmahindra.com
Labels: -Pri-2 hasbisect-per-revision ReleaseBlock-Stable Triaged-ET M-65 Needs-Triage-M65 OS-Linux OS-Windows Pri-1
Owner: aboxhall@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 3 by aboxhall@chromium.org, Jan 5 2018

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/969b36422cb489184d3f471b85803ddbca0d244e

commit 969b36422cb489184d3f471b85803ddbca0d244e
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Mon Jan 08 23:28:55 2018

[Devtools] Don't try to resize if there is no selected palette yet.

Bug:  798521 
Change-Id: I03c1557e45f30ef016798377e87feea6c979cdca
Reviewed-on: https://chromium-review.googlesource.com/851513
Reviewed-by: Erik Luo <luoe@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527808}
[modify] https://crrev.com/969b36422cb489184d3f471b85803ddbca0d244e/third_party/WebKit/Source/devtools/front_end/color_picker/Spectrum.js

Comment 5 by vamshi.k...@techmahindra.com, Jan 17 2018

Labels: TE-Verified-M65 TE-Verified-65.0.3322.3
Verified the fix on Mac 10.13.1, Windows-10 and Ubuntu 14.04 using Chrome version #65.0.3322.3 as per the comment #0.
Attaching screen shot for reference.
Observed that colour picker is shown.
Hence, the fix is working as expected.
Adding the verified labels.

Thanks...!!
798521.png
1.1 MB View Download

Comment 6 by jmukthavaram@chromium.org, Jan 22 2018 

aboxhall@, please mark it as 'Fixed' if there is no other pending CL exists.
Thanks..!

Comment 7 by jmukthavaram@chromium.org, Jan 30 2018 

aboxhall@, Could you please respond on C#6?

Thanks..!

Comment 8 by aboxhall@chromium.org, Feb 6 2018

Status: Fixed (was: Started)
Project Member

Comment 9 by blocker...@chrome-infra-auth.iam.gserviceaccount.com, Feb 6 2018

Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-65; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-65 label, otherwise remove Merge-TBD label. Thanks.

Comment 10 by gov...@chromium.org, Feb 7 2018

Labels: -Merge-TBD
This change is already in M65 branch (3325) so no merge is needed. Hence, removing "Merge-TBD" label. Thank you.
►

Sign in to add a comment