New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 798518 link

Starred by 1 user
Status: Fixed
Owner:
wylieb@chromium.org
Closed: Jan 2018
Cc:
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 780141



Sign in to add a comment

[Findit] Flake Analyzer - Clicking bug in analysis info header causes dropdown to expand and bug opened in same tab

Project Member Reported by lijeffrey@chromium.org, Jan 2 2018 
When clicking the bug link in the header of the analysis info section in the UI, the dropdown expands but the bug is then opened in the same tab.

1. Open the bug in a separate tab
2. The dropdown should not open (looks jarring), though this can be a design choice
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/638b5868294c094be070efffc3bb96c0ac59d397

commit 638b5868294c094be070efffc3bb96c0ac59d397
Author: Brandon Wylie <wylieb@chromium.org>
Date: Thu Jan 04 00:32:22 2018

[Findit] Expandable card should ignore link clicks inside of it

Right now, clicking a link inside the expandable card header will
toggle the card. This change fixes that as well as disables
the animation when clicking the header to reduce confusion.

Bug:798518
Change-Id: Ic0e1c79d4668362c0be9b16b163ef2ff720e4769
Reviewed-on: https://chromium-review.googlesource.com/847854
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/638b5868294c094be070efffc3bb96c0ac59d397/appengine/findit/ui/elements/analysis/flake/flake-analysis-info-demo.html
[modify] https://crrev.com/638b5868294c094be070efffc3bb96c0ac59d397/appengine/findit/ui/elements/components/expandable-card.html

Comment 2 by wylieb@chromium.org, Jan 10 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment